[INFO] fetching crate mini-builder-rs 0.1.3... [INFO] checking mini-builder-rs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mini-builder-rs 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate mini-builder-rs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mini-builder-rs 0.1.3 [INFO] finished tweaking crates.io crate mini-builder-rs 0.1.3 [INFO] tweaked toml for crates.io crate mini-builder-rs 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate mini-builder-rs 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 143fe347285fb4a3a8d443872cf43c108d8bf7e916e0f5809ffd5b6f430e80f1 [INFO] running `Command { std: "docker" "start" "-a" "143fe347285fb4a3a8d443872cf43c108d8bf7e916e0f5809ffd5b6f430e80f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "143fe347285fb4a3a8d443872cf43c108d8bf7e916e0f5809ffd5b6f430e80f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "143fe347285fb4a3a8d443872cf43c108d8bf7e916e0f5809ffd5b6f430e80f1", kill_on_drop: false }` [INFO] [stdout] 143fe347285fb4a3a8d443872cf43c108d8bf7e916e0f5809ffd5b6f430e80f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e78a0f3a28f7623e49490e825d2824c7358bd5dc521d9e4e73908d9a959fb7b7 [INFO] running `Command { std: "docker" "start" "-a" "e78a0f3a28f7623e49490e825d2824c7358bd5dc521d9e4e73908d9a959fb7b7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Checking hmap v0.1.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking time v0.3.12 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking simple_logger v2.2.0 [INFO] [stderr] Checking mini-builder-rs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `node::NodeContent` [INFO] [stdout] --> src/evaluator/evaluator_builder_error.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | parser::{node::NodeContent, parser_error::ParserError}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `node::NodeContent` [INFO] [stdout] --> src/evaluator/evaluator_builder_error.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | parser::{node::NodeContent, parser_error::ParserError}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | // directories [INFO] [stdout] 311 | | sources_dir, [INFO] [stdout] 312 | | templates_dir, [INFO] [stdout] ... | [INFO] [stdout] 322 | | options, [INFO] [stdout] 323 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&dyn std::error::Error` instead of cloning the inner type [INFO] [stdout] --> src/builder/builder_error.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | Self::IoError(err) => Some(err.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/partial.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 21 | let evaluator = ContainedEvaluator::from_string(read_write_target.read.read())?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | read_write_target, [INFO] [stdout] 24 | | evaluator, [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | // directories [INFO] [stdout] 311 | | sources_dir, [INFO] [stdout] 312 | | templates_dir, [INFO] [stdout] ... | [INFO] [stdout] 322 | | options, [INFO] [stdout] 323 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/evaluator/mod.rs:354:44 [INFO] [stdout] | [INFO] [stdout] 354 | list_dependencies_expression(expression.borrow(), dependencies); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Expression<'_>` does not implement `Borrow`, so calling `borrow` on `&Expression<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 354 - list_dependencies_expression(expression.borrow(), dependencies); [INFO] [stdout] 354 + list_dependencies_expression(expression, dependencies); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Expression<'_>`, implement `Clone` for it [INFO] [stdout] --> src/parser/expression.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Clone)] [INFO] [stdout] 12 | pub enum Expression<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/contained_evaluator.rs:53:6 [INFO] [stdout] | [INFO] [stdout] 33 | let source = Box::pin(source); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let tokens = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let nodes = Box::pin(Parser::new(tokens_slice).parse()?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let evaluator = evaluator_builder.build_evaluator()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | // pins [INFO] [stdout] 55 | | _source: source, [INFO] [stdout] 56 | | _nodes: nodes, [INFO] [stdout] ... | [INFO] [stdout] 60 | | evaluator, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/evaluator.rs:74:6 [INFO] [stdout] | [INFO] [stdout] 50 | let mut if_blocks = vec![(first_expression, Vec::new())]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut else_blocks = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(IfBlock::new(if_blocks, else_blocks)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:224:6 [INFO] [stdout] | [INFO] [stdout] 222 | let expression = self.parse_expression()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Ok(Box::new((name, expression))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:323:6 [INFO] [stdout] | [INFO] [stdout] 317 | let args = if Some(TokenType::LBracket) == self.peek_type() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(Expression::Builder(name, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn expression(location: usize, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self::new(location, NodeContent::Expression(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn assignment(location: usize, name: &'a str, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | NodeContent::Assignment(name, TokenType::Assign, expression), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn if_node(location: usize, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self::new(location, NodeContent::If(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn for_node(location: usize, var_name: &'a str, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Self::new(location, NodeContent::For(var_name, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn elif(location: usize, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self::new(location, NodeContent::Elif(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&dyn std::error::Error` instead of cloning the inner type [INFO] [stdout] --> src/builder/builder_error.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | Self::IoError(err) => Some(err.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini-builder-rs` (lib) due to 12 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/partial.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 21 | let evaluator = ContainedEvaluator::from_string(read_write_target.read.read())?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | read_write_target, [INFO] [stdout] 24 | | evaluator, [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/evaluator/mod.rs:354:44 [INFO] [stdout] | [INFO] [stdout] 354 | list_dependencies_expression(expression.borrow(), dependencies); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Expression<'_>` does not implement `Borrow`, so calling `borrow` on `&Expression<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 354 - list_dependencies_expression(expression.borrow(), dependencies); [INFO] [stdout] 354 + list_dependencies_expression(expression, dependencies); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Expression<'_>`, implement `Clone` for it [INFO] [stdout] --> src/parser/expression.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Clone)] [INFO] [stdout] 12 | pub enum Expression<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/contained_evaluator.rs:53:6 [INFO] [stdout] | [INFO] [stdout] 33 | let source = Box::pin(source); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let tokens = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let nodes = Box::pin(Parser::new(tokens_slice).parse()?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let evaluator = evaluator_builder.build_evaluator()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | // pins [INFO] [stdout] 55 | | _source: source, [INFO] [stdout] 56 | | _nodes: nodes, [INFO] [stdout] ... | [INFO] [stdout] 60 | | evaluator, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator/evaluator.rs:74:6 [INFO] [stdout] | [INFO] [stdout] 50 | let mut if_blocks = vec![(first_expression, Vec::new())]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut else_blocks = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(IfBlock::new(if_blocks, else_blocks)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:224:6 [INFO] [stdout] | [INFO] [stdout] 222 | let expression = self.parse_expression()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Ok(Box::new((name, expression))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:323:6 [INFO] [stdout] | [INFO] [stdout] 317 | let args = if Some(TokenType::LBracket) == self.peek_type() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(Expression::Builder(name, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn expression(location: usize, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self::new(location, NodeContent::Expression(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn assignment(location: usize, name: &'a str, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | NodeContent::Assignment(name, TokenType::Assign, expression), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn if_node(location: usize, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Self::new(location, NodeContent::If(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn for_node(location: usize, var_name: &'a str, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Self::new(location, NodeContent::For(var_name, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/node.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn elif(location: usize, expression: Expression<'a>) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self::new(location, NodeContent::Elif(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini-builder-rs` (lib test) due to 12 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e78a0f3a28f7623e49490e825d2824c7358bd5dc521d9e4e73908d9a959fb7b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e78a0f3a28f7623e49490e825d2824c7358bd5dc521d9e4e73908d9a959fb7b7", kill_on_drop: false }` [INFO] [stdout] e78a0f3a28f7623e49490e825d2824c7358bd5dc521d9e4e73908d9a959fb7b7