[INFO] fetching crate minetest-protocol 0.1.4... [INFO] checking minetest-protocol-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate minetest-protocol 0.1.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate minetest-protocol 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minetest-protocol 0.1.4 [INFO] finished tweaking crates.io crate minetest-protocol 0.1.4 [INFO] tweaked toml for crates.io crate minetest-protocol 0.1.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.6.2 (latest: v0.8.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zstd-safe v6.0.6 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 933740a1cdc4db1df6bfa4173e97f1dc10bf3a2dbe07b8c06ce9097869dd705b [INFO] running `Command { std: "docker" "start" "-a" "933740a1cdc4db1df6bfa4173e97f1dc10bf3a2dbe07b8c06ce9097869dd705b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "933740a1cdc4db1df6bfa4173e97f1dc10bf3a2dbe07b8c06ce9097869dd705b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "933740a1cdc4db1df6bfa4173e97f1dc10bf3a2dbe07b8c06ce9097869dd705b", kill_on_drop: false }` [INFO] [stdout] 933740a1cdc4db1df6bfa4173e97f1dc10bf3a2dbe07b8c06ce9097869dd705b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b6d8dd5b6b0eeef2a5c5da15e8d8ed8e5d595da973a1947f85a31ae8c25fc61 [INFO] running `Command { std: "docker" "start" "-a" "0b6d8dd5b6b0eeef2a5c5da15e8d8ed8e5d595da973a1947f85a31ae8c25fc61", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling zstd-safe v6.0.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling minetest-protocol-derive v0.1.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking minetest-protocol v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:145:56 [INFO] [stdout] | [INFO] [stdout] 124 | let socket_peer_runner = PeerRunner { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | tokio::spawn(async move { socket_peer_runner.run().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(remote_is_server: bool, to_controller: UnboundedSender>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Self { [INFO] [stdout] 177 | unreliable_out: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:178:26 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(remote_is_server: bool, to_controller: UnboundedSender>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | reliable_in: ReliableReceiver::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(remote_is_server: bool, to_controller: UnboundedSender>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | reliable_out: ReliableSender::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/socket.rs:60:64 [INFO] [stdout] | [INFO] [stdout] 50 | let minetest_socket_runner = MinetestSocketRunner { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | tokio::spawn(async move { minetest_socket_runner.run().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire/packet.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 226 | Ok(ReliableBody { [INFO] [stdout] | ____________^ [INFO] [stdout] 227 | | seqnum: u16::deserialize(deser)?, [INFO] [stdout] 228 | | inner: InnerBody::deserialize(deser)?, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire/packet.rs:249:30 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn into_reliable(self, seqnum: u16) -> PacketBody { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | PacketBody::Reliable(ReliableBody { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 250 | | seqnum: seqnum, [INFO] [stdout] 251 | | inner: self, [INFO] [stdout] 252 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire/types.rs:659:15 [INFO] [stdout] | [INFO] [stdout] 655 | let mut entries = Vec::with_capacity(COUNT); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | match entries.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minetest-protocol` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:145:56 [INFO] [stdout] | [INFO] [stdout] 124 | let socket_peer_runner = PeerRunner { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | tokio::spawn(async move { socket_peer_runner.run().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(remote_is_server: bool, to_controller: UnboundedSender>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Self { [INFO] [stdout] 177 | unreliable_out: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:178:26 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(remote_is_server: bool, to_controller: UnboundedSender>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | reliable_in: ReliableReceiver::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(remote_is_server: bool, to_controller: UnboundedSender>) -> Self { [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | reliable_out: ReliableSender::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/reliable_receiver.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 69 | let command = Command::ToClient(ToClientCommand::Hudrm(Box::new(HudrmSpec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | InnerBody::Original(OriginalBody { command }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/reliable_sender.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 174 | let command = Command::ToClient(ToClientCommand::Hudrm(Box::new(HudrmSpec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | InnerBody::Original(OriginalBody { command }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/socket.rs:60:64 [INFO] [stdout] | [INFO] [stdout] 50 | let minetest_socket_runner = MinetestSocketRunner { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | tokio::spawn(async move { minetest_socket_runner.run().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire/packet.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 226 | Ok(ReliableBody { [INFO] [stdout] | ____________^ [INFO] [stdout] 227 | | seqnum: u16::deserialize(deser)?, [INFO] [stdout] 228 | | inner: InnerBody::deserialize(deser)?, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire/packet.rs:249:30 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn into_reliable(self, seqnum: u16) -> PacketBody { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | PacketBody::Reliable(ReliableBody { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 250 | | seqnum: seqnum, [INFO] [stdout] 251 | | inner: self, [INFO] [stdout] 252 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire/types.rs:659:15 [INFO] [stdout] | [INFO] [stdout] 655 | let mut entries = Vec::with_capacity(COUNT); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | match entries.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minetest-protocol` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "0b6d8dd5b6b0eeef2a5c5da15e8d8ed8e5d595da973a1947f85a31ae8c25fc61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b6d8dd5b6b0eeef2a5c5da15e8d8ed8e5d595da973a1947f85a31ae8c25fc61", kill_on_drop: false }` [INFO] [stdout] 0b6d8dd5b6b0eeef2a5c5da15e8d8ed8e5d595da973a1947f85a31ae8c25fc61