[INFO] fetching crate min-cancel-token 0.1.0... [INFO] checking min-cancel-token-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate min-cancel-token 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate min-cancel-token 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate min-cancel-token 0.1.0 [INFO] finished tweaking crates.io crate min-cancel-token 0.1.0 [INFO] tweaked toml for crates.io crate min-cancel-token 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bc7fe8c05bbf0245eaa8a1b3b8df6b66e87d81b5b5d2e7e9274cf78340374e31 [INFO] running `Command { std: "docker" "start" "-a" "bc7fe8c05bbf0245eaa8a1b3b8df6b66e87d81b5b5d2e7e9274cf78340374e31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bc7fe8c05bbf0245eaa8a1b3b8df6b66e87d81b5b5d2e7e9274cf78340374e31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc7fe8c05bbf0245eaa8a1b3b8df6b66e87d81b5b5d2e7e9274cf78340374e31", kill_on_drop: false }` [INFO] [stdout] bc7fe8c05bbf0245eaa8a1b3b8df6b66e87d81b5b5d2e7e9274cf78340374e31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a834bd207cca6e10c67cfb0aa6ea1eb529857f12ed1a392574ea4472fb51532 [INFO] running `Command { std: "docker" "start" "-a" "9a834bd207cca6e10c67cfb0aa6ea1eb529857f12ed1a392574ea4472fb51532", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking min-cancel-token v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:184:25 [INFO] [stdout] | [INFO] [stdout] 184 | let mut first = CancellationFunc::from_raw(guard.first_func); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:193:21 [INFO] [stdout] | [INFO] [stdout] 193 | let mut prev = CancellationFunc::from_raw(func.prev); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:196:25 [INFO] [stdout] | [INFO] [stdout] 196 | let mut next = CancellationFunc::from_raw(func.next); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:251:25 [INFO] [stdout] | [INFO] [stdout] 251 | let mut last = CancellationFunc::from_raw(guard.last_func); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:299:25 [INFO] [stdout] | [INFO] [stdout] 299 | let mut first = CancellationFunc::from_raw(guard.first_func); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:37 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn with_current_cancellation_token(func: impl FnOnce(&dyn CancellationToken) -> R) -> R { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | CURRENT_CANCELLATION_TOKEN.with(|token| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 82 | | let x = &*token.borrow(); [INFO] [stdout] 83 | | match x { [INFO] [stdout] 84 | | Some(token) => func(*token), [INFO] [stdout] 85 | | None => func(&UncancellableToken::default()), [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:37 [INFO] [stdout] | [INFO] [stdout] 95 | func: impl FnOnce() -> R, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | CURRENT_CANCELLATION_TOKEN.with(|storage| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 113 | | let mut guard = storage.borrow_mut(); [INFO] [stdout] 114 | | let static_token: &'static dyn CancellationToken = unsafe { std::mem::transmute(token) }; [INFO] [stdout] ... | [INFO] [stdout] 123 | | func() [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/lib.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | std::mem::drop(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `*const ()` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 205 - std::mem::drop(data); [INFO] [stdout] 205 + let _ = data; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:259:37 [INFO] [stdout] | [INFO] [stdout] 230 | let mut guard = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | data: Arc::into_raw(self.state.clone()) as _, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `min-cancel-token` (lib) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9a834bd207cca6e10c67cfb0aa6ea1eb529857f12ed1a392574ea4472fb51532", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a834bd207cca6e10c67cfb0aa6ea1eb529857f12ed1a392574ea4472fb51532", kill_on_drop: false }` [INFO] [stdout] 9a834bd207cca6e10c67cfb0aa6ea1eb529857f12ed1a392574ea4472fb51532