[INFO] fetching crate migrate-state-file 0.1.0... [INFO] checking migrate-state-file-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate migrate-state-file 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate migrate-state-file 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate migrate-state-file 0.1.0 [INFO] finished tweaking crates.io crate migrate-state-file 0.1.0 [INFO] tweaked toml for crates.io crate migrate-state-file 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 80 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d12a589725d4ce5409829f29072f956ea3a2c8a060336a2170b7101c5d735bd [INFO] running `Command { std: "docker" "start" "-a" "9d12a589725d4ce5409829f29072f956ea3a2c8a060336a2170b7101c5d735bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d12a589725d4ce5409829f29072f956ea3a2c8a060336a2170b7101c5d735bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d12a589725d4ce5409829f29072f956ea3a2c8a060336a2170b7101c5d735bd", kill_on_drop: false }` [INFO] [stdout] 9d12a589725d4ce5409829f29072f956ea3a2c8a060336a2170b7101c5d735bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70102a501ef40f3b6e91ae36e4461f91037fae7e2bb0e5953b232b46eb1d4e60 [INFO] running `Command { std: "docker" "start" "-a" "70102a501ef40f3b6e91ae36e4461f91037fae7e2bb0e5953b232b46eb1d4e60", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking migrate-state v0.1.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking advisory-lock v0.3.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking migrate-state-test v0.1.0 [INFO] [stderr] Checking migrate-state-file v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:80 [INFO] [stdout] | [INFO] [stdout] 66 | async fn lock(self: Box, force: bool) -> Result> { [INFO] [stdout] | ___________________----_________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | | let file = tokio::task::spawn_blocking(move || { [INFO] [stdout] 68 | | fs::OpenOptions::new() [INFO] [stdout] 69 | | .read(true) [INFO] [stdout] ... | [INFO] [stdout] 93 | | Ok(Box::new(FileStateGuard(client))) [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 66 | async fn lock(self: Box, force: bool) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let file = tokio::task::spawn_blocking(move || { [INFO] [stdout] 68 | / fs::OpenOptions::new() [INFO] [stdout] 69 | | .read(true) [INFO] [stdout] 70 | | .create(true) [INFO] [stdout] 71 | | .write(true) [INFO] [stdout] 72 | | .open(self.state_file) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 67 | let file = tokio::task::spawn_blocking(move || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | / file.file() [INFO] [stdout] 83 | | .lock(FileLockMode::Exclusive) [INFO] [stdout] 84 | | .map_err(|source| FileStateError::Lock { source }) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:26 [INFO] [stdout] | [INFO] [stdout] 67 | let file = tokio::task::spawn_blocking(move || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | .map(|()| file) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:56 [INFO] [stdout] | [INFO] [stdout] 105 | async fn unlock(mut self: Box) -> Result<()> { [INFO] [stdout] | _________________________----___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | | tokio::task::spawn_blocking(move || (*self).0.file.file().unlock()) [INFO] [stdout] 107 | | .await [INFO] [stdout] 108 | | .expect("The task of unlocking the file has panicked")?; [INFO] [stdout] 109 | | [INFO] [stdout] 110 | | Ok(()) [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `migrate-state-file` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "70102a501ef40f3b6e91ae36e4461f91037fae7e2bb0e5953b232b46eb1d4e60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70102a501ef40f3b6e91ae36e4461f91037fae7e2bb0e5953b232b46eb1d4e60", kill_on_drop: false }` [INFO] [stdout] 70102a501ef40f3b6e91ae36e4461f91037fae7e2bb0e5953b232b46eb1d4e60