[INFO] fetching crate migrate-state-dynamodb 0.1.0... [INFO] checking migrate-state-dynamodb-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate migrate-state-dynamodb 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate migrate-state-dynamodb 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate migrate-state-dynamodb 0.1.0 [INFO] finished tweaking crates.io crate migrate-state-dynamodb 0.1.0 [INFO] tweaked toml for crates.io crate migrate-state-dynamodb 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 170 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding ct-logs v0.8.0 (latest: v0.9.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.22.1 (latest: v0.27.2) [INFO] [stderr] Adding hyper-tls v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding md-5 v0.9.1 (latest: v0.10.6) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rusoto_core v0.47.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_credential v0.47.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_dynamodb v0.47.0 (latest: v0.48.0) [INFO] [stderr] Adding rusoto_signature v0.47.0 (latest: v0.48.0) [INFO] [stderr] Adding rustls v0.19.1 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.5.0 (latest: v0.8.0) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding tokio-rustls v0.22.0 (latest: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_dynamodb` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38a50252a841d2d684b163f15a1e13567bb7f071b73b5abae2a6049f5ae8ccb5 [INFO] running `Command { std: "docker" "start" "-a" "38a50252a841d2d684b163f15a1e13567bb7f071b73b5abae2a6049f5ae8ccb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38a50252a841d2d684b163f15a1e13567bb7f071b73b5abae2a6049f5ae8ccb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38a50252a841d2d684b163f15a1e13567bb7f071b73b5abae2a6049f5ae8ccb5", kill_on_drop: false }` [INFO] [stdout] 38a50252a841d2d684b163f15a1e13567bb7f071b73b5abae2a6049f5ae8ccb5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94e8b45971d38cb6da57432b504b0292a80f66b999ffd9e4f69868bd4098c16d [INFO] running `Command { std: "docker" "start" "-a" "94e8b45971d38cb6da57432b504b0292a80f66b999ffd9e4f69868bd4098c16d", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_dynamodb` dependency) [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking migrate-state v0.1.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Compiling rusoto_core v0.47.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking migrate-core v0.1.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking migrate-state-test v0.1.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking rusoto_credential v0.47.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking rusoto_signature v0.47.0 [INFO] [stderr] Checking rusoto_dynamodb v0.47.0 [INFO] [stderr] Checking migrate-state-dynamodb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 149 | table_name: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ddb: impl DynamoDb + Send + Sync + 'static, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | ) -> DdbStateLockBuilder { [INFO] [stdout] 152 | DdbStateLockBuilder(DdbStateCtx { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 153 | | partition_key_attr: AttrNameVal::new("partition_key", default_key_attr_value()), [INFO] [stdout] 154 | | sort_key_attr: None, [INFO] [stdout] 155 | | payload_attr_name: "payload".to_owned(), [INFO] [stdout] 156 | | table_name: table_name.into(), [INFO] [stdout] 157 | | ddb: Box::new(ddb), [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:81 [INFO] [stdout] | [INFO] [stdout] 193 | async fn lock(self: Box, _force: bool) -> Result> { [INFO] [stdout] | ___________________----__________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | | // FIXME: acquire the distributed lock here [INFO] [stdout] 195 | | [INFO] [stdout] 196 | | Ok(Box::new(DdbStateGuard(DdbStateClient(self.0)))) [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:208:56 [INFO] [stdout] | [INFO] [stdout] 208 | async fn unlock(mut self: Box) -> Result<()> { [INFO] [stdout] | _________________________----___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | | // FIXME: release the distributed lock here [INFO] [stdout] 210 | | // but be cautios not to corrupt the lock if some other [INFO] [stdout] 211 | | // subject has acquired it with `force_lock()`. [INFO] [stdout] ... | [INFO] [stdout] 214 | | Ok(()) [INFO] [stdout] 215 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 306 | let partition_key = ( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let sort_key = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | iter::once(partition_key).chain(sort_key).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `migrate-state-dynamodb` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 149 | table_name: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ddb: impl DynamoDb + Send + Sync + 'static, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | ) -> DdbStateLockBuilder { [INFO] [stdout] 152 | DdbStateLockBuilder(DdbStateCtx { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 153 | | partition_key_attr: AttrNameVal::new("partition_key", default_key_attr_value()), [INFO] [stdout] 154 | | sort_key_attr: None, [INFO] [stdout] 155 | | payload_attr_name: "payload".to_owned(), [INFO] [stdout] 156 | | table_name: table_name.into(), [INFO] [stdout] 157 | | ddb: Box::new(ddb), [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:81 [INFO] [stdout] | [INFO] [stdout] 193 | async fn lock(self: Box, _force: bool) -> Result> { [INFO] [stdout] | ___________________----__________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | | // FIXME: acquire the distributed lock here [INFO] [stdout] 195 | | [INFO] [stdout] 196 | | Ok(Box::new(DdbStateGuard(DdbStateClient(self.0)))) [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:208:56 [INFO] [stdout] | [INFO] [stdout] 208 | async fn unlock(mut self: Box) -> Result<()> { [INFO] [stdout] | _________________________----___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | | // FIXME: release the distributed lock here [INFO] [stdout] 210 | | // but be cautios not to corrupt the lock if some other [INFO] [stdout] 211 | | // subject has acquired it with `force_lock()`. [INFO] [stdout] ... | [INFO] [stdout] 214 | | Ok(()) [INFO] [stdout] 215 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 306 | let partition_key = ( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let sort_key = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | iter::once(partition_key).chain(sort_key).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `migrate-state-dynamodb` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "94e8b45971d38cb6da57432b504b0292a80f66b999ffd9e4f69868bd4098c16d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94e8b45971d38cb6da57432b504b0292a80f66b999ffd9e4f69868bd4098c16d", kill_on_drop: false }` [INFO] [stdout] 94e8b45971d38cb6da57432b504b0292a80f66b999ffd9e4f69868bd4098c16d