[INFO] fetching crate midi_file 0.0.5... [INFO] checking midi_file-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate midi_file 0.0.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate midi_file 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate midi_file 0.0.5 [INFO] finished tweaking crates.io crate midi_file 0.0.5 [INFO] tweaked toml for crates.io crate midi_file 0.0.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate midi_file 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12a851de11511e5a894797466ed32a3af0013e25affec5500838fee413a49208 [INFO] running `Command { std: "docker" "start" "-a" "12a851de11511e5a894797466ed32a3af0013e25affec5500838fee413a49208", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12a851de11511e5a894797466ed32a3af0013e25affec5500838fee413a49208", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12a851de11511e5a894797466ed32a3af0013e25affec5500838fee413a49208", kill_on_drop: false }` [INFO] [stdout] 12a851de11511e5a894797466ed32a3af0013e25affec5500838fee413a49208 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8268168289efe0308e5e4d9c5d30e50c249c2d5ed75f4cac1968e2e6982ea63 [INFO] running `Command { std: "docker" "start" "-a" "d8268168289efe0308e5e4d9c5d30e50c249c2d5ed75f4cac1968e2e6982ea63", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling rustix v0.38.17 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking midi_file v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_iter.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn new_file>(path: P) -> ByteResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let path = path.as_ref(); [INFO] [stdout] 91 | let f = File::open(path).context(FileOpenSnafu { path })?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let buf = BufReader::with_capacity(MB, f); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Self::new(buf.bytes()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_iter.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub(crate) fn new(mut iter: Bytes) -> ByteResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | iter, [INFO] [stdout] 104 | | position: None, [INFO] [stdout] 105 | | current: None, [INFO] [stdout] ... | [INFO] [stdout] 111 | | running_status_detected: false, [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_iter.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 144 | let next_opt = self.iter.next(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let next_result = match next_opt { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Some(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let e = match next_result { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Err(e).context(IoSnafu { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_iter.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn new_file>(path: P) -> ByteResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let path = path.as_ref(); [INFO] [stdout] 91 | let f = File::open(path).context(FileOpenSnafu { path })?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let buf = BufReader::with_capacity(MB, f); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Self::new(buf.bytes()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_iter.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub(crate) fn new(mut iter: Bytes) -> ByteResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | iter, [INFO] [stdout] 104 | | position: None, [INFO] [stdout] 105 | | current: None, [INFO] [stdout] ... | [INFO] [stdout] 111 | | running_status_detected: false, [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_iter.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 144 | let next_opt = self.iter.next(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let next_result = match next_opt { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Some(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let e = match next_result { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Err(e).context(IoSnafu { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `midi_file` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `midi_file` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "d8268168289efe0308e5e4d9c5d30e50c249c2d5ed75f4cac1968e2e6982ea63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8268168289efe0308e5e4d9c5d30e50c249c2d5ed75f4cac1968e2e6982ea63", kill_on_drop: false }` [INFO] [stdout] d8268168289efe0308e5e4d9c5d30e50c249c2d5ed75f4cac1968e2e6982ea63