[INFO] fetching crate microbit-bsp 0.3.0... [INFO] checking microbit-bsp-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate microbit-bsp 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate microbit-bsp 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate microbit-bsp 0.3.0 [INFO] finished tweaking crates.io crate microbit-bsp 0.3.0 [INFO] tweaked toml for crates.io crate microbit-bsp 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding bare-metal v0.2.5 (latest: v1.0.0) [INFO] [stderr] Adding bitfield v0.13.2 (latest: v0.16.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding embassy-embedded-hal v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding embassy-hal-internal v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding embassy-nrf v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding embassy-sync v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding lsm303agr v0.3.0 (latest: v1.1.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b890aa7eaef316d23fc10dd2685fe5910c7e33a7bce18cc2df46e4e4f0899415 [INFO] running `Command { std: "docker" "start" "-a" "b890aa7eaef316d23fc10dd2685fe5910c7e33a7bce18cc2df46e4e4f0899415", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b890aa7eaef316d23fc10dd2685fe5910c7e33a7bce18cc2df46e4e4f0899415", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b890aa7eaef316d23fc10dd2685fe5910c7e33a7bce18cc2df46e4e4f0899415", kill_on_drop: false }` [INFO] [stdout] b890aa7eaef316d23fc10dd2685fe5910c7e33a7bce18cc2df46e4e4f0899415 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22c395384a7060f068cc4d6191726503c5f8d4c0e2653f6a89d43cf81135e867 [INFO] running `Command { std: "docker" "start" "-a" "22c395384a7060f068cc4d6191726503c5f8d4c0e2653f6a89d43cf81135e867", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling defmt v0.3.8 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling defmt-macros v0.3.9 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling cortex-m v0.7.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Compiling embassy-time-queue-driver v0.1.0 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking vcell v0.1.3 [INFO] [stderr] Compiling embassy-time-driver v0.1.0 [INFO] [stderr] Compiling embedded-io-async v0.6.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling embedded-hal-async v1.0.0 [INFO] [stderr] Compiling cortex-m-rt v0.7.3 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking volatile-register v0.2.2 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking embedded-hal v1.0.0 [INFO] [stderr] Checking bitfield v0.13.2 [INFO] [stderr] Compiling embassy-sync v0.5.0 [INFO] [stderr] Checking embedded-io v0.6.1 [INFO] [stderr] Compiling cortex-m-rt-macros v0.7.0 [INFO] [stderr] Compiling embassy-hal-internal v0.1.0 [INFO] [stderr] Checking embedded-storage v0.3.1 [INFO] [stderr] Compiling nrf52833-pac v0.12.2 [INFO] [stderr] Compiling bare-metal v0.2.5 [INFO] [stderr] Compiling fixed v1.28.0 [INFO] [stderr] Checking embedded-storage-async v0.4.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking embassy-futures v0.1.1 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking lsm303agr v0.3.0 [INFO] [stderr] Checking embassy-time v0.3.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling defmt-parser v0.3.4 [INFO] [stderr] Checking embassy-usb-driver v0.1.0 [INFO] [stderr] Checking embassy-embedded-hal v0.1.0 [INFO] [stderr] Checking embassy-nrf v0.1.0 [INFO] [stderr] Checking microbit-bsp v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `defmt` [INFO] [stdout] --> src/display/mod.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 292 | #[cfg_attr(feature = "defmt", derive(defmt::Format))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `defmt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `defmt` [INFO] [stdout] --> src/display/types.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | #[cfg(feature = "defmt")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `defmt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `defmt` [INFO] [stdout] --> src/display/types.rs:146:7 [INFO] [stdout] | [INFO] [stdout] 146 | #[cfg(feature = "defmt")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `defmt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `defmt` [INFO] [stdout] --> src/display/mod.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 292 | #[cfg_attr(feature = "defmt", derive(defmt::Format))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `defmt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `defmt` [INFO] [stdout] --> src/display/types.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | #[cfg(feature = "defmt")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `defmt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `defmt` [INFO] [stdout] --> src/display/types.rs:146:7 [INFO] [stdout] | [INFO] [stdout] 146 | #[cfg(feature = "defmt")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `defmt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 93 | let rows = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let cols = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | display: LedMatrixDriver::new(rows, cols), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 93 | let rows = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let cols = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | btn_a: Input::new(p.P0_14.degrade(), Pull::Up), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 93 | let rows = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let cols = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | btn_b: Input::new(p.P0_23.degrade(), Pull::Up), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/accelerometer/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 27 | irq: impl Binding> + 'd, [INFO] [stdout] | ------------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let twi = twim::Twim::new(twispi0, irq, sda, scl, config); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | let mut sensor = Lsm303agr::new_with_i2c(twi); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { sensor }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `microbit-bsp` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 93 | let rows = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let cols = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | display: LedMatrixDriver::new(rows, cols), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 93 | let rows = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let cols = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | btn_a: Input::new(p.P0_14.degrade(), Pull::Up), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 93 | let rows = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let cols = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | btn_b: Input::new(p.P0_23.degrade(), Pull::Up), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/accelerometer/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 27 | irq: impl Binding> + 'd, [INFO] [stdout] | ------------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let twi = twim::Twim::new(twispi0, irq, sda, scl, config); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | let mut sensor = Lsm303agr::new_with_i2c(twi); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { sensor }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `microbit-bsp` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "22c395384a7060f068cc4d6191726503c5f8d4c0e2653f6a89d43cf81135e867", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22c395384a7060f068cc4d6191726503c5f8d4c0e2653f6a89d43cf81135e867", kill_on_drop: false }` [INFO] [stdout] 22c395384a7060f068cc4d6191726503c5f8d4c0e2653f6a89d43cf81135e867