[INFO] fetching crate miau 0.1.1... [INFO] checking miau-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate miau 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate miau 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate miau 0.1.1 [INFO] finished tweaking crates.io crate miau 0.1.1 [INFO] tweaked toml for crates.io crate miau 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate miau 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10bcaa92a6f2fd578700d0ba9e0121e6bd703dc6561f410b8f4cf3d160b2dfed [INFO] running `Command { std: "docker" "start" "-a" "10bcaa92a6f2fd578700d0ba9e0121e6bd703dc6561f410b8f4cf3d160b2dfed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10bcaa92a6f2fd578700d0ba9e0121e6bd703dc6561f410b8f4cf3d160b2dfed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10bcaa92a6f2fd578700d0ba9e0121e6bd703dc6561f410b8f4cf3d160b2dfed", kill_on_drop: false }` [INFO] [stdout] 10bcaa92a6f2fd578700d0ba9e0121e6bd703dc6561f410b8f4cf3d160b2dfed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 447e0f80cbb16650b63d9428c4b934baa345ff390a03897062b662ec38006106 [INFO] running `Command { std: "docker" "start" "-a" "447e0f80cbb16650b63d9428c4b934baa345ff390a03897062b662ec38006106", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Compiling tokio v0.3.7 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling serde_json v1.0.62 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Checking dtoa v0.4.7 [INFO] [stderr] Checking bytes v0.6.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rstest v0.6.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rmp v0.8.10 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling tokio-macros v0.3.2 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking serde v1.0.123 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking serde_yaml v0.8.17 [INFO] [stderr] Checking rmp-serde v0.15.4 [INFO] [stderr] Checking miau v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `experimental_serde_ron` [INFO] [stdout] --> src/format/mod.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(feature = "experimental_serde_ron")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `all`, `ini`, `json`, `json5`, `msgpack`, `rmp-serde`, `serde_ini`, `serde_json`, `serde_json5`, `serde_toml`, `serde_yaml`, `toml`, and `yaml` [INFO] [stdout] = help: consider adding `experimental_serde_ron` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:86:33 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn add_async(self, source: S, format: D) -> AsyncConfigurationBuilder<'provider> [INFO] [stdout] | ---- --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | self.add_provider_async(ProviderStruct::asynchronous(source, format)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:186:22 [INFO] [stdout] | [INFO] [stdout] 183 | mut builder: ConfigurationBuilder<'provider>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | sources: builder [INFO] [stdout] | ______________________^ [INFO] [stdout] 187 | | .sources [INFO] [stdout] 188 | | .drain(..) [INFO] [stdout] 189 | | .map(|s| SourceType::Synchronous(s)) [INFO] [stdout] 190 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn add(&mut self, source: S, format: D) -> &mut AsyncConfigurationBuilder<'provider> [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | self.add_provider(ProviderStruct::synchronous(source, format)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:230:33 [INFO] [stdout] | [INFO] [stdout] 223 | source: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | format: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | self.add_provider_async(ProviderStruct::asynchronous(source, format)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/common.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 8 | nodes: impl DoubleEndedIterator, [INFO] [stdout] | ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/common.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 24 | nodes: impl Iterator, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | ) -> Result { [INFO] [stdout] 26 | merge_owned(nodes.cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/lens.rs:71:42 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|def| def.mutate(|node| node.descend_many(&keys).ok())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/read.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | fn get(&'config self, keys: K) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | self.get_result(keys).ok().unwrap_or_default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/tree.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 58 | .and_then(|node| node.get_value::().map_err(|e| e.enrich_with_keys(keys))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/value.rs:58:42 [INFO] [stdout] | [INFO] [stdout] 58 | .map_err(|_| ErrorCode::WrongValueType(stringify!($t).into(), "string".into()).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | try_from_for_int!(i8, i16, i32, i64, isize); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_from_for_int` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/value.rs:61:42 [INFO] [stdout] | [INFO] [stdout] 61 | .map_err(|_| ErrorCode::WrongValueType(stringify!($t).into(), "i64".into()).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | try_from_for_int!(i8, i16, i32, i64, isize); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_from_for_int` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration/value.rs:86:42 [INFO] [stdout] | [INFO] [stdout] 86 | .map_err(|_| ErrorCode::WrongValueType(stringify!($t).into(), "string".into()).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | try_from_for_float!(f32, f64); [INFO] [stdout] | ----------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_from_for_float` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:278:34 [INFO] [stdout] | [INFO] [stdout] 277 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | ConfigurationError::from(ErrorCode::IoError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 283 | fn from(e: ErrorCode) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | ConfigurationError { [INFO] [stdout] 285 | inner: Box::new(ErrorImpl { [INFO] [stdout] | ____________________^ [INFO] [stdout] 286 | | code: e, [INFO] [stdout] 287 | | context: None, [INFO] [stdout] 288 | | path: None, [INFO] [stdout] 289 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:299:34 [INFO] [stdout] | [INFO] [stdout] 295 | fn custom(msg: T) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | ConfigurationError::from(ErrorCode::DeserializationError(msg.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `miau` (lib) due to 16 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "447e0f80cbb16650b63d9428c4b934baa345ff390a03897062b662ec38006106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "447e0f80cbb16650b63d9428c4b934baa345ff390a03897062b662ec38006106", kill_on_drop: false }` [INFO] [stdout] 447e0f80cbb16650b63d9428c4b934baa345ff390a03897062b662ec38006106