[INFO] fetching crate mfio-netfs 0.1.0... [INFO] checking mfio-netfs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mfio-netfs 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mfio-netfs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mfio-netfs 0.1.0 [INFO] finished tweaking crates.io crate mfio-netfs 0.1.0 [INFO] tweaked toml for crates.io crate mfio-netfs 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate mfio-netfs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb4a3bc68a95c563aeb12eff9aad32852583fe3630d774c19be59e7c562898e0 [INFO] running `Command { std: "docker" "start" "-a" "fb4a3bc68a95c563aeb12eff9aad32852583fe3630d774c19be59e7c562898e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb4a3bc68a95c563aeb12eff9aad32852583fe3630d774c19be59e7c562898e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb4a3bc68a95c563aeb12eff9aad32852583fe3630d774c19be59e7c562898e0", kill_on_drop: false }` [INFO] [stdout] fb4a3bc68a95c563aeb12eff9aad32852583fe3630d774c19be59e7c562898e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c1e81e59dc910a46d444b04e3eccf830b3cb9f673d3290fab5f9639e1131b34 [INFO] running `Command { std: "docker" "start" "-a" "8c1e81e59dc910a46d444b04e3eccf830b3cb9f673d3290fab5f9639e1131b34", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling winnow v0.5.25 [INFO] [stderr] Checking futures-lite v2.1.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking event-listener v4.0.0 [INFO] [stderr] Checking async-task v4.5.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling cglue v0.2.14 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking async-lock v3.2.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking async-channel v2.1.1 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking tarc v0.1.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking rangemap v1.4.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking async-semaphore v1.2.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking typed-path v0.7.0 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking embedded-io v0.4.0 [INFO] [stderr] Checking oneshot v0.1.6 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking async-mutex v1.4.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking debug-ignore v1.0.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling toml_edit v0.20.7 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling proc-macro-crate v2.0.0 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling cglue-gen v0.2.9 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking tokio v1.34.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling mfio-derive v0.1.0 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking polling v3.3.1 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking async-net v1.8.0 [INFO] [stderr] Checking async-io v2.2.1 [INFO] [stderr] Checking async-signal v0.2.5 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking smol v1.3.0 [INFO] [stderr] Compiling cglue-macro v0.2.3 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking mfio v0.1.0 [INFO] [stderr] Checking mfio-rt v0.1.0 [INFO] [stderr] Checking postcard v1.0.8 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking mfio-netfs v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:269:22 [INFO] [stdout] | [INFO] [stdout] 269 | obj: RoutedData::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | header: FullPacket::new(header).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:298:27 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn send_pkt(&self, header: impl FnOnce(usize) -> T, pkt: BoundPacketView) -> usize { [INFO] [stdout] | ------------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | self.send(header, RoutedData::Pkt(pkt.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/client.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn from(pkt: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Self { [INFO] [stdout] 79 | shards: std::iter::once((0, pkt)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/client.rs:606:12 [INFO] [stdout] | [INFO] [stdout] 222 | fs: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let stream = TcpStream::connect(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | [INFO] [stdout] 227 | let stream = fs.register_stream(stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | [INFO] [stdout] 229 | let state = BaseArc::new(Mutex::new(NetFsState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let (ops, ops_rx) = flume::unbounded(); [INFO] [stdout] | --- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let (fs_reqs, fs_reqs_rx) = flume::bounded(16); [INFO] [stdout] | ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let (close_reqs, close_reqs_rx) = flume::unbounded(); [INFO] [stdout] | ---------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let (read_dir_reqs, read_dir_reqs_rx) = flume::unbounded(); [INFO] [stdout] | ------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | [INFO] [stdout] 240 | let senders = Senders { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let backend = { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let state = state.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 606 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 607 | | fs, [INFO] [stdout] 608 | | cwd: NetworkFsDir { [INFO] [stdout] 609 | | dir_id: 0, [INFO] [stdout] ... | [INFO] [stdout] 614 | | cancel_ops_on_drop, [INFO] [stdout] 615 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/client.rs:989:30 [INFO] [stdout] | [INFO] [stdout] 989 | senders: dir.senders.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/client.rs:990:28 [INFO] [stdout] | [INFO] [stdout] 990 | state: dir.state.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/server.rs:590:37 [INFO] [stdout] | [INFO] [stdout] 587 | let mut listener = fs.bind(addr).await.unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | let _ = tx.send_async(listener.local_addr().unwrap()).await; [INFO] [stdout] 589 | let (stream, _) = listener.next().await.unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | run_server(stream, &fs).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mfio-netfs` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8c1e81e59dc910a46d444b04e3eccf830b3cb9f673d3290fab5f9639e1131b34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c1e81e59dc910a46d444b04e3eccf830b3cb9f673d3290fab5f9639e1131b34", kill_on_drop: false }` [INFO] [stdout] 8c1e81e59dc910a46d444b04e3eccf830b3cb9f673d3290fab5f9639e1131b34