[INFO] fetching crate mfform-lib 0.4.0... [INFO] checking mfform-lib-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mfform-lib 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mfform-lib 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mfform-lib 0.4.0 [INFO] finished tweaking crates.io crate mfform-lib 0.4.0 [INFO] tweaked toml for crates.io crate mfform-lib 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding crossterm v0.27.0 (latest: v0.28.1) [INFO] [stderr] Adding destructure_traitobject v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b6a8c459feae25c8c813b2b0c118af34573759f8ced80fe623cc55c0db69f1d [INFO] running `Command { std: "docker" "start" "-a" "6b6a8c459feae25c8c813b2b0c118af34573759f8ced80fe623cc55c0db69f1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b6a8c459feae25c8c813b2b0c118af34573759f8ced80fe623cc55c0db69f1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b6a8c459feae25c8c813b2b0c118af34573759f8ced80fe623cc55c0db69f1d", kill_on_drop: false }` [INFO] [stdout] 6b6a8c459feae25c8c813b2b0c118af34573759f8ced80fe623cc55c0db69f1d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c8338bba57d21839f9d0bec355d6c6d4b8890ee68d413dda9905b4237749a1d [INFO] running `Command { std: "docker" "start" "-a" "5c8338bba57d21839f9d0bec355d6c6d4b8890ee68d413dda9905b4237749a1d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking log4rs_test_utils v0.2.3 [INFO] [stderr] Checking mfform-lib v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 72 | let original_hook = std::panic::take_hook(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | std::panic::set_hook(Box::new(move |panic_info| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 74 | | let _ = Self::restore_terminal(); [INFO] [stdout] 75 | | original_hook(panic_info); [INFO] [stdout] 76 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 141 | fn configure_logging(logging_enabled: Arc>) -> Handle { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let log_buffer = crate::vec_appender::Appender::with_capacity(100); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let log_dialog = crate::dialog_appender::Appender::new((0, 26), 5, logging_enabled); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | [INFO] [stdout] 150 | let debug_log = FileAppender::builder() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let config = Config::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | log4rs::init_config(config).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 170 | fn is_logging_enabled(logging_enabled: Arc>) -> bool { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | logging_enabled.read().map(|e| *e).unwrap_or(false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dialog_appender.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(start: impl Into, size: usize, logging_enabled: Arc>) -> Self { [INFO] [stdout] | --------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | buffer: Arc::new(Mutex::new(VecDeque::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mfform-lib` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 72 | let original_hook = std::panic::take_hook(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | std::panic::set_hook(Box::new(move |panic_info| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 74 | | let _ = Self::restore_terminal(); [INFO] [stdout] 75 | | original_hook(panic_info); [INFO] [stdout] 76 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 141 | fn configure_logging(logging_enabled: Arc>) -> Handle { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let log_buffer = crate::vec_appender::Appender::with_capacity(100); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let log_dialog = crate::dialog_appender::Appender::new((0, 26), 5, logging_enabled); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | [INFO] [stdout] 150 | let debug_log = FileAppender::builder() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let config = Config::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | log4rs::init_config(config).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 170 | fn is_logging_enabled(logging_enabled: Arc>) -> bool { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | logging_enabled.read().map(|e| *e).unwrap_or(false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dialog_appender.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(start: impl Into, size: usize, logging_enabled: Arc>) -> Self { [INFO] [stdout] | --------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | buffer: Arc::new(Mutex::new(VecDeque::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mfform-lib` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5c8338bba57d21839f9d0bec355d6c6d4b8890ee68d413dda9905b4237749a1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c8338bba57d21839f9d0bec355d6c6d4b8890ee68d413dda9905b4237749a1d", kill_on_drop: false }` [INFO] [stdout] 5c8338bba57d21839f9d0bec355d6c6d4b8890ee68d413dda9905b4237749a1d