[INFO] fetching crate metriken-exposition 0.9.1... [INFO] checking metriken-exposition-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate metriken-exposition 0.9.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate metriken-exposition 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metriken-exposition 0.9.1 [INFO] finished tweaking crates.io crate metriken-exposition 0.9.1 [INFO] tweaked toml for crates.io crate metriken-exposition 0.9.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 156 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding integer-encoding v3.0.4 (latest: v4.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zstd-sys v2.0.12+zstd.1.5.6 (latest: v2.0.13+zstd.1.5.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58816b807f3886157789533b1d96de06dfad602f37e06a2a9d67d93d87aa0a50 [INFO] running `Command { std: "docker" "start" "-a" "58816b807f3886157789533b1d96de06dfad602f37e06a2a9d67d93d87aa0a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58816b807f3886157789533b1d96de06dfad602f37e06a2a9d67d93d87aa0a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58816b807f3886157789533b1d96de06dfad602f37e06a2a9d67d93d87aa0a50", kill_on_drop: false }` [INFO] [stdout] 58816b807f3886157789533b1d96de06dfad602f37e06a2a9d67d93d87aa0a50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25552cd80b287a6f8d862ac89aa517d8948165dfcf8f4f4db08f5eab8f05ad52 [INFO] running `Command { std: "docker" "start" "-a" "25552cd80b287a6f8d862ac89aa517d8948165dfcf8f4f4db08f5eab8f05ad52", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling metriken-core v0.1.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling linkme-impl v0.3.28 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling metriken-derive v0.5.1 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking linkme v0.3.28 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking histogram v0.11.0 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking metriken v0.7.0 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking parquet v52.2.0 [INFO] [stderr] Checking metriken-exposition v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:48:34 [INFO] [stdout] | [INFO] [stdout] 45 | input: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | output: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> Result { [INFO] [stdout] 48 | self.convert_file_handle(File::open(input)?, File::create(output)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:48:54 [INFO] [stdout] | [INFO] [stdout] 45 | input: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | output: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> Result { [INFO] [stdout] 48 | self.convert_file_handle(File::open(input)?, File::create(output)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:66:53 [INFO] [stdout] | [INFO] [stdout] 66 | .map_err(|x| ParquetError::External(Box::new(x)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:75:53 [INFO] [stdout] | [INFO] [stdout] 75 | .map_err(|x| ParquetError::External(Box::new(x)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parquet.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 193 | writer: impl Write + Send, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let mut fields: Vec = Vec::with_capacity( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let schema = Arc::new(Schema::new(fields)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | let arrow_writer = ArrowWriter::try_new(writer, schema.clone(), Some(props))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | [INFO] [stdout] 313 | Ok(ParquetWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 314 | | writer: arrow_writer, [INFO] [stdout] 315 | | options, [INFO] [stdout] 316 | | schema, [INFO] [stdout] ... | [INFO] [stdout] 319 | | histograms, [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metriken-exposition` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:48:34 [INFO] [stdout] | [INFO] [stdout] 45 | input: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | output: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> Result { [INFO] [stdout] 48 | self.convert_file_handle(File::open(input)?, File::create(output)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:48:54 [INFO] [stdout] | [INFO] [stdout] 45 | input: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | output: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> Result { [INFO] [stdout] 48 | self.convert_file_handle(File::open(input)?, File::create(output)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:66:53 [INFO] [stdout] | [INFO] [stdout] 66 | .map_err(|x| ParquetError::External(Box::new(x)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:75:53 [INFO] [stdout] | [INFO] [stdout] 75 | .map_err(|x| ParquetError::External(Box::new(x)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parquet.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 193 | writer: impl Write + Send, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let mut fields: Vec = Vec::with_capacity( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let schema = Arc::new(Schema::new(fields)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | let arrow_writer = ArrowWriter::try_new(writer, schema.clone(), Some(props))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | [INFO] [stdout] 313 | Ok(ParquetWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 314 | | writer: arrow_writer, [INFO] [stdout] 315 | | options, [INFO] [stdout] 316 | | schema, [INFO] [stdout] ... | [INFO] [stdout] 319 | | histograms, [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metriken-exposition` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "25552cd80b287a6f8d862ac89aa517d8948165dfcf8f4f4db08f5eab8f05ad52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25552cd80b287a6f8d862ac89aa517d8948165dfcf8f4f4db08f5eab8f05ad52", kill_on_drop: false }` [INFO] [stdout] 25552cd80b287a6f8d862ac89aa517d8948165dfcf8f4f4db08f5eab8f05ad52