[INFO] fetching crate metrics_cloudwatch_embedded 0.5.0... [INFO] checking metrics_cloudwatch_embedded-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate metrics_cloudwatch_embedded 0.5.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate metrics_cloudwatch_embedded 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metrics_cloudwatch_embedded 0.5.0 [INFO] finished tweaking crates.io crate metrics_cloudwatch_embedded 0.5.0 [INFO] tweaked toml for crates.io crate metrics_cloudwatch_embedded 0.5.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 153 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lambda_http v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding lambda_runtime v0.11.3 (latest: v0.13.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding metrics v0.22.3 (latest: v0.23.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d58536e21eaf2b648682c12813016dfaeddbc8afa5e89218a9863e0f6447cfd2 [INFO] running `Command { std: "docker" "start" "-a" "d58536e21eaf2b648682c12813016dfaeddbc8afa5e89218a9863e0f6447cfd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d58536e21eaf2b648682c12813016dfaeddbc8afa5e89218a9863e0f6447cfd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d58536e21eaf2b648682c12813016dfaeddbc8afa5e89218a9863e0f6447cfd2", kill_on_drop: false }` [INFO] [stdout] d58536e21eaf2b648682c12813016dfaeddbc8afa5e89218a9863e0f6447cfd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f9363f84a001ddeb808833b1dd88ecd6a659851ae15d030112d215e370ff5c0 [INFO] running `Command { std: "docker" "start" "-a" "0f9363f84a001ddeb808833b1dd88ecd6a659851ae15d030112d215e370ff5c0", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking metrics v0.22.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking query_map v0.7.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-serde v2.1.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking aws_lambda_events v0.15.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking lambda_runtime_api_client v0.11.1 [INFO] [stderr] Checking lambda_runtime v0.11.3 [INFO] [stderr] Checking lambda_http v0.11.4 [INFO] [stderr] Checking metrics_cloudwatch_embedded v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn cloudwatch_namespace(self, namespace: impl Into) -> Self { [INFO] [stdout] | ---- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self { [INFO] [stdout] 50 | cloudwatch_namespace: Some(namespace.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 124 | fn build(self) -> Result<(collector::Config, Option), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 126 | | collector::Config { [INFO] [stdout] 127 | | cloudwatch_namespace: self.cloudwatch_namespace.ok_or("cloudwatch_namespace missing")?, [INFO] [stdout] 128 | | default_dimensions: self.default_dimensions, [INFO] [stdout] ... | [INFO] [stdout] 134 | | self.lambda_cold_start_span, [INFO] [stdout] 135 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 107 | config: Config, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | #[cfg(feature = "lambda")] lambda_cold_start_span: Option, [INFO] [stdout] | ------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | state: Mutex::new(CollectorState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 112 | | info_tree: BTreeMap::new(), [INFO] [stdout] 113 | | units: HashMap::new(), [INFO] [stdout] 114 | | properties: BTreeMap::new(), [INFO] [stdout] 115 | | #[cfg(feature = "lambda")] [INFO] [stdout] 116 | | lambda_cold_start_span, [INFO] [stdout] 117 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lambda.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 140 | fn call(&mut self, req: LambdaInvocation) -> Self::Future { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | inner: self.inner.call(req), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn cloudwatch_namespace(self, namespace: impl Into) -> Self { [INFO] [stdout] | ---- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self { [INFO] [stdout] 50 | cloudwatch_namespace: Some(namespace.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 124 | fn build(self) -> Result<(collector::Config, Option), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 126 | | collector::Config { [INFO] [stdout] 127 | | cloudwatch_namespace: self.cloudwatch_namespace.ok_or("cloudwatch_namespace missing")?, [INFO] [stdout] 128 | | default_dimensions: self.default_dimensions, [INFO] [stdout] ... | [INFO] [stdout] 134 | | self.lambda_cold_start_span, [INFO] [stdout] 135 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 107 | config: Config, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | #[cfg(feature = "lambda")] lambda_cold_start_span: Option, [INFO] [stdout] | ------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | state: Mutex::new(CollectorState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 112 | | info_tree: BTreeMap::new(), [INFO] [stdout] 113 | | units: HashMap::new(), [INFO] [stdout] 114 | | properties: BTreeMap::new(), [INFO] [stdout] 115 | | #[cfg(feature = "lambda")] [INFO] [stdout] 116 | | lambda_cold_start_span, [INFO] [stdout] 117 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics_cloudwatch_embedded` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lambda.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 140 | fn call(&mut self, req: LambdaInvocation) -> Self::Future { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | inner: self.inner.call(req), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics_cloudwatch_embedded` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "0f9363f84a001ddeb808833b1dd88ecd6a659851ae15d030112d215e370ff5c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f9363f84a001ddeb808833b1dd88ecd6a659851ae15d030112d215e370ff5c0", kill_on_drop: false }` [INFO] [stdout] 0f9363f84a001ddeb808833b1dd88ecd6a659851ae15d030112d215e370ff5c0