[INFO] fetching crate metrics-util 0.17.0... [INFO] checking metrics-util-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate metrics-util 0.17.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate metrics-util 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metrics-util 0.17.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate metrics-util 0.17.0 [INFO] tweaked toml for crates.io crate metrics-util 0.17.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate metrics-util 0.17.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72ce71fa9e1168f20867482f66353c13f48d6c0c29454aacf553837dfc0022d4 [INFO] running `Command { std: "docker" "start" "-a" "72ce71fa9e1168f20867482f66353c13f48d6c0c29454aacf553837dfc0022d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72ce71fa9e1168f20867482f66353c13f48d6c0c29454aacf553837dfc0022d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72ce71fa9e1168f20867482f66353c13f48d6c0c29454aacf553837dfc0022d4", kill_on_drop: false }` [INFO] [stdout] 72ce71fa9e1168f20867482f66353c13f48d6c0c29454aacf553837dfc0022d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60e3f2b75d358922c6f7aecd05df640b26319721a7269f947478539a0ea8060d [INFO] running `Command { std: "docker" "start" "-a" "60e3f2b75d358922c6f7aecd05df640b26319721a7269f947478539a0ea8060d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking predicates-core v1.0.5 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking predicates-tree v1.0.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking raw-cpuid v11.0.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking metrics v0.23.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking noisy_float v0.2.0 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Checking metrics-util v0.17.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 45 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ) -> HashMap, Option, DebugValue)> { [INFO] [stdout] 47 | / self.0 [INFO] [stdout] 48 | | .into_iter() [INFO] [stdout] 49 | | .map(|(k, unit, desc, value)| (k, (unit, desc, value))) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:49:47 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|(k, unit, desc, value)| (k, (unit, desc, value))) [INFO] [stdout] | ---------------------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:123:46 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|(u, d)| (u.to_owned(), Some(d.to_owned()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:124:43 [INFO] [stdout] | [INFO] [stdout] 124 | .unwrap_or_else(|| (None, None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:196:78 [INFO] [stdout] | [INFO] [stdout] 196 | self.inner.registry.get_or_create_counter(key, |c| Counter::from_arc(c.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:203:74 [INFO] [stdout] | [INFO] [stdout] 203 | self.inner.registry.get_or_create_gauge(key, |g| Gauge::from_arc(g.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debugging.rs:210:82 [INFO] [stdout] | [INFO] [stdout] 210 | self.inner.registry.get_or_create_histogram(key, |h| Histogram::from_arc(h.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:65:62 [INFO] [stdout] | [INFO] [stdout] 65 | repeat(()).take(shard_count).map(|_| RwLock::new(RegistryHashMap::default())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:67:62 [INFO] [stdout] | [INFO] [stdout] 67 | repeat(()).take(shard_count).map(|_| RwLock::new(RegistryHashMap::default())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:69:62 [INFO] [stdout] | [INFO] [stdout] 69 | repeat(()).take(shard_count).map(|_| RwLock::new(RegistryHashMap::default())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:84:62 [INFO] [stdout] | [INFO] [stdout] 84 | repeat(()).take(shard_count).map(|_| RwLock::new(RegistryHashMap::default())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:86:62 [INFO] [stdout] | [INFO] [stdout] 86 | repeat(()).take(shard_count).map(|_| RwLock::new(RegistryHashMap::default())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:88:62 [INFO] [stdout] | [INFO] [stdout] 88 | repeat(()).take(shard_count).map(|_| RwLock::new(RegistryHashMap::default())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:362:41 [INFO] [stdout] | [INFO] [stdout] 362 | .or_insert_with(|| (key.clone(), self.storage.counter(key))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:362:54 [INFO] [stdout] | [INFO] [stdout] 362 | .or_insert_with(|| (key.clone(), self.storage.counter(key))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:396:41 [INFO] [stdout] | [INFO] [stdout] 396 | .or_insert_with(|| (key.clone(), self.storage.gauge(key))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:396:54 [INFO] [stdout] | [INFO] [stdout] 396 | .or_insert_with(|| (key.clone(), self.storage.gauge(key))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:430:41 [INFO] [stdout] | [INFO] [stdout] 430 | .or_insert_with(|| (key.clone(), self.storage.histogram(key))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/mod.rs:430:54 [INFO] [stdout] | [INFO] [stdout] 430 | .or_insert_with(|| (key.clone(), self.storage.histogram(key))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/recency.rs:66:36 [INFO] [stdout] | [INFO] [stdout] 65 | fn new(inner: T) -> Generational { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Generational { inner, gen: Arc::new(AtomicUsize::new(0)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/recency.rs:134:27 [INFO] [stdout] | [INFO] [stdout] 133 | fn from(inner: Generational) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Counter::from_arc(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/recency.rs:143:25 [INFO] [stdout] | [INFO] [stdout] 142 | fn from(inner: Generational) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Gauge::from_arc(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/recency.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 151 | fn from(inner: Generational) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Histogram::from_arc(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry/recency.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new(clock: Clock, mask: MetricKindMask, idle_timeout: Option) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | Recency { mask, inner: Mutex::new((clock, HashMap::new())), idle_timeout } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recoverable.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn new(recorder: R) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self { handle: Arc::new(recorder) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recoverable.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 65 | pub(self) fn build(self) -> (WeakRecorder, RecoveryHandle) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let wrapped = WeakRecorder::from_arc(&self.handle); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | (wrapped, RecoveryHandle { handle: self.handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recoverable.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn install(self) -> Result, SetRecorderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let (wrapped, handle) = self.build(); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | match metrics::set_global_recorder(wrapped) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/mod.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn push>(self, layer: L) -> Stack { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Stack::new(layer.layer(self.inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/fanout.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(counter: FanoutCounter) -> Counter { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Counter::from_arc(Arc::new(counter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/fanout.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 69 | fn from(gauge: FanoutGauge) -> Gauge { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Gauge::from_arc(Arc::new(gauge)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/fanout.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 93 | fn from(histogram: FanoutHistogram) -> Histogram { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | Histogram::from_arc(Arc::new(histogram)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/fanout.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 123 | let counters = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | FanoutCounter::from_counters(counters).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/fanout.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 133 | let gauges = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | FanoutGauge::from_gauges(gauges).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/fanout.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 140 | let histograms = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | FanoutHistogram::from_histograms(histograms).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/filter.rs:91:23 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn from_patterns(patterns: P) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | patterns: patterns.into_iter().map(|s| s.as_ref().to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/prefix.rs:72:31 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn new>(prefix: S) -> PrefixLayer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | PrefixLayer(Box::leak(prefix.into().into_boxed_str())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/prefix.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 79 | fn layer(&self, inner: R) -> Self::Output { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Prefix { prefix: self.0.into(), inner } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/router.rs:99:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from_recorder(recorder: R) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | default: Box::new(recorder), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/router.rs:101:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from_recorder(recorder: R) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | targets: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/router.rs:102:29 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from_recorder(recorder: R) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | counter_routes: Trie::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/router.rs:103:27 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from_recorder(recorder: R) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | gauge_routes: Trie::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/router.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn from_recorder(recorder: R) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | histogram_routes: Trie::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 42 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics-util` (lib) due to 43 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "60e3f2b75d358922c6f7aecd05df640b26319721a7269f947478539a0ea8060d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60e3f2b75d358922c6f7aecd05df640b26319721a7269f947478539a0ea8060d", kill_on_drop: false }` [INFO] [stdout] 60e3f2b75d358922c6f7aecd05df640b26319721a7269f947478539a0ea8060d