[INFO] fetching crate metrics-tracing-context 0.16.0... [INFO] checking metrics-tracing-context-0.16.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate metrics-tracing-context 0.16.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate metrics-tracing-context 0.16.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metrics-tracing-context 0.16.0 [INFO] finished tweaking crates.io crate metrics-tracing-context 0.16.0 [INFO] tweaked toml for crates.io crate metrics-tracing-context 0.16.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 108 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.3 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding endian-type v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding plotters v0.2.15 (latest: v0.3.6) [INFO] [stderr] Adding sketches-ddsketch v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b35e852c96870d5615ad0e0efcb6dad1abeac26c29131f144450bbb646bce08 [INFO] running `Command { std: "docker" "start" "-a" "4b35e852c96870d5615ad0e0efcb6dad1abeac26c29131f144450bbb646bce08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b35e852c96870d5615ad0e0efcb6dad1abeac26c29131f144450bbb646bce08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b35e852c96870d5615ad0e0efcb6dad1abeac26c29131f144450bbb646bce08", kill_on_drop: false }` [INFO] [stdout] 4b35e852c96870d5615ad0e0efcb6dad1abeac26c29131f144450bbb646bce08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 937f34eb14710b1a4c848261c09e4d70074c3d2819a52415713d6eeee320188a [INFO] running `Command { std: "docker" "start" "-a" "937f34eb14710b1a4c848261c09e4d70074c3d2819a52415713d6eeee320188a", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking metrics v0.23.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking metrics-util v0.17.0 [INFO] [stderr] Checking metrics-tracing-context v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:30 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn only_allow(allowed: I) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Self { label_filter: label_filter::Allowlist::new(allowed) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:47 [INFO] [stdout] | [INFO] [stdout] 153 | fn layer(&self, inner: R) -> Self::Output { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | TracingContext { inner, label_filter: self.label_filter.clone() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:48 [INFO] [stdout] | [INFO] [stdout] 181 | let mut f = |mut span_labels: Map| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | (!span_labels.is_empty()).then(|| { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 183 | | let (name, labels) = key.clone().into_parts(); [INFO] [stdout] 184 | | [INFO] [stdout] 185 | | // Filter only span labels [INFO] [stdout] ... | [INFO] [stdout] 199 | | Key::from_parts(name, labels) [INFO] [stdout] 200 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_filter.rs:39:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(allowed: I) -> Allowlist [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Self { label_names: allowed.into_iter().map(|s| s.as_ref().to_string()).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing_integration.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | POOL.get_or_init(|| Arc::new(LinearObjectPool::new(Map::new, Map::clear))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing_integration.rs:116:42 [INFO] [stdout] | [INFO] [stdout] 116 | let mut ff = |labels: &Labels| f(labels.0.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics-tracing-context` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "937f34eb14710b1a4c848261c09e4d70074c3d2819a52415713d6eeee320188a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "937f34eb14710b1a4c848261c09e4d70074c3d2819a52415713d6eeee320188a", kill_on_drop: false }` [INFO] [stdout] 937f34eb14710b1a4c848261c09e4d70074c3d2819a52415713d6eeee320188a