[INFO] fetching crate metrics-observer 0.4.0... [INFO] checking metrics-observer-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate metrics-observer 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate metrics-observer 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metrics-observer 0.4.0 [INFO] finished tweaking crates.io crate metrics-observer 0.4.0 [INFO] tweaked toml for crates.io crate metrics-observer 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate metrics-observer 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 182f9cb9a949ce9820cee2a354cfbb85e339cbe358bee8f17a5b3c369300d265 [INFO] running `Command { std: "docker" "start" "-a" "182f9cb9a949ce9820cee2a354cfbb85e339cbe358bee8f17a5b3c369300d265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "182f9cb9a949ce9820cee2a354cfbb85e339cbe358bee8f17a5b3c369300d265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "182f9cb9a949ce9820cee2a354cfbb85e339cbe358bee8f17a5b3c369300d265", kill_on_drop: false }` [INFO] [stdout] 182f9cb9a949ce9820cee2a354cfbb85e339cbe358bee8f17a5b3c369300d265 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 679521244bb34bd2f734e1e800cff6b487ddf7823208c4526b90e7b16224858a [INFO] running `Command { std: "docker" "start" "-a" "679521244bb34bd2f734e1e800cff6b487ddf7823208c4526b90e7b16224858a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling either v1.11.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling prettyplease v0.2.19 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling fastrand v2.0.2 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Checking metrics v0.23.0 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking metrics-util v0.17.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking termion v2.0.3 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling prost-derive v0.12.4 [INFO] [stderr] Compiling prost v0.12.4 [INFO] [stderr] Compiling prost-types v0.12.4 [INFO] [stderr] Compiling prost-build v0.12.4 [INFO] [stderr] Compiling metrics-observer v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 52 | let state = state.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let metrics = metrics.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let metadata = metadata.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 56 | | let mut runner = Runner::new(addr, state, metrics, metadata); [INFO] [stdout] 57 | | runner.run(); [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 104 | state: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | metrics: Arc>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | metadata: Arc>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | ) -> Runner { [INFO] [stdout] 108 | Runner { state: RunnerState::Disconnected, addr, client_state: state, metrics, metadata } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics-observer` (bin "metrics-observer") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 52 | let state = state.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let metrics = metrics.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let metadata = metadata.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 56 | | let mut runner = Runner::new(addr, state, metrics, metadata); [INFO] [stdout] 57 | | runner.run(); [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 104 | state: Arc>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | metrics: Arc>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | metadata: Arc>>, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | ) -> Runner { [INFO] [stdout] 108 | Runner { state: RunnerState::Disconnected, addr, client_state: state, metrics, metadata } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics-observer` (bin "metrics-observer" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "679521244bb34bd2f734e1e800cff6b487ddf7823208c4526b90e7b16224858a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "679521244bb34bd2f734e1e800cff6b487ddf7823208c4526b90e7b16224858a", kill_on_drop: false }` [INFO] [stdout] 679521244bb34bd2f734e1e800cff6b487ddf7823208c4526b90e7b16224858a