[INFO] fetching crate metrics 0.23.0... [INFO] checking metrics-0.23.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate metrics 0.23.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate metrics 0.23.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metrics 0.23.0 [INFO] finished tweaking crates.io crate metrics 0.23.0 [INFO] tweaked toml for crates.io crate metrics 0.23.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate metrics 0.23.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c918e31999bef03c13a91a23470beff473e30479913134a246a8848889c3435e [INFO] running `Command { std: "docker" "start" "-a" "c918e31999bef03c13a91a23470beff473e30479913134a246a8848889c3435e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c918e31999bef03c13a91a23470beff473e30479913134a246a8848889c3435e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c918e31999bef03c13a91a23470beff473e30479913134a246a8848889c3435e", kill_on_drop: false }` [INFO] [stdout] c918e31999bef03c13a91a23470beff473e30479913134a246a8848889c3435e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] acd203f71304f8bcb50a0413e652414ec72641e6be347a211adbe15151895314 [INFO] running `Command { std: "docker" "start" "-a" "acd203f71304f8bcb50a0413e652414ec72641e6be347a211adbe15151895314", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking winnow v0.6.6 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling trybuild v1.0.91 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking metrics v0.23.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles.rs:73:23 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn from_arc(a: Arc) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { inner: Some(a) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn from_arc(a: Arc) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Self { inner: Some(a) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles.rs:138:23 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn from_arc(a: Arc) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Self { inner: Some(a) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 32 | fn from(name: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | KeyName(name.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:97:19 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn from_static_labels(name: N, labels: &'static [Label]) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | name: name.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:98:21 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn from_static_labels(name: N, labels: &'static [Label]) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | labels: Cow::const_slice(labels), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:141:21 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn into_parts(self) -> (KeyName, Vec