[INFO] fetching crate messy_json 0.2.3... [INFO] checking messy_json-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate messy_json 0.2.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate messy_json 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate messy_json 0.2.3 [INFO] finished tweaking crates.io crate messy_json 0.2.3 [INFO] tweaked toml for crates.io crate messy_json 0.2.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate messy_json 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 983607730f6bb90d091424d1b5f89deed1ecfd26f690c5b7c33f2b0d3cc8b5b2 [INFO] running `Command { std: "docker" "start" "-a" "983607730f6bb90d091424d1b5f89deed1ecfd26f690c5b7c33f2b0d3cc8b5b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "983607730f6bb90d091424d1b5f89deed1ecfd26f690c5b7c33f2b0d3cc8b5b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "983607730f6bb90d091424d1b5f89deed1ecfd26f690c5b7c33f2b0d3cc8b5b2", kill_on_drop: false }` [INFO] [stdout] 983607730f6bb90d091424d1b5f89deed1ecfd26f690c5b7c33f2b0d3cc8b5b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21cbbe1c6aa332c60676da96243f14266240ef8e40b495f8bfe2840dec29998b [INFO] running `Command { std: "docker" "start" "-a" "21cbbe1c6aa332c60676da96243f14266240ef8e40b495f8bfe2840dec29998b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.62 [INFO] [stderr] Compiling serde_derive v1.0.124 [INFO] [stderr] Compiling serde v1.0.124 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.3 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking plotters v0.3.0 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Checking arcstr v1.0.0 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking messy_json v0.2.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.3.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 29 | fn from(x: MessyJsonObjectInner) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | MessyJsonObject(Arc::new(x)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(properties: BTreeMap, optional: bool) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | MessyJsonObjectInner { [INFO] [stdout] 47 | properties: properties.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_value/deserializer/enums.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 22 | seed: V, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | seed.deserialize(variant).map(|v| (v, visitor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 64 | fn from(x: MessyJsonInner) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | MessyJson(Arc::new(x)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema_visitor.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 5 | mut seq: A, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let mut res: BTreeMap = BTreeMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(MessyJsonValueContainer::new(MessyJsonValue::Obj( [INFO] [stdout] | ________^ [INFO] [stdout] 45 | | MessyJsonObjectValue::from(res), [INFO] [stdout] 46 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema_visitor.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 210 | fn visit_none(self) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Ok(MessyJsonValueContainer::new(MessyJsonValue::Null( [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | MessyJsonNullType::Null, [INFO] [stdout] 216 | | MessyJsonExpected::Root(self.inner().clone()), [INFO] [stdout] 217 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema_visitor.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 256 | fn visit_none(self) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(MessyJsonValueContainer::new(MessyJsonValue::Null( [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | MessyJsonNullType::Absent, [INFO] [stdout] 262 | | MessyJsonExpected::Obj(self.inner().clone()), [INFO] [stdout] 263 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `messy_json` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "21cbbe1c6aa332c60676da96243f14266240ef8e40b495f8bfe2840dec29998b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21cbbe1c6aa332c60676da96243f14266240ef8e40b495f8bfe2840dec29998b", kill_on_drop: false }` [INFO] [stdout] 21cbbe1c6aa332c60676da96243f14266240ef8e40b495f8bfe2840dec29998b