[INFO] fetching crate message_plugins 0.2.0... [INFO] checking message_plugins-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate message_plugins 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate message_plugins 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate message_plugins 0.2.0 [INFO] finished tweaking crates.io crate message_plugins 0.2.0 [INFO] tweaked toml for crates.io crate message_plugins 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding libloading v0.6.7 (latest: v0.8.5) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee64b14217009e409645d60daa3e48d9ce5f8e7f86ea75f341f336f212e0412c [INFO] running `Command { std: "docker" "start" "-a" "ee64b14217009e409645d60daa3e48d9ce5f8e7f86ea75f341f336f212e0412c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee64b14217009e409645d60daa3e48d9ce5f8e7f86ea75f341f336f212e0412c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee64b14217009e409645d60daa3e48d9ce5f8e7f86ea75f341f336f212e0412c", kill_on_drop: false }` [INFO] [stdout] ee64b14217009e409645d60daa3e48d9ce5f8e7f86ea75f341f336f212e0412c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba09a69d658c0ca6963162e8451e22069ca5a6cf566ff119e94fcb435d9ef778 [INFO] running `Command { std: "docker" "start" "-a" "ba09a69d658c0ca6963162e8451e22069ca5a6cf566ff119e94fcb435d9ef778", kill_on_drop: false }` [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking message_plugins v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Message { [INFO] [stdout] 163 | content: Arc::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:22 [INFO] [stdout] | [INFO] [stdout] 175 | fn from(content: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Message { [INFO] [stdout] 177 | content: Arc::new(content), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:8 [INFO] [stdout] | [INFO] [stdout] 212 | path: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | constructor: impl AsRef<[u8]>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let lib = libloading::Library::new(path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let mut instance = std::mem::MaybeUninit::zeroed(); [INFO] [stdout] 218 | Ok(unsafe { [INFO] [stdout] | ________^ [INFO] [stdout] 219 | | lib.get::>(constructor.as_ref())?(instance.as_mut_ptr(), args); [INFO] [stdout] 220 | | if ((*instance.as_ptr()).as_ref() as *const dyn Plugin).is_null() { [INFO] [stdout] 221 | | return Err(PluginConstructionError::Construction); [INFO] [stdout] 222 | | } [INFO] [stdout] 223 | | instance.assume_init() [INFO] [stdout] 224 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: references are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/lib.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | if ((*instance.as_ptr()).as_ref() as *const dyn Plugin).is_null() { [INFO] [stdout] | ^-----------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `&dyn Plugin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` fn uses type `Option<&dyn Any>`, which is not FFI-safe [INFO] [stdout] --> src/lib.rs:256:29 [INFO] [stdout] | [INFO] [stdout] 256 | pub type FfiPluginInit = unsafe extern "C" fn(*mut Box>, Option<&dyn Any>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum [INFO] [stdout] = note: enum has no representation hint [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:29 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn attach_with_capacity(&mut self, mut plugin: impl Plugin, capacity: usize) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let (tx, rx) = mpsc::sync_channel(capacity); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | self.plugins.push(tx); [INFO] [stdout] 123 | self.tasks.push(std::thread::spawn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 124 | | while let Ok(message) = rx.recv() { [INFO] [stdout] 125 | | if let Some(status) = plugin.handle_message(message) { [INFO] [stdout] 126 | | return Some(status); [INFO] [stdout] ... | [INFO] [stdout] 129 | | None [INFO] [stdout] 130 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `message_plugins` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Message { [INFO] [stdout] 163 | content: Arc::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:22 [INFO] [stdout] | [INFO] [stdout] 175 | fn from(content: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Message { [INFO] [stdout] 177 | content: Arc::new(content), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:8 [INFO] [stdout] | [INFO] [stdout] 212 | path: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | constructor: impl AsRef<[u8]>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let lib = libloading::Library::new(path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let mut instance = std::mem::MaybeUninit::zeroed(); [INFO] [stdout] 218 | Ok(unsafe { [INFO] [stdout] | ________^ [INFO] [stdout] 219 | | lib.get::>(constructor.as_ref())?(instance.as_mut_ptr(), args); [INFO] [stdout] 220 | | if ((*instance.as_ptr()).as_ref() as *const dyn Plugin).is_null() { [INFO] [stdout] 221 | | return Err(PluginConstructionError::Construction); [INFO] [stdout] 222 | | } [INFO] [stdout] 223 | | instance.assume_init() [INFO] [stdout] 224 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: references are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/lib.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | if ((*instance.as_ptr()).as_ref() as *const dyn Plugin).is_null() { [INFO] [stdout] | ^-----------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `&dyn Plugin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` fn uses type `Option<&dyn Any>`, which is not FFI-safe [INFO] [stdout] --> src/lib.rs:256:29 [INFO] [stdout] | [INFO] [stdout] 256 | pub type FfiPluginInit = unsafe extern "C" fn(*mut Box>, Option<&dyn Any>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum [INFO] [stdout] = note: enum has no representation hint [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:29 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn attach_with_capacity(&mut self, mut plugin: impl Plugin, capacity: usize) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let (tx, rx) = mpsc::sync_channel(capacity); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | self.plugins.push(tx); [INFO] [stdout] 123 | self.tasks.push(std::thread::spawn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 124 | | while let Ok(message) = rx.recv() { [INFO] [stdout] 125 | | if let Some(status) = plugin.handle_message(message) { [INFO] [stdout] 126 | | return Some(status); [INFO] [stdout] ... | [INFO] [stdout] 129 | | None [INFO] [stdout] 130 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `message_plugins` (lib) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ba09a69d658c0ca6963162e8451e22069ca5a6cf566ff119e94fcb435d9ef778", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba09a69d658c0ca6963162e8451e22069ca5a6cf566ff119e94fcb435d9ef778", kill_on_drop: false }` [INFO] [stdout] ba09a69d658c0ca6963162e8451e22069ca5a6cf566ff119e94fcb435d9ef778