[INFO] fetching crate meshanina 0.4.2... [INFO] checking meshanina-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate meshanina 0.4.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate meshanina 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate meshanina 0.4.2 [INFO] finished tweaking crates.io crate meshanina 0.4.2 [INFO] tweaked toml for crates.io crate meshanina 0.4.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate meshanina 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fdd37a8a43006bbdee016e5f6f404b332e0f2e7648edc21445e49cf93f97a187 [INFO] running `Command { std: "docker" "start" "-a" "fdd37a8a43006bbdee016e5f6f404b332e0f2e7648edc21445e49cf93f97a187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fdd37a8a43006bbdee016e5f6f404b332e0f2e7648edc21445e49cf93f97a187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fdd37a8a43006bbdee016e5f6f404b332e0f2e7648edc21445e49cf93f97a187", kill_on_drop: false }` [INFO] [stdout] fdd37a8a43006bbdee016e5f6f404b332e0f2e7648edc21445e49cf93f97a187 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 933ae67c33450f06f5b87296dbe1e32f6e9f32bc0a12b8eafce5265c39862fd6 [INFO] running `Command { std: "docker" "start" "-a" "933ae67c33450f06f5b87296dbe1e32f6e9f32bc0a12b8eafce5265c39862fd6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling semver v1.0.9 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking spin v0.9.3 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking crc-catalog v1.1.1 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking crc v2.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking lz4_flex v0.9.5 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling blake3 v1.3.1 [INFO] [stderr] Compiling argh_shared v0.1.9 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking siphasher v0.3.10 [INFO] [stderr] Checking ethnum v1.2.1 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking zeroize v1.5.5 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking dashmap v5.3.4 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling pin-project-internal v1.0.11 [INFO] [stderr] Compiling argh_derive v0.1.9 [INFO] [stderr] Checking pin-project v1.0.11 [INFO] [stderr] Checking flume v0.10.13 [INFO] [stderr] Checking argh v0.1.9 [INFO] [stderr] Checking meshanina v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn open(fname: impl AsRef) -> std::io::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let table = Table::open(fname.as_ref())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let inner = Arc::new(RwLock::new(table)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let inner_weak = Arc::downgrade(&inner); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(Mapping { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy/mapping.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 26 | let handle = std::fs::OpenOptions::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut alloc_mmap = unsafe { MmapOptions::new().len(1 << 30).map_mut(&handle)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(Mapping { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | inner: MappingInner { [INFO] [stdout] 68 | | table: Table::new(handle.try_clone().unwrap(), 1 << 30), [INFO] [stdout] 69 | | alloc_mmap, [INFO] [stdout] ... | [INFO] [stdout] 72 | | _file: handle, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 35 | let mut handle = std::fs::OpenOptions::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut mmap = unsafe { MmapOptions::new().len(1 << 39).map_mut(&handle).unwrap() }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Table { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | root: Record::HamtNode(true, 0, vec![]), [INFO] [stdout] 94 | | dirty: false, [INFO] [stdout] 95 | | divider, [INFO] [stdout] ... | [INFO] [stdout] 98 | | ptr, [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:221:42 [INFO] [stdout] | [INFO] [stdout] 221 | let ptr = p.load(|p| self.load_record(p).into_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `meshanina` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "933ae67c33450f06f5b87296dbe1e32f6e9f32bc0a12b8eafce5265c39862fd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "933ae67c33450f06f5b87296dbe1e32f6e9f32bc0a12b8eafce5265c39862fd6", kill_on_drop: false }` [INFO] [stdout] 933ae67c33450f06f5b87296dbe1e32f6e9f32bc0a12b8eafce5265c39862fd6