[INFO] fetching crate merkle-trees-cry4 0.1.1... [INFO] checking merkle-trees-cry4-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate merkle-trees-cry4 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate merkle-trees-cry4 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate merkle-trees-cry4 0.1.1 [INFO] finished tweaking crates.io crate merkle-trees-cry4 0.1.1 [INFO] tweaked toml for crates.io crate merkle-trees-cry4 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate merkle-trees-cry4 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75bcc355dd753d198451edfd34f1498d9eb423c84414997b4ad468d98f37bcb5 [INFO] running `Command { std: "docker" "start" "-a" "75bcc355dd753d198451edfd34f1498d9eb423c84414997b4ad468d98f37bcb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75bcc355dd753d198451edfd34f1498d9eb423c84414997b4ad468d98f37bcb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75bcc355dd753d198451edfd34f1498d9eb423c84414997b4ad468d98f37bcb5", kill_on_drop: false }` [INFO] [stdout] 75bcc355dd753d198451edfd34f1498d9eb423c84414997b4ad468d98f37bcb5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6982e1e8a07edc08e6061af9cce403b560d63b0b583556262ce8d0027753f3ad [INFO] running `Command { std: "docker" "start" "-a" "6982e1e8a07edc08e6061af9cce403b560d63b0b583556262ce8d0027753f3ad", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking wyz v0.5.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking bitvec v1.0.0 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking one-time-signatures-cry4 v0.1.0 [INFO] [stderr] Checking merkle-trees-cry4 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 41 | let mut sk_leaves: Vec>> = Vec::with_capacity(N); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let mut pk_leaves: Vec>> = Vec::with_capacity(N); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(MerkleSecretKey { sk_leaves, pk_leaves, used_leaves, p: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 77 | let ots_sig = self.sk_leaves[leaf].sign(m)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let ots_pk = self.pk_leaves[leaf].clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(MerkleSignature { ots_sig, ots_pk, auth_path, index: leaf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:97:59 [INFO] [stdout] | [INFO] [stdout] 97 | let leaf_bytes = self.pk_leaves.iter().map(|leaf| D::digest(leaf.to_bytes()).to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:144:70 [INFO] [stdout] | [INFO] [stdout] 144 | let first: Vec> = sk.pk_leaves.iter().map(|leaf| D::digest(&leaf.to_bytes()).to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `merkle-trees-cry4` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 41 | let mut sk_leaves: Vec>> = Vec::with_capacity(N); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let mut pk_leaves: Vec>> = Vec::with_capacity(N); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(MerkleSecretKey { sk_leaves, pk_leaves, used_leaves, p: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 77 | let ots_sig = self.sk_leaves[leaf].sign(m)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let ots_pk = self.pk_leaves[leaf].clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(MerkleSignature { ots_sig, ots_pk, auth_path, index: leaf }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:97:59 [INFO] [stdout] | [INFO] [stdout] 97 | let leaf_bytes = self.pk_leaves.iter().map(|leaf| D::digest(leaf.to_bytes()).to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merkle.rs:144:70 [INFO] [stdout] | [INFO] [stdout] 144 | let first: Vec> = sk.pk_leaves.iter().map(|leaf| D::digest(&leaf.to_bytes()).to_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `merkle-trees-cry4` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "6982e1e8a07edc08e6061af9cce403b560d63b0b583556262ce8d0027753f3ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6982e1e8a07edc08e6061af9cce403b560d63b0b583556262ce8d0027753f3ad", kill_on_drop: false }` [INFO] [stdout] 6982e1e8a07edc08e6061af9cce403b560d63b0b583556262ce8d0027753f3ad