[INFO] fetching crate merge-junit 0.2.1... [INFO] checking merge-junit-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate merge-junit 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate merge-junit 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate merge-junit 0.2.1 [INFO] finished tweaking crates.io crate merge-junit 0.2.1 [INFO] tweaked toml for crates.io crate merge-junit 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate merge-junit 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c02231d47e985b7482d31e3e1024bcd5590543058013e49bc92a7246df323421 [INFO] running `Command { std: "docker" "start" "-a" "c02231d47e985b7482d31e3e1024bcd5590543058013e49bc92a7246df323421", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c02231d47e985b7482d31e3e1024bcd5590543058013e49bc92a7246df323421", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c02231d47e985b7482d31e3e1024bcd5590543058013e49bc92a7246df323421", kill_on_drop: false }` [INFO] [stdout] c02231d47e985b7482d31e3e1024bcd5590543058013e49bc92a7246df323421 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 462f2e2faa2b042b4b558ef2b79bb340d5e9aafbe29098656fab41a9ebc951f3 [INFO] running `Command { std: "docker" "start" "-a" "462f2e2faa2b042b4b558ef2b79bb340d5e9aafbe29098656fab41a9ebc951f3", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking quick-xml v0.35.0 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking merge-junit v0.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/junit_merger/testsuites.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 72 | fn sum_or_either(first: Option, second: Option) -> Result> { [INFO] [stdout] | ---------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(match (first, second) { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | (None, Some(x)) | (Some(x), None) => Some(x), [INFO] [stdout] 75 | | (Some(x), Some(y)) => Some(x.safe_add(y)?), [INFO] [stdout] 76 | | _ => None, [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/junit_merger/testsuites.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 131 | fn merge(self, other: Self) -> Self::Output { [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `merge-junit` (bin "merge-junit") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "462f2e2faa2b042b4b558ef2b79bb340d5e9aafbe29098656fab41a9ebc951f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "462f2e2faa2b042b4b558ef2b79bb340d5e9aafbe29098656fab41a9ebc951f3", kill_on_drop: false }` [INFO] [stdout] 462f2e2faa2b042b4b558ef2b79bb340d5e9aafbe29098656fab41a9ebc951f3