[INFO] fetching crate memur 0.1.2... [INFO] checking memur-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate memur 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate memur 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate memur 0.1.2 [INFO] finished tweaking crates.io crate memur 0.1.2 [INFO] tweaked toml for crates.io crate memur 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aaa0cab8cb4756c3166dff81f679e12bad7425cec9cadf8f28f3823bd1726f2f [INFO] running `Command { std: "docker" "start" "-a" "aaa0cab8cb4756c3166dff81f679e12bad7425cec9cadf8f28f3823bd1726f2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aaa0cab8cb4756c3166dff81f679e12bad7425cec9cadf8f28f3823bd1726f2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aaa0cab8cb4756c3166dff81f679e12bad7425cec9cadf8f28f3823bd1726f2f", kill_on_drop: false }` [INFO] [stdout] aaa0cab8cb4756c3166dff81f679e12bad7425cec9cadf8f28f3823bd1726f2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8cbefd32a9999d47b76e51ae8016e83093b3389ddf5c7c42f55eb35b1d9054a [INFO] running `Command { std: "docker" "start" "-a" "d8cbefd32a9999d47b76e51ae8016e83093b3389ddf5c7c42f55eb35b1d9054a", kill_on_drop: false }` [INFO] [stderr] Checking memur v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused return value of `transmute_copy` that must be used [INFO] [stdout] --> src/droplist.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | std::mem::transmute_copy::(ref_to_t); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 128 | let _ = std::mem::transmute_copy::(ref_to_t); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 292 | let mut memory = memory.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let mut block = Block::new(memory.take_block()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | Ok(Arena { [INFO] [stdout] | ____________^ [INFO] [stdout] 306 | | metadata, [INFO] [stdout] 307 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn return_block(&mut self, block: Box<[u8]>) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | self.shared.lock().expect("lock").return_block(block) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/n.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(arena: &Arena, value: T) -> Result, UploadError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let wrapped = NMetadata { value, outlives: null_mut() }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let (item_ptr, _) = unsafe { arena.upload_auto_drop(wrapped)? }; [INFO] [stdout] 51 | Ok(N { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | _arena: arena.to_weak_arena(), [INFO] [stdout] 53 | | _ptr: item_ptr, [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/n.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn outlives(&self, value: O) -> Result, UploadError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | match self._arena.arena() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `memur` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused return value of `transmute_copy` that must be used [INFO] [stdout] --> src/droplist.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | std::mem::transmute_copy::(ref_to_t); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 128 | let _ = std::mem::transmute_copy::(ref_to_t); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 292 | let mut memory = memory.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let mut block = Block::new(memory.take_block()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | Ok(Arena { [INFO] [stdout] | ____________^ [INFO] [stdout] 306 | | metadata, [INFO] [stdout] 307 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn return_block(&mut self, block: Box<[u8]>) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | self.shared.lock().expect("lock").return_block(block) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/n.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(arena: &Arena, value: T) -> Result, UploadError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let wrapped = NMetadata { value, outlives: null_mut() }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let (item_ptr, _) = unsafe { arena.upload_auto_drop(wrapped)? }; [INFO] [stdout] 51 | Ok(N { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | _arena: arena.to_weak_arena(), [INFO] [stdout] 53 | | _ptr: item_ptr, [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/n.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn outlives(&self, value: O) -> Result, UploadError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | match self._arena.arena() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `memur` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d8cbefd32a9999d47b76e51ae8016e83093b3389ddf5c7c42f55eb35b1d9054a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8cbefd32a9999d47b76e51ae8016e83093b3389ddf5c7c42f55eb35b1d9054a", kill_on_drop: false }` [INFO] [stdout] d8cbefd32a9999d47b76e51ae8016e83093b3389ddf5c7c42f55eb35b1d9054a