[INFO] fetching crate membership 0.0.6... [INFO] checking membership-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate membership 0.0.6 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate membership 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate membership 0.0.6 [INFO] finished tweaking crates.io crate membership 0.0.6 [INFO] tweaked toml for crates.io crate membership 0.0.6 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate membership 0.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 242d38954b13da0ab6c63432b966fc785c09baa8d3d9feef24e491f627a61685 [INFO] running `Command { std: "docker" "start" "-a" "242d38954b13da0ab6c63432b966fc785c09baa8d3d9feef24e491f627a61685", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "242d38954b13da0ab6c63432b966fc785c09baa8d3d9feef24e491f627a61685", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "242d38954b13da0ab6c63432b966fc785c09baa8d3d9feef24e491f627a61685", kill_on_drop: false }` [INFO] [stdout] 242d38954b13da0ab6c63432b966fc785c09baa8d3d9feef24e491f627a61685 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e2871e84b284c3fbfa86844caf6d8518c737d51a155616c97cdcb4c65104f3d [INFO] running `Command { std: "docker" "start" "-a" "2e2871e84b284c3fbfa86844caf6d8518c737d51a155616c97cdcb4c65104f3d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling proc-macro2 v0.4.29 [INFO] [stderr] Compiling syn v0.15.33 [INFO] [stderr] Compiling slog v2.5.2 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling regex v1.1.6 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking regex-syntax v0.6.6 [INFO] [stderr] Compiling bitflags v1.0.5 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling unicode-segmentation v1.2.1 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking block-padding v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking rand_pcg v0.2.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking rand v0.7.1 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking slog-scope v4.3.0 [INFO] [stderr] Checking bytes v0.5.3 [INFO] [stderr] Checking rle-decode-fast v1.0.1 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking libflate v0.1.27 [INFO] [stderr] Checking slog-stdlog v3.0.5 [INFO] [stderr] Checking slog-async v2.4.0 [INFO] [stderr] Checking env_logger v0.6.1 [INFO] [stderr] Checking slog-kvfilter v0.7.0 [INFO] [stderr] Checking slog-term v2.5.0 [INFO] [stderr] Checking backtrace v0.3.37 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling structopt-derive v0.2.15 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking trackable v0.2.23 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking structopt v0.2.15 [INFO] [stderr] Checking membership v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:33:45 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) fn encode(self) -> OutgoingMessage { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | OutgoingMessage::PingRequestMessage(PingRequestMessageOut { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 34 | | buffer: self.buffer.into_inner().freeze(), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 104 | pub(crate) fn sender(mut self, member: &Member) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | encode_member(member, &mut self.buffer)?; [INFO] [stdout] 106 | Ok(T::from(self.buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn target(mut self, member: &Member) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | encode_member(member, &mut self.buffer)?; [INFO] [stdout] 130 | Ok(T::from(self.buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 152 | pub(crate) fn message_type(mut self, message_type: MessageType) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Ok(T::from(self.buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 179 | pub(crate) fn sequence_number(mut self, sequence_number: u64) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(T::from(self.buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 204 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | notifications: impl Iterator, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(BroadcastEncoder { [INFO] [stdout] | ____________^ [INFO] [stdout] 222 | | buffer: self.buffer, [INFO] [stdout] 223 | | num_notifications: self.num_notifications, [INFO] [stdout] 224 | | num_broadcast: 0, [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:229:47 [INFO] [stdout] | [INFO] [stdout] 228 | pub(crate) fn encode(self) -> OutgoingMessage { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | OutgoingMessage::DisseminationMessage(DisseminationMessageOut { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 230 | | buffer: self.buffer.into_inner().freeze(), [INFO] [stdout] 231 | | num_notifications: self.num_notifications, [INFO] [stdout] 232 | | num_broadcast: 0, [INFO] [stdout] 233 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_encoder.rs:302:47 [INFO] [stdout] | [INFO] [stdout] 301 | pub(crate) fn encode(self) -> OutgoingMessage { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | OutgoingMessage::DisseminationMessage(DisseminationMessageOut { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 303 | | buffer: self.buffer.into_inner().freeze(), [INFO] [stdout] 304 | | num_notifications: self.num_notifications, [INFO] [stdout] 305 | | num_broadcast: self.num_broadcast, [INFO] [stdout] 306 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync_node.rs:335:15 [INFO] [stdout] | [INFO] [stdout] 325 | fn send_message(&mut self, target: SocketAddr, message: OutgoingMessage) { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | match self.udp.as_ref().unwrap().send_to(message.buffer(), &target) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `membership` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2e2871e84b284c3fbfa86844caf6d8518c737d51a155616c97cdcb4c65104f3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e2871e84b284c3fbfa86844caf6d8518c737d51a155616c97cdcb4c65104f3d", kill_on_drop: false }` [INFO] [stdout] 2e2871e84b284c3fbfa86844caf6d8518c737d51a155616c97cdcb4c65104f3d