[INFO] fetching crate megaui 0.2.18... [INFO] checking megaui-0.2.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate megaui 0.2.18 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate megaui 0.2.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate megaui 0.2.18 [INFO] finished tweaking crates.io crate megaui 0.2.18 [INFO] tweaked toml for crates.io crate megaui 0.2.18 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding rusttype v0.7.9 (latest: v0.9.3) [INFO] [stderr] Adding rusttype v0.8.3 (latest: v0.9.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac21530dcba8930402063912744840a692be0cdf14bb367c08a3e7e82521b275 [INFO] running `Command { std: "docker" "start" "-a" "ac21530dcba8930402063912744840a692be0cdf14bb367c08a3e7e82521b275", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac21530dcba8930402063912744840a692be0cdf14bb367c08a3e7e82521b275", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac21530dcba8930402063912744840a692be0cdf14bb367c08a3e7e82521b275", kill_on_drop: false }` [INFO] [stdout] ac21530dcba8930402063912744840a692be0cdf14bb367c08a3e7e82521b275 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f8e9538c1ff379310b6cc20228dc163fa32d08cf1f34c8ffc4e3647827e4963 [INFO] running `Command { std: "docker" "start" "-a" "2f8e9538c1ff379310b6cc20228dc163fa32d08cf1f34c8ffc4e3647827e4963", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking miniquad_text_rusttype v0.1.2 [INFO] [stderr] Checking megaui v0.2.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ui.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | let mut scroll = &mut self.window.cursor.scroll; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ui.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | let mut scroll = &mut self.window.cursor.scroll; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `aligment` is never read [INFO] [stdout] --> src/draw_command.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 301 | pub struct LabelParams { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 302 | pub color: Color, [INFO] [stdout] 303 | pub aligment: Aligment, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LabelParams` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `visible` is never read [INFO] [stdout] --> src/ui.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) struct Window { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub visible: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dragging_x` is never read [INFO] [stdout] --> src/ui/cursor.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Scroll { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 5 | pub scroll: Vector2, [INFO] [stdout] 6 | pub dragging_x: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Scroll` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `enabled` is never read [INFO] [stdout] --> src/widgets/window.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Window { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | enabled: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Window` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:181:41 [INFO] [stdout] | [INFO] [stdout] 181 | .or_insert_with(|| Box::new(f())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:189:41 [INFO] [stdout] | [INFO] [stdout] 189 | .or_insert_with(|| Box::new(T::default())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/ui.rs:666:23 [INFO] [stdout] | [INFO] [stdout] 666 | for window in &self.modal { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 666 | while let Some(window) = &self.modal { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 666 | if let Some(window) = &self.modal { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/ui.rs:725:23 [INFO] [stdout] | [INFO] [stdout] 725 | for window in &mut self.modal { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 725 | while let Some(window) = &mut self.modal { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 725 | if let Some(window) = &mut self.modal { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `aligment` is never read [INFO] [stdout] --> src/draw_command.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 301 | pub struct LabelParams { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 302 | pub color: Color, [INFO] [stdout] 303 | pub aligment: Aligment, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LabelParams` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `visible` is never read [INFO] [stdout] --> src/ui.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) struct Window { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub visible: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dragging_x` is never read [INFO] [stdout] --> src/ui/cursor.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Scroll { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 5 | pub scroll: Vector2, [INFO] [stdout] 6 | pub dragging_x: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Scroll` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `enabled` is never read [INFO] [stdout] --> src/widgets/window.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Window { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | enabled: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Window` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:181:41 [INFO] [stdout] | [INFO] [stdout] 181 | .or_insert_with(|| Box::new(f())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `megaui` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:189:41 [INFO] [stdout] | [INFO] [stdout] 189 | .or_insert_with(|| Box::new(T::default())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/ui.rs:666:23 [INFO] [stdout] | [INFO] [stdout] 666 | for window in &self.modal { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 666 | while let Some(window) = &self.modal { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 666 | if let Some(window) = &self.modal { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/ui.rs:725:23 [INFO] [stdout] | [INFO] [stdout] 725 | for window in &mut self.modal { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 725 | while let Some(window) = &mut self.modal { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 725 | if let Some(window) = &mut self.modal { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `megaui` (lib) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2f8e9538c1ff379310b6cc20228dc163fa32d08cf1f34c8ffc4e3647827e4963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f8e9538c1ff379310b6cc20228dc163fa32d08cf1f34c8ffc4e3647827e4963", kill_on_drop: false }` [INFO] [stdout] 2f8e9538c1ff379310b6cc20228dc163fa32d08cf1f34c8ffc4e3647827e4963