[INFO] fetching crate mdl 1.0.5... [INFO] checking mdl-1.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mdl 1.0.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate mdl 1.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mdl 1.0.5 [INFO] finished tweaking crates.io crate mdl 1.0.5 [INFO] tweaked toml for crates.io crate mdl 1.0.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e813ebd40686a649262bc0c241ae54fa0b62a8c363996309d4864f836532d9a [INFO] running `Command { std: "docker" "start" "-a" "6e813ebd40686a649262bc0c241ae54fa0b62a8c363996309d4864f836532d9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e813ebd40686a649262bc0c241ae54fa0b62a8c363996309d4864f836532d9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e813ebd40686a649262bc0c241ae54fa0b62a8c363996309d4864f836532d9a", kill_on_drop: false }` [INFO] [stdout] 6e813ebd40686a649262bc0c241ae54fa0b62a8c363996309d4864f836532d9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e174db09dbca642b26113c4ff6492059a30918ca3c58c5e06ca7826edfe1df0 [INFO] running `Command { std: "docker" "start" "-a" "4e174db09dbca642b26113c4ff6492059a30918ca3c58c5e06ca7826edfe1df0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling lmdb-sys v0.8.0 [INFO] [stderr] Checking lmdb v0.8.0 [INFO] [stderr] Checking mdl v1.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 29 | fn all(&self, db: &'static str, prefix: &str, formatter: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let output: Rc>> = Rc::new(RefCell::new(vec![])); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let out = output.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Rc::try_unwrap(output) [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | .map_err(|_| anyhow!("error reading from db"))? [INFO] [stdout] 45 | | .into_inner()) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 40 | let env = Environment::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Cache { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | env: env, [INFO] [stdout] 47 | | path: path.to_string(), [INFO] [stdout] 48 | | dbs: RefCell::new(HashMap::new()), [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 110 | fn pull(&self, db: &'static str, key: &str, formatter: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | self.ro(db, move |cursor| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 114 | | let k = Some(key.as_ref()); [INFO] [stdout] 115 | | let (_rkey, rdata) = cursor.get(k, None, 15)?; [INFO] [stdout] 116 | | formatter(rdata) [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcache.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn pull(&self, db: &'static str, key: &str, formatter: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | match self.db.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcache.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 56 | fn iter(&self, db: &'static str, prefix: &str, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | match self.db.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:81:40 [INFO] [stdout] | [INFO] [stdout] 78 | fn iter(store: &S, prefix: &str, f: F) -> Result<(), Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | store.iter(Self::db(), prefix, move |data| { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 82 | | match Self::fromb(data) { [INFO] [stdout] 83 | | Ok(obj) => f(obj), [INFO] [stdout] 84 | | _ => Continue(true) [INFO] [stdout] 85 | | } [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 78 | fn iter(store: &S, prefix: &str, f: F) -> Result<(), Error> [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | match Self::fromb(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mdl` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 29 | fn all(&self, db: &'static str, prefix: &str, formatter: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let output: Rc>> = Rc::new(RefCell::new(vec![])); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let out = output.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Rc::try_unwrap(output) [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | .map_err(|_| anyhow!("error reading from db"))? [INFO] [stdout] 45 | | .into_inner()) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 40 | let env = Environment::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Cache { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | env: env, [INFO] [stdout] 47 | | path: path.to_string(), [INFO] [stdout] 48 | | dbs: RefCell::new(HashMap::new()), [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 110 | fn pull(&self, db: &'static str, key: &str, formatter: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | self.ro(db, move |cursor| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 114 | | let k = Some(key.as_ref()); [INFO] [stdout] 115 | | let (_rkey, rdata) = cursor.get(k, None, 15)?; [INFO] [stdout] 116 | | formatter(rdata) [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcache.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn pull(&self, db: &'static str, key: &str, formatter: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | match self.db.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bcache.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 56 | fn iter(&self, db: &'static str, prefix: &str, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | match self.db.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:81:40 [INFO] [stdout] | [INFO] [stdout] 78 | fn iter(store: &S, prefix: &str, f: F) -> Result<(), Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | store.iter(Self::db(), prefix, move |data| { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 82 | | match Self::fromb(data) { [INFO] [stdout] 83 | | Ok(obj) => f(obj), [INFO] [stdout] 84 | | _ => Continue(true) [INFO] [stdout] 85 | | } [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 78 | fn iter(store: &S, prefix: &str, f: F) -> Result<(), Error> [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | match Self::fromb(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mdl` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4e174db09dbca642b26113c4ff6492059a30918ca3c58c5e06ca7826edfe1df0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e174db09dbca642b26113c4ff6492059a30918ca3c58c5e06ca7826edfe1df0", kill_on_drop: false }` [INFO] [stdout] 4e174db09dbca642b26113c4ff6492059a30918ca3c58c5e06ca7826edfe1df0