[INFO] fetching crate mdbook-admonish 1.18.0... [INFO] checking mdbook-admonish-1.18.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mdbook-admonish 1.18.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mdbook-admonish 1.18.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mdbook-admonish 1.18.0 [INFO] finished tweaking crates.io crate mdbook-admonish 1.18.0 [INFO] tweaked toml for crates.io crate mdbook-admonish 1.18.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate mdbook-admonish 1.18.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2855caeb63b4d41e6382ffbfe5861edb236ae9342f536ada5c70b33abfa644e9 [INFO] running `Command { std: "docker" "start" "-a" "2855caeb63b4d41e6382ffbfe5861edb236ae9342f536ada5c70b33abfa644e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2855caeb63b4d41e6382ffbfe5861edb236ae9342f536ada5c70b33abfa644e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2855caeb63b4d41e6382ffbfe5861edb236ae9342f536ada5c70b33abfa644e9", kill_on_drop: false }` [INFO] [stdout] 2855caeb63b4d41e6382ffbfe5861edb236ae9342f536ada5c70b33abfa644e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b3cb74d640b736009f8b5936718923504ff43080ba5cf8049ecce9c7cad4e50 [INFO] running `Command { std: "docker" "start" "-a" "2b3cb74d640b736009f8b5936718923504ff43080ba5cf8049ecce9c7cad4e50", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Compiling pulldown-cmark v0.10.3 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking pulldown-cmark-escape v0.10.1 [INFO] [stderr] Compiling pulldown-cmark v0.11.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking opener v0.7.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking notify-debouncer-mini v0.4.1 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking topological-sort v0.2.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking path-slash v0.2.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking clap_complete v4.5.6 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking hex_color v3.0.0 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking elasticlunr-rs v3.0.2 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking ammonia v4.0.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking warp v0.3.7 [INFO] [stderr] Checking mdbook v0.4.40 [INFO] [stderr] Checking mdbook-admonish v1.18.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/toml_wrangling.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | Lazy::new(|| Regex::new(r#"^[A-Za-z0-9_-]+$"#).expect("directive regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/v2.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | Lazy::new(|| Regex::new(r#"(?:[A-Za-z0-9_-]+) *="#).expect("bare key assignment regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/custom.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | Lazy::new(|| Regex::new(r"[\r\n]+\s*").expect("invalid whitespace regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 68 | OnFailure::Bail => Err(anyhow!("Error processing admonition, bailing:\n{content}")), [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Some(Ok(Admonition::new( [INFO] [stdout] | __________^ [INFO] [stdout] 74 | | info, [INFO] [stdout] 75 | | extracted.body, [INFO] [stdout] 76 | | // Note that this is a bit hacky - the fence information comes from the start [INFO] [stdout] ... | [INFO] [stdout] 89 | | indent, [INFO] [stdout] 90 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/toml_wrangling.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | Lazy::new(|| Regex::new(r#"^[A-Za-z0-9_-]+$"#).expect("directive regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preprocessor.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 60 | let mut res = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | res.unwrap_or(Ok(())).map(|_| book) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/v2.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | Lazy::new(|| Regex::new(r#"(?:[A-Za-z0-9_-]+) *="#).expect("bare key assignment regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/custom.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | Lazy::new(|| Regex::new(r"[\r\n]+\s*").expect("invalid whitespace regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 68 | OnFailure::Bail => Err(anyhow!("Error processing admonition, bailing:\n{content}")), [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Some(Ok(Admonition::new( [INFO] [stdout] | __________^ [INFO] [stdout] 74 | | info, [INFO] [stdout] 75 | | extracted.body, [INFO] [stdout] 76 | | // Note that this is a bit hacky - the fence information comes from the start [INFO] [stdout] ... | [INFO] [stdout] 89 | | indent, [INFO] [stdout] 90 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preprocessor.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 60 | let mut res = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | res.unwrap_or(Ok(())).map(|_| book) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mdbook-admonish` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mdbook-admonish` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "2b3cb74d640b736009f8b5936718923504ff43080ba5cf8049ecce9c7cad4e50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b3cb74d640b736009f8b5936718923504ff43080ba5cf8049ecce9c7cad4e50", kill_on_drop: false }` [INFO] [stdout] 2b3cb74d640b736009f8b5936718923504ff43080ba5cf8049ecce9c7cad4e50