[INFO] fetching crate mcvm 0.23.0... [INFO] checking mcvm-0.23.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mcvm 0.23.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate mcvm 0.23.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mcvm 0.23.0 [INFO] finished tweaking crates.io crate mcvm 0.23.0 [INFO] tweaked toml for crates.io crate mcvm 0.23.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate mcvm 0.23.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `mcvm_plugin` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `reqwest` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9514dff20d790aa1f5482d2046de91dd9d7136dd454b2ce9e6d8a4d3ba33c4b3 [INFO] running `Command { std: "docker" "start" "-a" "9514dff20d790aa1f5482d2046de91dd9d7136dd454b2ce9e6d8a4d3ba33c4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9514dff20d790aa1f5482d2046de91dd9d7136dd454b2ce9e6d8a4d3ba33c4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9514dff20d790aa1f5482d2046de91dd9d7136dd454b2ce9e6d8a4d3ba33c4b3", kill_on_drop: false }` [INFO] [stdout] 9514dff20d790aa1f5482d2046de91dd9d7136dd454b2ce9e6d8a4d3ba33c4b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 81a9920c9491a896e998c15b356c8d1752015ff5dc419957d0981f54f58d391a [INFO] running `Command { std: "docker" "start" "-a" "81a9920c9491a896e998c15b356c8d1752015ff5dc419957d0981f54f58d391a", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `mcvm_plugin` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `reqwest` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking cfg-match v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling urlencoding v2.1.3 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Compiling zip v2.1.0 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking deflate64 v0.1.8 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking dary_heap v0.3.6 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking version-compare v0.2.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling kinded_macros v0.3.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Compiling kinded v0.3.0 [INFO] [stderr] Compiling nutype_macros v0.4.2 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking nutype v0.4.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking mcvm_shared v0.14.0 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking value-trait v0.8.1 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking simd-json v0.13.10 [INFO] [stderr] Checking mcvm_parse v0.15.0 [INFO] [stderr] Checking mcvm_pkg v0.14.0 [INFO] [stderr] Checking mcvm_net v0.1.0 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking oauth2 v4.4.2 [INFO] [stderr] Checking mcvm_auth v0.5.0 [INFO] [stderr] Checking mcvm_core v0.7.0 [INFO] [stderr] Checking mcvm_plugin v0.3.0 [INFO] [stderr] Checking mcvm_mods v0.7.0 [INFO] [stderr] Checking mcvm v0.23.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:203:6 [INFO] [stdout] | [INFO] [stdout] 109 | config: ConfigDeser, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | plugins: PluginManager, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let mut users = UserManager::new(ClientId::new("".into())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut instances = HashMap::with_capacity(config.instances.len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | // Preferences [INFO] [stdout] 118 | let (prefs, repositories) = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let packages = PkgRegistry::new(repositories, prefs.package_caching_strategy.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let profiles = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | users, [INFO] [stdout] 205 | | instances, [INFO] [stdout] 206 | | instance_groups: config.instance_groups, [INFO] [stdout] ... | [INFO] [stdout] 209 | | prefs, [INFO] [stdout] 210 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/package.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 155 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | id: self.get_pkg_id(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/plugin.rs:130:11 [INFO] [stdout] | [INFO] [stdout] 127 | let mut manager = LoadedPluginManager::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | inner: Arc::new(Mutex::new(PluginManagerInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 131 | | manager, [INFO] [stdout] 132 | | configs: Vec::new(), [INFO] [stdout] 133 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/preferences.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 85 | let mut repositories = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut existing = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | Self { [INFO] [stdout] 112 | | package_caching_strategy: prefs.package_caching_strategy.clone(), [INFO] [stdout] 113 | | language: prefs.language, [INFO] [stdout] 114 | | }, [INFO] [stdout] 115 | | repositories, [INFO] [stdout] 116 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/packages.rs:106:46 [INFO] [stdout] | [INFO] [stdout] 106 | .unwrap_or_else(|| PackageConfig::from_id(pkg.id.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/packages.rs:159:47 [INFO] [stdout] | [INFO] [stdout] 159 | configured_packages.iter().find(|x| x.id == package.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/update/packages.rs:97:16 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|x| (instance_id.clone(), x.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/update/packages.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 222 | for task in tasks.into_values() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let permit = sem.clone().acquire_owned().await; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let task = async move { [INFO] [stdout] 225 | let _permit = permit?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | [INFO] [stdout] 227 | task.await [INFO] [stdout] | ^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/update/packages.rs:400:28 [INFO] [stdout] | [INFO] [stdout] 386 | message: MessageContents, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | ) -> MessageContents { [INFO] [stdout] 388 | let msg = if let Some(instance) = instance { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | MessageContents::ListItem(Box::new(msg)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lock.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn to_addon(&self, pkg_id: PackageID) -> anyhow::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(Addon { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | kind: AddonKind::parse_from_str(&self.kind) [INFO] [stdout] 86 | | .ok_or(anyhow!("Invalid addon kind '{}'", self.kind))?, [INFO] [stdout] 87 | | id: self.id.clone(), [INFO] [stdout] ... | [INFO] [stdout] 94 | | hashes: self.hashes.clone(), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lock.rs:136:6 [INFO] [stdout] | [INFO] [stdout] 130 | let mut contents = if path.exists() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(Self { contents }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/mod.rs:127:10 [INFO] [stdout] | [INFO] [stdout] 119 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | flags: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | data: Later::new(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/mod.rs:211:65 [INFO] [stdout] | [INFO] [stdout] 210 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | return Some(async move { download::file(url, path, &client).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | plugins: plugins.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | addon_reqs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:215:10 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | deps: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | conflicts: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | recommendations: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | bundled: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | compats: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:220:16 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | extensions: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:587:30 [INFO] [stdout] | [INFO] [stdout] 587 | .map(|x| EvalPackageConfig((*x).clone(), x.get_request())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:587:44 [INFO] [stdout] | [INFO] [stdout] 587 | .map(|x| EvalPackageConfig((*x).clone(), x.get_request())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/declarative.rs:123:19 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|(a, b)| (a.into(), b.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/declarative.rs:123:29 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|(a, b)| (a.into(), b.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/reg.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(repos: Vec, caching_strategy: CachingStrategy) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | packages: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/reg.rs:290:29 [INFO] [stdout] | [INFO] [stdout] 290 | .map(|(id, ..)| Arc::new(PkgRequest::any(id.as_ref(), PkgRequestSource::Repository))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/reg.rs:343:12 [INFO] [stdout] | [INFO] [stdout] 339 | if let Some(task) = pkg.get_download_task(paths, true, client) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let semaphore = semaphore.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | task.await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/repo.rs:244:37 [INFO] [stdout] | [INFO] [stdout] 244 | .map(|(id, entry)| (id.clone(), entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/hash.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn digest_reader(mut reader: R) -> anyhow::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut digest = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(digest.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mcvm` (lib) due to 31 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:203:6 [INFO] [stdout] | [INFO] [stdout] 109 | config: ConfigDeser, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | plugins: PluginManager, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let mut users = UserManager::new(ClientId::new("".into())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut instances = HashMap::with_capacity(config.instances.len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | // Preferences [INFO] [stdout] 118 | let (prefs, repositories) = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let packages = PkgRegistry::new(repositories, prefs.package_caching_strategy.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let profiles = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | users, [INFO] [stdout] 205 | | instances, [INFO] [stdout] 206 | | instance_groups: config.instance_groups, [INFO] [stdout] ... | [INFO] [stdout] 209 | | prefs, [INFO] [stdout] 210 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/package.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 155 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | id: self.get_pkg_id(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/plugin.rs:130:11 [INFO] [stdout] | [INFO] [stdout] 127 | let mut manager = LoadedPluginManager::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | inner: Arc::new(Mutex::new(PluginManagerInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 131 | | manager, [INFO] [stdout] 132 | | configs: Vec::new(), [INFO] [stdout] 133 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/preferences.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 85 | let mut repositories = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut existing = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | Self { [INFO] [stdout] 112 | | package_caching_strategy: prefs.package_caching_strategy.clone(), [INFO] [stdout] 113 | | language: prefs.language, [INFO] [stdout] 114 | | }, [INFO] [stdout] 115 | | repositories, [INFO] [stdout] 116 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/packages.rs:106:46 [INFO] [stdout] | [INFO] [stdout] 106 | .unwrap_or_else(|| PackageConfig::from_id(pkg.id.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/packages.rs:159:47 [INFO] [stdout] | [INFO] [stdout] 159 | configured_packages.iter().find(|x| x.id == package.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/update/packages.rs:97:16 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|x| (instance_id.clone(), x.to_owned())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/update/packages.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 222 | for task in tasks.into_values() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let permit = sem.clone().acquire_owned().await; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let task = async move { [INFO] [stdout] 225 | let _permit = permit?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | [INFO] [stdout] 227 | task.await [INFO] [stdout] | ^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance/update/packages.rs:400:28 [INFO] [stdout] | [INFO] [stdout] 386 | message: MessageContents, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | ) -> MessageContents { [INFO] [stdout] 388 | let msg = if let Some(instance) = instance { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | MessageContents::ListItem(Box::new(msg)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lock.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn to_addon(&self, pkg_id: PackageID) -> anyhow::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(Addon { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | kind: AddonKind::parse_from_str(&self.kind) [INFO] [stdout] 86 | | .ok_or(anyhow!("Invalid addon kind '{}'", self.kind))?, [INFO] [stdout] 87 | | id: self.id.clone(), [INFO] [stdout] ... | [INFO] [stdout] 94 | | hashes: self.hashes.clone(), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lock.rs:136:6 [INFO] [stdout] | [INFO] [stdout] 130 | let mut contents = if path.exists() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(Self { contents }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/mod.rs:127:10 [INFO] [stdout] | [INFO] [stdout] 119 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | flags: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | data: Later::new(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/mod.rs:211:65 [INFO] [stdout] | [INFO] [stdout] 210 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | return Some(async move { download::file(url, path, &client).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | plugins: plugins.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | addon_reqs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:215:10 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | deps: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | conflicts: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | recommendations: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | bundled: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | compats: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:220:16 [INFO] [stdout] | [INFO] [stdout] 202 | id: PackageID, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | extensions: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:587:30 [INFO] [stdout] | [INFO] [stdout] 587 | .map(|x| EvalPackageConfig((*x).clone(), x.get_request())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/mod.rs:587:44 [INFO] [stdout] | [INFO] [stdout] 587 | .map(|x| EvalPackageConfig((*x).clone(), x.get_request())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/declarative.rs:123:19 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|(a, b)| (a.into(), b.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/eval/declarative.rs:123:29 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|(a, b)| (a.into(), b.into())), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/reg.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(repos: Vec, caching_strategy: CachingStrategy) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | packages: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/reg.rs:290:29 [INFO] [stdout] | [INFO] [stdout] 290 | .map(|(id, ..)| Arc::new(PkgRequest::any(id.as_ref(), PkgRequestSource::Repository))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/reg.rs:343:12 [INFO] [stdout] | [INFO] [stdout] 339 | if let Some(task) = pkg.get_download_task(paths, true, client) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let semaphore = semaphore.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | task.await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pkg/repo.rs:244:37 [INFO] [stdout] | [INFO] [stdout] 244 | .map(|(id, entry)| (id.clone(), entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/hash.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn digest_reader(mut reader: R) -> anyhow::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut digest = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(digest.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mcvm` (lib test) due to 31 previous errors [INFO] running `Command { std: "docker" "inspect" "81a9920c9491a896e998c15b356c8d1752015ff5dc419957d0981f54f58d391a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81a9920c9491a896e998c15b356c8d1752015ff5dc419957d0981f54f58d391a", kill_on_drop: false }` [INFO] [stdout] 81a9920c9491a896e998c15b356c8d1752015ff5dc419957d0981f54f58d391a