[INFO] fetching crate mco-rpc 0.1.8... [INFO] checking mco-rpc-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mco-rpc 0.1.8 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mco-rpc 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mco-rpc 0.1.8 [INFO] finished tweaking crates.io crate mco-rpc 0.1.8 [INFO] tweaked toml for crates.io crate mco-rpc 0.1.8 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding generator v0.7.5 (latest: v0.8.3) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding nix v0.27.1 (latest: v0.29.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.48.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f846b249648db5dac7cac4d9049a6ca25c5fc47385780618ef4db60f9684fd4 [INFO] running `Command { std: "docker" "start" "-a" "8f846b249648db5dac7cac4d9049a6ca25c5fc47385780618ef4db60f9684fd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f846b249648db5dac7cac4d9049a6ca25c5fc47385780618ef4db60f9684fd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f846b249648db5dac7cac4d9049a6ca25c5fc47385780618ef4db60f9684fd4", kill_on_drop: false }` [INFO] [stdout] 8f846b249648db5dac7cac4d9049a6ca25c5fc47385780618ef4db60f9684fd4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6aea8cacdd0669c6aeecc09278a8976c9263fd9ea2f61dc35bab4345f40ae2ad [INFO] running `Command { std: "docker" "start" "-a" "6aea8cacdd0669c6aeecc09278a8976c9263fd9ea2f61dc35bab4345f40ae2ad", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling generator v0.7.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking mco v0.1.48 [INFO] [stderr] Checking mco-rpc v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/balance.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | let mut load: LoadBalance = LoadBalance::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/balance.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | let mut load: LoadBalance = LoadBalance::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/balance.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | let mut load: LoadBalance = LoadBalance::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 27 | fn encode(&self, arg: T) -> Result, Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | match serde_json::to_vec(&arg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 50 | fn encode(&self, arg: T) -> Result, Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | match bincode::serialize(&arg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | let stream = TcpStream::connect(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | addr: address, [INFO] [stdout] 25 | | codec: Codecs::BinCodec(BinCodec {}), [INFO] [stdout] 26 | | stub: ClientStub::new(), [INFO] [stdout] 27 | | stream: RefCell::new(stream), [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:74:16 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new(f: F) -> Self where F: Fn(Req) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | f: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 27 | fn encode(&self, arg: T) -> Result, Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | match serde_json::to_vec(&arg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 50 | fn encode(&self, arg: T) -> Result, Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | match bincode::serialize(&arg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | let stream = TcpStream::connect(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | addr: address, [INFO] [stdout] 25 | | codec: Codecs::BinCodec(BinCodec {}), [INFO] [stdout] 26 | | stub: ClientStub::new(), [INFO] [stdout] 27 | | stream: RefCell::new(stream), [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:74:16 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new(f: F) -> Self where F: Fn(Req) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | f: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/balance_manager.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(cfg: ManagerConfig, f: F) -> Arc where F: RegistryCenter + 'static { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 61 | | config: cfg, [INFO] [stdout] 62 | | clients: SyncHashMap::new(), [INFO] [stdout] 63 | | fetcher: Arc::new(f), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/balance_manager.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(cfg: ManagerConfig, f: F) -> Arc where F: RegistryCenter + 'static { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 61 | | config: cfg, [INFO] [stdout] 62 | | clients: SyncHashMap::new(), [INFO] [stdout] 63 | | fetcher: Arc::new(f), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mco-rpc` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mco-rpc` (lib test) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6aea8cacdd0669c6aeecc09278a8976c9263fd9ea2f61dc35bab4345f40ae2ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aea8cacdd0669c6aeecc09278a8976c9263fd9ea2f61dc35bab4345f40ae2ad", kill_on_drop: false }` [INFO] [stdout] 6aea8cacdd0669c6aeecc09278a8976c9263fd9ea2f61dc35bab4345f40ae2ad