[INFO] fetching crate mcap 0.9.2... [INFO] checking mcap-0.9.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mcap 0.9.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mcap 0.9.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mcap 0.9.2 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate mcap 0.9.2 [INFO] tweaked toml for crates.io crate mcap 0.9.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mcap 0.9.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db92dbfabaf6e2f9c86b52d6fad467cdbe46289e6b6a7a4bc708f0e42dff28e5 [INFO] running `Command { std: "docker" "start" "-a" "db92dbfabaf6e2f9c86b52d6fad467cdbe46289e6b6a7a4bc708f0e42dff28e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db92dbfabaf6e2f9c86b52d6fad467cdbe46289e6b6a7a4bc708f0e42dff28e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db92dbfabaf6e2f9c86b52d6fad467cdbe46289e6b6a7a4bc708f0e42dff28e5", kill_on_drop: false }` [INFO] [stdout] db92dbfabaf6e2f9c86b52d6fad467cdbe46289e6b6a7a4bc708f0e42dff28e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a02a415375063737cdead27060d74b2cd55db97565e817e0d1d101b03959535 [INFO] running `Command { std: "docker" "start" "-a" "0a02a415375063737cdead27060d74b2cd55db97565e817e0d1d101b03959535", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.207 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Compiling binrw_derive v0.12.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling binrw v0.12.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.207 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking mcap v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 109 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Some(Ok(record)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:309:12 [INFO] [stdout] | [INFO] [stdout] 270 | let decompressor = match header.compression.as_str() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 310 | | header, [INFO] [stdout] 311 | | decompressor, [INFO] [stdout] 312 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:462:12 [INFO] [stdout] | [INFO] [stdout] 462 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 463 | | top_level, [INFO] [stdout] 464 | | dechunk: None, [INFO] [stdout] 465 | | malformed: false, [INFO] [stdout] 466 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:612:12 [INFO] [stdout] | [INFO] [stdout] 610 | let records = ChunkFlattener::new_with_options(buf, options)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 611 | [INFO] [stdout] 612 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 613 | | full_file, [INFO] [stdout] 614 | | records, [INFO] [stdout] 615 | | done: false, [INFO] [stdout] 616 | | channeler: ChannelAccumulator::default(), [INFO] [stdout] 617 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:867:12 [INFO] [stdout] | [INFO] [stdout] 838 | let mut summary = Summary::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 839 | let mut channeler = ChannelAccumulator::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 867 | Ok(Some(summary)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:1059:15 [INFO] [stdout] | [INFO] [stdout] 1018 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1033 | let mut chunk_reader = ChunkReader::new(h, d)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1059 | match chunk_reader.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 202 | fn with_options(mut writer: W, opts: WriteOptions) -> McapResult { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | writer: Some(WriteMode::Raw(writer)), [INFO] [stdout] 215 | | options: opts, [INFO] [stdout] 216 | | schemas: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 222 | | channel_message_counts: BTreeMap::new(), [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:719:12 [INFO] [stdout] | [INFO] [stdout] 718 | fn finish(self) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 719 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 720 | | Compressor::Null(w) => w, [INFO] [stdout] 721 | | #[cfg(feature = "zstd")] [INFO] [stdout] 722 | | Compressor::Zstd(w) => w.finish()?, [INFO] [stdout] 723 | | #[cfg(feature = "lz4")] [INFO] [stdout] 724 | | Compressor::Lz4(w) => w.finish()?, [INFO] [stdout] 725 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:806:12 [INFO] [stdout] | [INFO] [stdout] 762 | fn new(mut writer: W, compression: Option) -> McapResult { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 790 | let compressor = match compression { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 794 | let mut enc = zstd::Encoder::new(writer, 0)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 805 | let compressor = CountingCrcWriter::new(compressor); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 806 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 807 | | compressor, [INFO] [stdout] 808 | | header_start, [INFO] [stdout] 809 | | stream_start, [INFO] [stdout] ... | [INFO] [stdout] 812 | | indexes: BTreeMap::new(), [INFO] [stdout] 813 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:934:12 [INFO] [stdout] | [INFO] [stdout] 873 | fn finish(self) -> McapResult<(W, records::ChunkIndex)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 877 | let (stream, crc) = self.compressor.finalize(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 881 | let mut writer = stream.finish()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 934 | Ok((writer, index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mcap` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0a02a415375063737cdead27060d74b2cd55db97565e817e0d1d101b03959535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a02a415375063737cdead27060d74b2cd55db97565e817e0d1d101b03959535", kill_on_drop: false }` [INFO] [stdout] 0a02a415375063737cdead27060d74b2cd55db97565e817e0d1d101b03959535