[INFO] fetching crate mc173-server 0.2.0... [INFO] checking mc173-server-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mc173-server 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate mc173-server 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mc173-server 0.2.0 [INFO] finished tweaking crates.io crate mc173-server 0.2.0 [INFO] tweaked toml for crates.io crate mc173-server 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate mc173-server 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 650ee407b8c8b22121e5d44e032f6714d29b7a13b37b610b17234ca981dc7f79 [INFO] running `Command { std: "docker" "start" "-a" "650ee407b8c8b22121e5d44e032f6714d29b7a13b37b610b17234ca981dc7f79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "650ee407b8c8b22121e5d44e032f6714d29b7a13b37b610b17234ca981dc7f79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "650ee407b8c8b22121e5d44e032f6714d29b7a13b37b610b17234ca981dc7f79", kill_on_drop: false }` [INFO] [stdout] 650ee407b8c8b22121e5d44e032f6714d29b7a13b37b610b17234ca981dc7f79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41cc201921efd63495477fe4702e44457e4f622e43fea61f899c61f4e0c01826 [INFO] running `Command { std: "docker" "start" "-a" "41cc201921efd63495477fe4702e44457e4f622e43fea61f899c61f4e0c01826", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking arcstr v1.1.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking mc173 v0.2.0 [INFO] [stderr] Checking tracing-flame v0.2.0 [INFO] [stderr] Checking mc173-server v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 50 | let poll = Poll::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut listener = TcpListener::bind(addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | commands_sender, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | commands_receiver [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | events_sender, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | events_receiver [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let poll_commands_sender = commands_sender.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | commands_sender, [INFO] [stdout] 95 | | events_receiver, [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 398 | fn handle_client_close(&mut self, token: Token, error: Option) -> bool { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let Some(client) = self.clients.remove(&token) else { return true; }; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | let mut stream = client.shared.stream.write().expect("poisoned"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 423 | self.events_sender.send(ThreadEvent::Lost { token, error }).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | let mut inner = World::new(Dimension::Overworld); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | players: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | let mut inner = World::new(Dimension::Overworld); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | state: ServerWorldState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 94 | | name: name.into(), [INFO] [stdout] 95 | | seed, [INFO] [stdout] 96 | | time: 0, [INFO] [stdout] ... | [INFO] [stdout] 104 | | events_count: FadingAverage::default(), [INFO] [stdout] 105 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:330:26 [INFO] [stdout] | [INFO] [stdout] 318 | let mut encoder = ZlibEncoder::new(Vec::new(), Compression::fast()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | compressed_data: Arc::new(encoder.finish().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mc173-server` (bin "mc173-server" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 50 | let poll = Poll::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut listener = TcpListener::bind(addr)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | commands_sender, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | commands_receiver [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | events_sender, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | events_receiver [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let poll_commands_sender = commands_sender.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | commands_sender, [INFO] [stdout] 95 | | events_receiver, [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 398 | fn handle_client_close(&mut self, token: Token, error: Option) -> bool { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let Some(client) = self.clients.remove(&token) else { return true; }; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | let mut stream = client.shared.stream.write().expect("poisoned"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 423 | self.events_sender.send(ThreadEvent::Lost { token, error }).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | let mut inner = World::new(Dimension::Overworld); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | players: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | let mut inner = World::new(Dimension::Overworld); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | state: ServerWorldState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 94 | | name: name.into(), [INFO] [stdout] 95 | | seed, [INFO] [stdout] 96 | | time: 0, [INFO] [stdout] ... | [INFO] [stdout] 104 | | events_count: FadingAverage::default(), [INFO] [stdout] 105 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:330:26 [INFO] [stdout] | [INFO] [stdout] 318 | let mut encoder = ZlibEncoder::new(Vec::new(), Compression::fast()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | compressed_data: Arc::new(encoder.finish().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mc173-server` (bin "mc173-server") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "41cc201921efd63495477fe4702e44457e4f622e43fea61f899c61f4e0c01826", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41cc201921efd63495477fe4702e44457e4f622e43fea61f899c61f4e0c01826", kill_on_drop: false }` [INFO] [stdout] 41cc201921efd63495477fe4702e44457e4f622e43fea61f899c61f4e0c01826