[INFO] fetching crate mc-unified-bookshelf 0.6.5... [INFO] checking mc-unified-bookshelf-0.6.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mc-unified-bookshelf 0.6.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate mc-unified-bookshelf 0.6.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mc-unified-bookshelf 0.6.5 [INFO] finished tweaking crates.io crate mc-unified-bookshelf 0.6.5 [INFO] tweaked toml for crates.io crate mc-unified-bookshelf 0.6.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57cb7039a5eecadfe2a4d147e8a9d17d5df87f6873fbec89cc6b95d3b9270caa [INFO] running `Command { std: "docker" "start" "-a" "57cb7039a5eecadfe2a4d147e8a9d17d5df87f6873fbec89cc6b95d3b9270caa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57cb7039a5eecadfe2a4d147e8a9d17d5df87f6873fbec89cc6b95d3b9270caa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57cb7039a5eecadfe2a4d147e8a9d17d5df87f6873fbec89cc6b95d3b9270caa", kill_on_drop: false }` [INFO] [stdout] 57cb7039a5eecadfe2a4d147e8a9d17d5df87f6873fbec89cc6b95d3b9270caa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a0e7be0c676ce3a1b4e9f571735d89a7fff6d45de3870f80a5dcfe63bf1f5be [INFO] running `Command { std: "docker" "start" "-a" "7a0e7be0c676ce3a1b4e9f571735d89a7fff6d45de3870f80a5dcfe63bf1f5be", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking residua-cesu8 v2.0.0 [INFO] [stderr] Checking residua-mutf8 v2.0.0 [INFO] [stderr] Checking mc-unified-bookshelf v0.6.5 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/mod.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn new_owned(msg: impl Into>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Self { [INFO] [stdout] 130 | inner: Box::new(ErrorInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 131 | | trace: Vec::new(), [INFO] [stdout] 132 | | cause: Cause::Owned(msg.into()), [INFO] [stdout] 133 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/mod.rs:220:20 [INFO] [stdout] | [INFO] [stdout] 218 | fn from(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | Self { [INFO] [stdout] 220 | inner: Box::new(ErrorInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 221 | | trace: Vec::new(), [INFO] [stdout] 222 | | cause: Cause::Io(e), [INFO] [stdout] 223 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/bin/mod.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 28 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let bin_reader = BinReader::::new(reader); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let mut deserializer = de::RootDeserializer::from_reader(bin_reader, has_root_name); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | let d = D::deserialize(&mut deserializer)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | Ok((deserializer.root_name, d)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/bin/de.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 274 | fn next_key_seed>(&mut self, seed: K) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | / seed.deserialize(PayloadDeserializer { [INFO] [stdout] 280 | | reader: self.reader, [INFO] [stdout] 281 | | tag_type: TagType::String, [INFO] [stdout] 282 | | }) [INFO] [stdout] 283 | | .map(Some) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/bin/de.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 290 | fn next_value_seed>(&mut self, seed: V) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | / seed.deserialize(PayloadDeserializer { [INFO] [stdout] 300 | | reader: self.reader, [INFO] [stdout] 301 | | tag_type: self.value_type, [INFO] [stdout] 302 | | }).map_err(|e| match field { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/bin/de.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 319 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant)> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 324 | | seed.deserialize(StrDeserializer::::new(self.variant))?, [INFO] [stdout] 325 | | self, [INFO] [stdout] 326 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/bin/de.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 347 | fn tuple_variant(self, _len: usize, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | Err(Error::new_static( [INFO] [stdout] | _____________^ [INFO] [stdout] 352 | | "Tried to parse internal array enum as a tuple variant" [INFO] [stdout] 353 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/bin/de.rs:360:13 [INFO] [stdout] | [INFO] [stdout] 356 | fn struct_variant(self, _fields: &'static [&'static str], _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Err(Error::new_static( [INFO] [stdout] | _____________^ [INFO] [stdout] 361 | | "Tried to parse internal array enum as a struct variant" [INFO] [stdout] 362 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/tag.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 113 | fn visit_map>(self, map: A) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | visit_map(map).map(Tag::Compound) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nbt/tag.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | fn visit_seq>(self, seq: A) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | ListVisitor.visit_seq(seq).map(Tag::List) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mc-unified-bookshelf` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7a0e7be0c676ce3a1b4e9f571735d89a7fff6d45de3870f80a5dcfe63bf1f5be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a0e7be0c676ce3a1b4e9f571735d89a7fff6d45de3870f80a5dcfe63bf1f5be", kill_on_drop: false }` [INFO] [stdout] 7a0e7be0c676ce3a1b4e9f571735d89a7fff6d45de3870f80a5dcfe63bf1f5be