[INFO] fetching crate max553x 0.3.0... [INFO] checking max553x-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate max553x 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate max553x 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate max553x 0.3.0 [INFO] finished tweaking crates.io crate max553x 0.3.0 [INFO] tweaked toml for crates.io crate max553x 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding embedded-hal-mock v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding num v0.3.1 (latest: v0.4.3) [INFO] [stderr] Adding num-complex v0.3.1 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f93d63ff6bc46b652b5e8109605223a8a7006cb2086df77e6a092285e21bc884 [INFO] running `Command { std: "docker" "start" "-a" "f93d63ff6bc46b652b5e8109605223a8a7006cb2086df77e6a092285e21bc884", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f93d63ff6bc46b652b5e8109605223a8a7006cb2086df77e6a092285e21bc884", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f93d63ff6bc46b652b5e8109605223a8a7006cb2086df77e6a092285e21bc884", kill_on_drop: false }` [INFO] [stdout] f93d63ff6bc46b652b5e8109605223a8a7006cb2086df77e6a092285e21bc884 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6396ee9a5891625f304b0f61fc9f7792797b5ad869179a4a10ba8ce336ab316c [INFO] running `Command { std: "docker" "start" "-a" "6396ee9a5891625f304b0f61fc9f7792797b5ad869179a4a10ba8ce336ab316c", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Checking embedded-hal v1.0.0 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking embedded-hal-nb v1.0.0 [INFO] [stderr] Checking max553x v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn $fn_name(mut self) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.spi.write(&command_bytes($control_bits, 0))?; [INFO] [stdout] 50 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 295 | / impl_max!( [INFO] [stdout] 296 | | /// Struct representing a MAX5532 DAC. [INFO] [stdout] 297 | | Max5532 [INFO] [stdout] 298 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn $fn_name(mut self) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.spi.write(&command_bytes($control_bits, 0))?; [INFO] [stdout] 50 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 295 | / impl_max!( [INFO] [stdout] 296 | | /// Struct representing a MAX5532 DAC. [INFO] [stdout] 297 | | Max5532 [INFO] [stdout] 298 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn $fn_name(mut self, vref: Vref) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.spi.write(&vref_command_bytes($control_bits, vref))?; [INFO] [stdout] 59 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | / impl_max!( [INFO] [stdout] 300 | | /// Struct representing a MAX5533 DAC. [INFO] [stdout] 301 | | Max5533 [INFO] [stdout] 302 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn $fn_name(mut self, vref: Vref) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.spi.write(&vref_command_bytes($control_bits, vref))?; [INFO] [stdout] 59 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | / impl_max!( [INFO] [stdout] 300 | | /// Struct representing a MAX5533 DAC. [INFO] [stdout] 301 | | Max5533 [INFO] [stdout] 302 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn $fn_name(mut self, vref: Vref) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.spi.write(&vref_command_bytes($control_bits, vref))?; [INFO] [stdout] 59 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | / impl_max!( [INFO] [stdout] 300 | | /// Struct representing a MAX5533 DAC. [INFO] [stdout] 301 | | Max5533 [INFO] [stdout] 302 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn $fn_name(mut self) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.spi.write(&command_bytes($control_bits, 0))?; [INFO] [stdout] 50 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 303 | / impl_max!( [INFO] [stdout] 304 | | /// Struct representing a MAX5534 DAC. [INFO] [stdout] 305 | | Max5534 [INFO] [stdout] 306 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn $fn_name(mut self) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.spi.write(&command_bytes($control_bits, 0))?; [INFO] [stdout] 50 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 303 | / impl_max!( [INFO] [stdout] 304 | | /// Struct representing a MAX5534 DAC. [INFO] [stdout] 305 | | Max5534 [INFO] [stdout] 306 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn $fn_name(mut self, vref: Vref) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.spi.write(&vref_command_bytes($control_bits, vref))?; [INFO] [stdout] 59 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 307 | / impl_max!( [INFO] [stdout] 308 | | /// Struct representing a MAX5535 DAC. [INFO] [stdout] 309 | | Max5535 [INFO] [stdout] 310 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn $fn_name(mut self, vref: Vref) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.spi.write(&vref_command_bytes($control_bits, vref))?; [INFO] [stdout] 59 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 307 | / impl_max!( [INFO] [stdout] 308 | | /// Struct representing a MAX5535 DAC. [INFO] [stdout] 309 | | Max5535 [INFO] [stdout] 310 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn $fn_name(mut self, vref: Vref) -> Result<$max_ty, SPI::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.spi.write(&vref_command_bytes($control_bits, vref))?; [INFO] [stdout] 59 | Ok($max_ty { spi: self.spi, _mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 307 | / impl_max!( [INFO] [stdout] 308 | | /// Struct representing a MAX5535 DAC. [INFO] [stdout] 309 | | Max5535 [INFO] [stdout] 310 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_into_mode` which comes from the expansion of the macro `impl_max` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `max553x` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6396ee9a5891625f304b0f61fc9f7792797b5ad869179a4a10ba8ce336ab316c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6396ee9a5891625f304b0f61fc9f7792797b5ad869179a4a10ba8ce336ab316c", kill_on_drop: false }` [INFO] [stdout] 6396ee9a5891625f304b0f61fc9f7792797b5ad869179a4a10ba8ce336ab316c