[INFO] fetching crate max112x 0.7.0... [INFO] checking max112x-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate max112x 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate max112x 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate max112x 0.7.0 [INFO] finished tweaking crates.io crate max112x 0.7.0 [INFO] tweaked toml for crates.io crate max112x 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding embedded-hal-mock v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding num v0.3.1 (latest: v0.4.3) [INFO] [stderr] Adding num-complex v0.3.1 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7ef5465f60aba51f6f176fac9650a49664a8796f29fe9ac121df46396093d12 [INFO] running `Command { std: "docker" "start" "-a" "a7ef5465f60aba51f6f176fac9650a49664a8796f29fe9ac121df46396093d12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7ef5465f60aba51f6f176fac9650a49664a8796f29fe9ac121df46396093d12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7ef5465f60aba51f6f176fac9650a49664a8796f29fe9ac121df46396093d12", kill_on_drop: false }` [INFO] [stdout] a7ef5465f60aba51f6f176fac9650a49664a8796f29fe9ac121df46396093d12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03eb09b56559e4d599b75914bf266ead72921b26d5ec91d80ef1aed2aaff2771 [INFO] running `Command { std: "docker" "start" "-a" "03eb09b56559e4d599b75914bf266ead72921b26d5ec91d80ef1aed2aaff2771", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Checking embedded-hal v1.0.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking embedded-hal-nb v1.0.0 [INFO] [stderr] Checking max112x v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/register.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | $vis struct $Reg(pub(crate) $RegTy); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 254 | / register! { [INFO] [stdout] 255 | | /// 32-bit Data Register (`DATA`) [INFO] [stdout] 256 | | pub struct Data32(u32): 0x6; [INFO] [stdout] | | ------ field in this struct [INFO] [stdout] 257 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `register` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/register.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | $vis struct $Reg(pub(crate) $RegTy); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 264 | / register! { [INFO] [stdout] 265 | | /// SPI System Offset Calibration Register (`SOC_SPI`) [INFO] [stdout] 266 | | pub struct SocSpi(u24): 0x7; [INFO] [stdout] | | ------ field in this struct [INFO] [stdout] 267 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: this warning originates in the macro `register` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/register.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | $vis struct $Reg(pub(crate) $RegTy); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 269 | / register! { [INFO] [stdout] 270 | | /// SPI System Gain Calibration Register (`SGC_SPI`) [INFO] [stdout] 271 | | pub struct SgcSpi(u24): 0x8; [INFO] [stdout] | | ------ field in this struct [INFO] [stdout] 272 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: this warning originates in the macro `register` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/register.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | $vis struct $Reg(pub(crate) $RegTy); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 274 | / register! { [INFO] [stdout] 275 | | /// SPI Self-Cal Offset Calibration Register (`SCOC_SPI`) [INFO] [stdout] 276 | | pub struct ScocSpi(u24): 0x9; [INFO] [stdout] | | ------- field in this struct [INFO] [stdout] 277 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: this warning originates in the macro `register` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/register.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | $vis struct $Reg(pub(crate) $RegTy); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 279 | / register! { [INFO] [stdout] 280 | | /// SPI Self-Cal Gain Calibration Register (`SCGC_SPI`) [INFO] [stdout] 281 | | pub struct ScgcSpi(u24): 0xA; [INFO] [stdout] | | ------- field in this struct [INFO] [stdout] 282 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: this warning originates in the macro `register` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/register.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | $vis struct $Reg(pub(crate) $RegTy); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 284 | / register! { [INFO] [stdout] 285 | | /// Highpass Filter Register (`HPF`) [INFO] [stdout] 286 | | pub struct Hpf(u16): 0xB; [INFO] [stdout] | | --- field in this struct [INFO] [stdout] 287 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: this warning originates in the macro `register` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn into_standby(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Ok(Max11214 { spi: self.spi, mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:119:8 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn into_sleep(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(Max11214 { spi: self.spi, mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 124 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(Max11214 { spi: self.spi, mode: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 163 | fn write_reg_u8(&mut self, reg: R) -> Result<(), Error> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | self.spi.write(&buf).map_err(|err| Error::Spi(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `max112x` (lib) due to 5 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "03eb09b56559e4d599b75914bf266ead72921b26d5ec91d80ef1aed2aaff2771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03eb09b56559e4d599b75914bf266ead72921b26d5ec91d80ef1aed2aaff2771", kill_on_drop: false }` [INFO] [stdout] 03eb09b56559e4d599b75914bf266ead72921b26d5ec91d80ef1aed2aaff2771