[INFO] fetching crate mathcat 0.6.3... [INFO] checking mathcat-0.6.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mathcat 0.6.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate mathcat 0.6.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mathcat 0.6.3 [INFO] finished tweaking crates.io crate mathcat 0.6.3 [INFO] tweaked toml for crates.io crate mathcat 0.6.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate mathcat 0.6.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 309379a000c6077c5b7a1fa072d9490c46401a33b46164cb3c35b8bbe6643206 [INFO] running `Command { std: "docker" "start" "-a" "309379a000c6077c5b7a1fa072d9490c46401a33b46164cb3c35b8bbe6643206", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "309379a000c6077c5b7a1fa072d9490c46401a33b46164cb3c35b8bbe6643206", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "309379a000c6077c5b7a1fa072d9490c46401a33b46164cb3c35b8bbe6643206", kill_on_drop: false }` [INFO] [stdout] 309379a000c6077c5b7a1fa072d9490c46401a33b46164cb3c35b8bbe6643206 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17bd043c49ec651db485e1eeb105cde8b8e9b2377be7456d51a5fcd582d21fc8 [INFO] running `Command { std: "docker" "start" "-a" "17bd043c49ec651db485e1eeb105cde8b8e9b2377be7456d51a5fcd582d21fc8", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling zip v2.1.1 [INFO] [stderr] Compiling gimli v0.29.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling rustc-demangle v0.1.24 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling miniz_oxide v0.7.3 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking peresil v0.3.0 [INFO] [stderr] Checking typed-arena v1.7.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling object v0.35.0 [INFO] [stderr] Checking sxd-document v0.3.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking roman v0.1.6 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking radix_fmt v1.0.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling backtrace v0.3.72 [INFO] [stderr] Checking sxd-xpath v0.4.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling bzip2 v0.4.4 [INFO] [stderr] Compiling addr2line v0.22.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling mathcat v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:797:31 [INFO] [stdout] | [INFO] [stdout] 797 | .map(|(i, r)| Replacement::build(r) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:1820:44 [INFO] [stdout] | [INFO] [stdout] 1820 | .map(|(key,val)| (key.clone(), substitute_ch(val, ch)) ) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:1820:57 [INFO] [stdout] | [INFO] [stdout] 1820 | .map(|(key,val)| (key.clone(), substitute_ch(val, ch)) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:2607:29 [INFO] [stdout] | [INFO] [stdout] 2607 | ... rules_with_context.replace(replacement, mathml) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefs.rs:452:50 [INFO] [stdout] | [INFO] [stdout] 452 | if UNZIPPED_FILES.with( |unzipped_files| unzipped_files.borrow().contains(&zip_file.to_string_lossy().to_string())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefs.rs:463:67 [INFO] [stdout] | [INFO] [stdout] 463 | ... UNZIPPED_FILES.with( |unzipped_files| unzipped_files.borrow_mut().insert(zip_file_string) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefs.rs:477:47 [INFO] [stdout] | [INFO] [stdout] 477 | UNZIPPED_FILES.with( |unzipped_files| unzipped_files.borrow_mut().insert(zip_file_string) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/definitions.rs:144:30 [INFO] [stdout] | [INFO] [stdout] 144 | definitions.with( |defs| defs.borrow_mut().name_to_var_mapping.clear() ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shim_filesystem.rs:215:19 [INFO] [stdout] | [INFO] [stdout] 212 | Err(e) => bail!("Read error while trying to canonicalize in read_to_string_shim {}: {}", path.display(), e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match std::fs::read_to_string(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mathcat` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:47 [INFO] [stdout] | [INFO] [stdout] 93 | crate::speech::SPEECH_RULES.with(|rules| rules.borrow_mut().read_files().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/infer_intent.rs:452:15 [INFO] [stdout] | [INFO] [stdout] 446 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | match is_same_element(&result, &target) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:797:31 [INFO] [stdout] | [INFO] [stdout] 797 | .map(|(i, r)| Replacement::build(r) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:1820:44 [INFO] [stdout] | [INFO] [stdout] 1820 | .map(|(key,val)| (key.clone(), substitute_ch(val, ch)) ) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:1820:57 [INFO] [stdout] | [INFO] [stdout] 1820 | .map(|(key,val)| (key.clone(), substitute_ch(val, ch)) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speech.rs:2607:29 [INFO] [stdout] | [INFO] [stdout] 2607 | ... rules_with_context.replace(replacement, mathml) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefs.rs:452:50 [INFO] [stdout] | [INFO] [stdout] 452 | if UNZIPPED_FILES.with( |unzipped_files| unzipped_files.borrow().contains(&zip_file.to_string_lossy().to_string())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefs.rs:463:67 [INFO] [stdout] | [INFO] [stdout] 463 | ... UNZIPPED_FILES.with( |unzipped_files| unzipped_files.borrow_mut().insert(zip_file_string) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prefs.rs:477:47 [INFO] [stdout] | [INFO] [stdout] 477 | UNZIPPED_FILES.with( |unzipped_files| unzipped_files.borrow_mut().insert(zip_file_string) ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/definitions.rs:144:30 [INFO] [stdout] | [INFO] [stdout] 144 | definitions.with( |defs| defs.borrow_mut().name_to_var_mapping.clear() ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shim_filesystem.rs:215:19 [INFO] [stdout] | [INFO] [stdout] 212 | Err(e) => bail!("Read error while trying to canonicalize in read_to_string_shim {}: {}", path.display(), e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match std::fs::read_to_string(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mathcat` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "17bd043c49ec651db485e1eeb105cde8b8e9b2377be7456d51a5fcd582d21fc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17bd043c49ec651db485e1eeb105cde8b8e9b2377be7456d51a5fcd582d21fc8", kill_on_drop: false }` [INFO] [stdout] 17bd043c49ec651db485e1eeb105cde8b8e9b2377be7456d51a5fcd582d21fc8