[INFO] fetching crate maroon 0.1.0... [INFO] checking maroon-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate maroon 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate maroon 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate maroon 0.1.0 [INFO] finished tweaking crates.io crate maroon 0.1.0 [INFO] tweaked toml for crates.io crate maroon 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate maroon 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d2e3d6f84c1aad4b836570c537480ab620529e1416ad827fb345615a7d478ed [INFO] running `Command { std: "docker" "start" "-a" "6d2e3d6f84c1aad4b836570c537480ab620529e1416ad827fb345615a7d478ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d2e3d6f84c1aad4b836570c537480ab620529e1416ad827fb345615a7d478ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d2e3d6f84c1aad4b836570c537480ab620529e1416ad827fb345615a7d478ed", kill_on_drop: false }` [INFO] [stdout] 6d2e3d6f84c1aad4b836570c537480ab620529e1416ad827fb345615a7d478ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57248db0607c63e01f1cfc6d2049392c92a0a93b73c5427d68d41179da7d561d [INFO] running `Command { std: "docker" "start" "-a" "57248db0607c63e01f1cfc6d2049392c92a0a93b73c5427d68d41179da7d561d", kill_on_drop: false }` [INFO] [stderr] Checking maroon v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/parser.rs:114:3 [INFO] [stdout] | [INFO] [stdout] 101 | / loop { [INFO] [stdout] 102 | | match tokens.peek() { [INFO] [stdout] 103 | | Some(Token::CBRACKET(line)) => { [INFO] [stdout] 104 | | tokens.next(); [INFO] [stdout] ... | [INFO] [stdout] 112 | | }; [INFO] [stdout] 113 | | } [INFO] [stdout] | |___- any code following this expression is unreachable [INFO] [stdout] 114 | Err(ParseError::Unknown(2)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/parser.rs:133:3 [INFO] [stdout] | [INFO] [stdout] 120 | / loop { [INFO] [stdout] 121 | | match tokens.peek() { [INFO] [stdout] 122 | | Some(Token::CPAREN(line)) => { [INFO] [stdout] 123 | | tokens.next(); [INFO] [stdout] ... | [INFO] [stdout] 131 | | }; [INFO] [stdout] 132 | | } [INFO] [stdout] | |___- any code following this expression is unreachable [INFO] [stdout] 133 | Err(ParseError::Unknown(3)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/parser.rs:114:3 [INFO] [stdout] | [INFO] [stdout] 101 | / loop { [INFO] [stdout] 102 | | match tokens.peek() { [INFO] [stdout] 103 | | Some(Token::CBRACKET(line)) => { [INFO] [stdout] 104 | | tokens.next(); [INFO] [stdout] ... | [INFO] [stdout] 112 | | }; [INFO] [stdout] 113 | | } [INFO] [stdout] | |___- any code following this expression is unreachable [INFO] [stdout] 114 | Err(ParseError::Unknown(2)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/parser.rs:133:3 [INFO] [stdout] | [INFO] [stdout] 120 | / loop { [INFO] [stdout] 121 | | match tokens.peek() { [INFO] [stdout] 122 | | Some(Token::CPAREN(line)) => { [INFO] [stdout] 123 | | tokens.next(); [INFO] [stdout] ... | [INFO] [stdout] 131 | | }; [INFO] [stdout] 132 | | } [INFO] [stdout] | |___- any code following this expression is unreachable [INFO] [stdout] 133 | Err(ParseError::Unknown(3)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fndec` [INFO] [stdout] --> src/parser.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 151 | let fndec = stmt[0].clone(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_fndec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `builtins` is never used [INFO] [stdout] --> src/parser.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const builtins: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fndec` [INFO] [stdout] --> src/parser.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 151 | let fndec = stmt[0].clone(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_fndec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `keywords` should have an upper case name [INFO] [stdout] --> src/parser.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const keywords: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `KEYWORDS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `builtins` should have an upper case name [INFO] [stdout] --> src/parser.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const builtins: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BUILTINS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:71:6 [INFO] [stdout] | [INFO] [stdout] 61 | let mut sexprs: Vec> = vec![]; // top-level s-expressions [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Module(sexprs)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:94:6 [INFO] [stdout] | [INFO] [stdout] 77 | let sexpr = {match tokens.next() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(first_analysis(sexpr)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `builtins` is never used [INFO] [stdout] --> src/parser.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const builtins: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `keywords` should have an upper case name [INFO] [stdout] --> src/parser.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const keywords: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `KEYWORDS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `builtins` should have an upper case name [INFO] [stdout] --> src/parser.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const builtins: &'static [&'static str] = &[ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BUILTINS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:71:6 [INFO] [stdout] | [INFO] [stdout] 61 | let mut sexprs: Vec> = vec![]; // top-level s-expressions [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(Module(sexprs)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:94:6 [INFO] [stdout] | [INFO] [stdout] 77 | let sexpr = {match tokens.next() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(first_analysis(sexpr)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `maroon` (bin "maroon") due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `maroon` (bin "maroon" test) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "57248db0607c63e01f1cfc6d2049392c92a0a93b73c5427d68d41179da7d561d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57248db0607c63e01f1cfc6d2049392c92a0a93b73c5427d68d41179da7d561d", kill_on_drop: false }` [INFO] [stdout] 57248db0607c63e01f1cfc6d2049392c92a0a93b73c5427d68d41179da7d561d