[INFO] fetching crate mapiproxy 0.6.2... [INFO] checking mapiproxy-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mapiproxy 0.6.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mapiproxy 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mapiproxy 0.6.2 [INFO] finished tweaking crates.io crate mapiproxy 0.6.2 [INFO] tweaked toml for crates.io crate mapiproxy 0.6.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate mapiproxy 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd2ec039dd1ef6486a6e20d711ec9a3f2494bdfcbef61f41a8d99a2f4a404152 [INFO] running `Command { std: "docker" "start" "-a" "bd2ec039dd1ef6486a6e20d711ec9a3f2494bdfcbef61f41a8d99a2f4a404152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd2ec039dd1ef6486a6e20d711ec9a3f2494bdfcbef61f41a8d99a2f4a404152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd2ec039dd1ef6486a6e20d711ec9a3f2494bdfcbef61f41a8d99a2f4a404152", kill_on_drop: false }` [INFO] [stdout] bd2ec039dd1ef6486a6e20d711ec9a3f2494bdfcbef61f41a8d99a2f4a404152 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60a586db1c7a1e68e518612593275904ed714679b2350a9fa5606f60cb973db8 [INFO] running `Command { std: "docker" "start" "-a" "60a586db1c7a1e68e518612593275904ed714679b2350a9fa5606f60cb973db8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling mapiproxy v0.6.2 (/opt/rustwide/workdir) [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking byteorder_slice v3.0.0 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking etherparse v0.14.2 [INFO] [stderr] Checking argsplitter v0.5.0 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling derive-into-owned v0.2.0 [INFO] [stderr] Checking ctrlc v3.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking pcap-file v2.0.0 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.1.0 [INFO] [stderr] Checking lazy-regex v3.1.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/x.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 107 | fn read_filex(path: impl AsRef) -> AResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let path = path.as_ref(); [INFO] [stdout] 109 | fs::read_to_string(path).with_context(|| format!("Could not read {}", path.display())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | use std::panic::PanicInfo; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mapiproxy` (example "x") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:190:47 [INFO] [stdout] | [INFO] [stdout] 190 | let my_hook = Box::new(move |panic_info: &PanicInfo<'_>| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | use std::panic::PanicInfo; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:190:47 [INFO] [stdout] | [INFO] [stdout] 190 | let my_hook = Box::new(move |panic_info: &PanicInfo<'_>| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `peer` is never read [INFO] [stdout] --> src/event.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | Connected { id: ConnectionId, peer: Addr }, [INFO] [stdout] | --------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MapiEvent` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:148:27 [INFO] [stdout] | [INFO] [stdout] 146 | let mut proxy = Proxy::new(listen_addr, forward_addr, handler)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | install_ctrl_c_handler(proxy.get_shutdown_trigger())?; [INFO] [stdout] 148 | thread::spawn(move || proxy.run().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/addr.rs:138:16 [INFO] [stdout] | [INFO] [stdout] 137 | fn gather(a: T) -> io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Ok(a.to_socket_addrs()?.map(Addr::Tcp).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn new(f: impl FnMut(MapiEvent) + 'static + Send) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | EventSink(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 182 | let waker = Arc::clone(&self.waker); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Box::new(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 184 | | if let Err(e) = waker.wake() { [INFO] [stdout] 185 | | eprintln!("Failed to shut down the proxy: {e}"); [INFO] [stdout] 186 | | } [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mapiproxy` (bin "mapiproxy" test) due to 5 previous errors; 3 warnings emitted [INFO] [stdout] warning: field `peer` is never read [INFO] [stdout] --> src/event.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 87 | Connected { id: ConnectionId, peer: Addr }, [INFO] [stdout] | --------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MapiEvent` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:148:27 [INFO] [stdout] | [INFO] [stdout] 146 | let mut proxy = Proxy::new(listen_addr, forward_addr, handler)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | install_ctrl_c_handler(proxy.get_shutdown_trigger())?; [INFO] [stdout] 148 | thread::spawn(move || proxy.run().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/addr.rs:138:16 [INFO] [stdout] | [INFO] [stdout] 137 | fn gather(a: T) -> io::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Ok(a.to_socket_addrs()?.map(Addr::Tcp).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn new(f: impl FnMut(MapiEvent) + 'static + Send) -> Self { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | EventSink(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy/mod.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 182 | let waker = Arc::clone(&self.waker); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Box::new(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 184 | | if let Err(e) = waker.wake() { [INFO] [stdout] 185 | | eprintln!("Failed to shut down the proxy: {e}"); [INFO] [stdout] 186 | | } [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mapiproxy` (bin "mapiproxy") due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "60a586db1c7a1e68e518612593275904ed714679b2350a9fa5606f60cb973db8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60a586db1c7a1e68e518612593275904ed714679b2350a9fa5606f60cb973db8", kill_on_drop: false }` [INFO] [stdout] 60a586db1c7a1e68e518612593275904ed714679b2350a9fa5606f60cb973db8