[INFO] fetching crate map-parser 0.1.5... [INFO] checking map-parser-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate map-parser 0.1.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate map-parser 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate map-parser 0.1.5 [INFO] finished tweaking crates.io crate map-parser 0.1.5 [INFO] tweaked toml for crates.io crate map-parser 0.1.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding password-hash v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding pbkdf2 v0.11.0 (latest: v0.12.2) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] [stderr] Adding zstd v0.11.2+zstd.1.5.2 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v5.0.2+zstd.1.5.2 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19b0c9627c72139774e2b8d703bbea8785a61dfca25c5bb25bd536107984d6d4 [INFO] running `Command { std: "docker" "start" "-a" "19b0c9627c72139774e2b8d703bbea8785a61dfca25c5bb25bd536107984d6d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19b0c9627c72139774e2b8d703bbea8785a61dfca25c5bb25bd536107984d6d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19b0c9627c72139774e2b8d703bbea8785a61dfca25c5bb25bd536107984d6d4", kill_on_drop: false }` [INFO] [stdout] 19b0c9627c72139774e2b8d703bbea8785a61dfca25c5bb25bd536107984d6d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b4a9d5784f289dbf4a69bb7762ca296021156b049a5aecc6885aa1d65a0c3dd [INFO] running `Command { std: "docker" "start" "-a" "4b4a9d5784f289dbf4a69bb7762ca296021156b049a5aecc6885aa1d65a0c3dd", kill_on_drop: false }` [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking map-parser v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `custom_audio_sample_index` is never used [INFO] [stdout] --> src/maps/osu.rs:409:8 [INFO] [stdout] | [INFO] [stdout] 74 | impl OsuBeatmap { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 409 | fn custom_audio_sample_index(&mut self, path: &str) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maps/osu.rs:433:12 [INFO] [stdout] | [INFO] [stdout] 428 | fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 432 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Circle` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 440 | const Circle = 1 << 0; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `CIRCLE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Slider` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:441:15 [INFO] [stdout] | [INFO] [stdout] 441 | const Slider = 1 << 1; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `SLIDER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `NewCombo` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:442:15 [INFO] [stdout] | [INFO] [stdout] 442 | const NewCombo = 1 << 2; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `NEW_COMBO` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Spinner` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:443:15 [INFO] [stdout] | [INFO] [stdout] 443 | const Spinner = 1 << 3; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `SPINNER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `ComboOffset` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:444:15 [INFO] [stdout] | [INFO] [stdout] 444 | const ComboOffset = 1 << 4 | 1 << 5 | 1 << 6; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `COMBO_OFFSET` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Hold` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:445:15 [INFO] [stdout] | [INFO] [stdout] 445 | const Hold = 1 << 7; [INFO] [stdout] | ^^^^ help: convert the identifier to upper case: `HOLD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `None` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:452:15 [INFO] [stdout] | [INFO] [stdout] 452 | const None = 0; [INFO] [stdout] | ^^^^ help: convert the identifier to upper case: `NONE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Normal` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:453:15 [INFO] [stdout] | [INFO] [stdout] 453 | const Normal = 1; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `NORMAL` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Whistle` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:454:15 [INFO] [stdout] | [INFO] [stdout] 454 | const Whistle = 2; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `WHISTLE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Finish` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:455:15 [INFO] [stdout] | [INFO] [stdout] 455 | const Finish = 4; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `FINISH` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Clap` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:456:15 [INFO] [stdout] | [INFO] [stdout] 456 | const Clap = 8; [INFO] [stdout] | ^^^^ help: convert the identifier to upper case: `CLAP` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maps/qua.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | let file = std::fs::File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | serde_yaml::from_reader(file).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `map-parser` (lib test) due to 3 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `custom_audio_sample_index` is never used [INFO] [stdout] --> src/maps/osu.rs:409:8 [INFO] [stdout] | [INFO] [stdout] 74 | impl OsuBeatmap { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 409 | fn custom_audio_sample_index(&mut self, path: &str) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maps/osu.rs:433:12 [INFO] [stdout] | [INFO] [stdout] 428 | fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 432 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Circle` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 440 | const Circle = 1 << 0; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `CIRCLE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Slider` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:441:15 [INFO] [stdout] | [INFO] [stdout] 441 | const Slider = 1 << 1; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `SLIDER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `NewCombo` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:442:15 [INFO] [stdout] | [INFO] [stdout] 442 | const NewCombo = 1 << 2; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `NEW_COMBO` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Spinner` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:443:15 [INFO] [stdout] | [INFO] [stdout] 443 | const Spinner = 1 << 3; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `SPINNER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `ComboOffset` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:444:15 [INFO] [stdout] | [INFO] [stdout] 444 | const ComboOffset = 1 << 4 | 1 << 5 | 1 << 6; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `COMBO_OFFSET` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Hold` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:445:15 [INFO] [stdout] | [INFO] [stdout] 445 | const Hold = 1 << 7; [INFO] [stdout] | ^^^^ help: convert the identifier to upper case: `HOLD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `None` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:452:15 [INFO] [stdout] | [INFO] [stdout] 452 | const None = 0; [INFO] [stdout] | ^^^^ help: convert the identifier to upper case: `NONE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Normal` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:453:15 [INFO] [stdout] | [INFO] [stdout] 453 | const Normal = 1; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `NORMAL` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Whistle` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:454:15 [INFO] [stdout] | [INFO] [stdout] 454 | const Whistle = 2; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `WHISTLE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Finish` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:455:15 [INFO] [stdout] | [INFO] [stdout] 455 | const Finish = 4; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `FINISH` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `Clap` should have an upper case name [INFO] [stdout] --> src/maps/osu.rs:456:15 [INFO] [stdout] | [INFO] [stdout] 456 | const Clap = 8; [INFO] [stdout] | ^^^^ help: convert the identifier to upper case: `CLAP` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maps/qua.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | let file = std::fs::File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | serde_yaml::from_reader(file).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `map-parser` (lib) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4b4a9d5784f289dbf4a69bb7762ca296021156b049a5aecc6885aa1d65a0c3dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b4a9d5784f289dbf4a69bb7762ca296021156b049a5aecc6885aa1d65a0c3dd", kill_on_drop: false }` [INFO] [stdout] 4b4a9d5784f289dbf4a69bb7762ca296021156b049a5aecc6885aa1d65a0c3dd