[INFO] fetching crate manual_rwlock 0.4.0... [INFO] checking manual_rwlock-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate manual_rwlock 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate manual_rwlock 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate manual_rwlock 0.4.0 [INFO] finished tweaking crates.io crate manual_rwlock 0.4.0 [INFO] tweaked toml for crates.io crate manual_rwlock 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate manual_rwlock 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2a57b64e80e8661753ae8a3e2b80b4eae8255a7ce700acb0835c7fa20c7eac8 [INFO] running `Command { std: "docker" "start" "-a" "c2a57b64e80e8661753ae8a3e2b80b4eae8255a7ce700acb0835c7fa20c7eac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2a57b64e80e8661753ae8a3e2b80b4eae8255a7ce700acb0835c7fa20c7eac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2a57b64e80e8661753ae8a3e2b80b4eae8255a7ce700acb0835c7fa20c7eac8", kill_on_drop: false }` [INFO] [stdout] c2a57b64e80e8661753ae8a3e2b80b4eae8255a7ce700acb0835c7fa20c7eac8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42a756d2668b7a23db6c64999d569ca7724839a53c32a3b9e3e4797913aac59b [INFO] running `Command { std: "docker" "start" "-a" "42a756d2668b7a23db6c64999d569ca7724839a53c32a3b9e3e4797913aac59b", kill_on_drop: false }` [INFO] [stderr] Checking atomic-wait v1.1.0 [INFO] [stderr] Checking manual_rwlock v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn new(data: T) -> MrwLock { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | data: UnsafeCell::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | self.state.try_to_write()?; [INFO] [stdout] 14 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | state: &self.state, [INFO] [stdout] 16 | | data: self.data, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.state.to_write()?; [INFO] [stdout] 31 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | state: &self.state, [INFO] [stdout] 33 | | data: self.data, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | self.state.try_to_write()?; [INFO] [stdout] 25 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | state: &self.state, [INFO] [stdout] 27 | | data: self.data, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.state.to_write()?; [INFO] [stdout] 33 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | state: &self.state, [INFO] [stdout] 35 | | data: self.data, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn new(data: T) -> MrwLock { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | data: UnsafeCell::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | self.state.try_to_write()?; [INFO] [stdout] 14 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | state: &self.state, [INFO] [stdout] 16 | | data: self.data, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_gaurd.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.state.to_write()?; [INFO] [stdout] 31 | Ok(WriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | state: &self.state, [INFO] [stdout] 33 | | data: self.data, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn try_to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | self.state.try_to_write()?; [INFO] [stdout] 25 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | state: &self.state, [INFO] [stdout] 27 | | data: self.data, [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_read_gaurd.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_write(self) -> LockResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.state.to_write()?; [INFO] [stdout] 33 | Ok(SliceWriteGaurd { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | state: &self.state, [INFO] [stdout] 35 | | data: self.data, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `manual_rwlock` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `manual_rwlock` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "42a756d2668b7a23db6c64999d569ca7724839a53c32a3b9e3e4797913aac59b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42a756d2668b7a23db6c64999d569ca7724839a53c32a3b9e3e4797913aac59b", kill_on_drop: false }` [INFO] [stdout] 42a756d2668b7a23db6c64999d569ca7724839a53c32a3b9e3e4797913aac59b