[INFO] fetching crate mani 0.4.0... [INFO] checking mani-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate mani 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate mani 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mani 0.4.0 [INFO] finished tweaking crates.io crate mani 0.4.0 [INFO] tweaked toml for crates.io crate mani 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate mani 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f9e57d2b231c0178035928bc002dafbd6c244af8b2bf1faf8036d1801b6575f [INFO] running `Command { std: "docker" "start" "-a" "9f9e57d2b231c0178035928bc002dafbd6c244af8b2bf1faf8036d1801b6575f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f9e57d2b231c0178035928bc002dafbd6c244af8b2bf1faf8036d1801b6575f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f9e57d2b231c0178035928bc002dafbd6c244af8b2bf1faf8036d1801b6575f", kill_on_drop: false }` [INFO] [stdout] 9f9e57d2b231c0178035928bc002dafbd6c244af8b2bf1faf8036d1801b6575f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a66b24ff66f68e42c2a9b80a9f4e5ae779af79cec17c7eb1dbc8cf2f392975ad [INFO] running `Command { std: "docker" "start" "-a" "a66b24ff66f68e42c2a9b80a9f4e5ae779af79cec17c7eb1dbc8cf2f392975ad", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling buffertk v0.8.0 [INFO] [stderr] Checking zerror v0.5.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling libc v0.2.157 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking biometrics v0.8.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking utilz v0.5.0 [INFO] [stderr] Compiling derive_util v0.4.0 [INFO] [stderr] Compiling prototk_derive v0.8.0 [INFO] [stderr] Compiling arrrg_derive v0.4.0 [INFO] [stderr] Compiling zerror_derive v0.4.0 [INFO] [stderr] Checking arrrg v0.4.0 [INFO] [stderr] Checking guacamole v0.8.0 [INFO] [stderr] Checking prototk v0.8.0 [INFO] [stderr] Checking armnod v0.7.0 [INFO] [stderr] Checking one_two_eight v0.5.0 [INFO] [stderr] Checking tatl v0.7.0 [INFO] [stderr] Checking zerror_core v0.7.0 [INFO] [stderr] Checking mani v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:19 [INFO] [stdout] | [INFO] [stdout] 179 | fn from(what: std::io::Error) -> Error { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Error::SystemError { [INFO] [stdout] 181 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:15 [INFO] [stdout] | [INFO] [stdout] 520 | fn read_first_edit>(path: P) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | let mut iter = ManifestIterator::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | match iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 615 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | let file = Some(BufReader::new(File::open(path)?)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 629 | Ok(Self { file, poison: None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:636:14 [INFO] [stdout] | [INFO] [stdout] 632 | fn poison>(&mut self, err: E) -> Option> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 633 | let err = err.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | Some(Err(err)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mani` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:19 [INFO] [stdout] | [INFO] [stdout] 179 | fn from(what: std::io::Error) -> Error { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Error::SystemError { [INFO] [stdout] 181 | core: ErrorCore::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:15 [INFO] [stdout] | [INFO] [stdout] 520 | fn read_first_edit>(path: P) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | let mut iter = ManifestIterator::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | match iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 615 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | let file = Some(BufReader::new(File::open(path)?)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 629 | Ok(Self { file, poison: None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:636:14 [INFO] [stdout] | [INFO] [stdout] 632 | fn poison>(&mut self, err: E) -> Option> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 633 | let err = err.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | Some(Err(err)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mani` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "a66b24ff66f68e42c2a9b80a9f4e5ae779af79cec17c7eb1dbc8cf2f392975ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a66b24ff66f68e42c2a9b80a9f4e5ae779af79cec17c7eb1dbc8cf2f392975ad", kill_on_drop: false }` [INFO] [stdout] a66b24ff66f68e42c2a9b80a9f4e5ae779af79cec17c7eb1dbc8cf2f392975ad