[INFO] fetching crate makeup 0.0.8... [INFO] checking makeup-0.0.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate makeup 0.0.8 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate makeup 0.0.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate makeup 0.0.8 [INFO] finished tweaking crates.io crate makeup 0.0.8 [INFO] tweaked toml for crates.io crate makeup 0.0.8 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate makeup 0.0.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eaae0cff26f58fcb7981304439cc43f7754e809a80d8c1f5eaeb5df34984e4c3 [INFO] running `Command { std: "docker" "start" "-a" "eaae0cff26f58fcb7981304439cc43f7754e809a80d8c1f5eaeb5df34984e4c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eaae0cff26f58fcb7981304439cc43f7754e809a80d8c1f5eaeb5df34984e4c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaae0cff26f58fcb7981304439cc43f7754e809a80d8c1f5eaeb5df34984e4c3", kill_on_drop: false }` [INFO] [stdout] eaae0cff26f58fcb7981304439cc43f7754e809a80d8c1f5eaeb5df34984e4c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad3394e08aa5fbc1dd6b828a9ef4673cca9b974152dad926f687f163ffacc2a7 [INFO] running `Command { std: "docker" "start" "-a" "ad3394e08aa5fbc1dd6b828a9ef4673cca9b974152dad926f687f163ffacc2a7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling syn v1.0.103 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling parking_lot_core v0.9.4 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling rustversion v1.0.13 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling eyre v0.6.11 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling phf_shared v0.11.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling async-trait v0.1.75 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking grid v0.10.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking makeup-ansi v0.0.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling phf_generator v0.11.1 [INFO] [stderr] Compiling syn v2.0.42 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.14.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking taffy v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling phf_macros v0.11.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling strum_macros v0.25.1 [INFO] [stderr] Compiling makeup-macros v0.0.2 [INFO] [stderr] Checking phf v0.11.1 [INFO] [stderr] Checking csscolorparser v0.6.2 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking colorgrad v0.6.2 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking makeup-console v0.0.7 [INFO] [stderr] Checking makeup v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 53 | sender: ContextTx, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | sender: MessageSender::new(sender, focus), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | renderer: Box, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | input: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result { [INFO] [stdout] 66 | let (input_tx, input_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | ui: Arc::new(Mutex::new(UI::new(root, renderer.dimensions())?)), [INFO] [stdout] 70 | | renderer: Arc::new(RwLock::new(renderer)), [INFO] [stdout] 71 | | input_tx, [INFO] [stdout] ... | [INFO] [stdout] 74 | | done: Arc::new(Mutex::new(false)), [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:413:12 [INFO] [stdout] | [INFO] [stdout] 410 | let mut taffy = Taffy::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 414 | | root, [INFO] [stdout] 415 | | post_office: Arc::new(RwLock::new(PostOffice::new())), [INFO] [stdout] 416 | | focus: focus_key, [INFO] [stdout] ... | [INFO] [stdout] 420 | | _phantom: std::marker::PhantomData, [INFO] [stdout] 421 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `makeup` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 53 | sender: ContextTx, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | sender: MessageSender::new(sender, focus), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | renderer: Box, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | input: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result { [INFO] [stdout] 66 | let (input_tx, input_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | ui: Arc::new(Mutex::new(UI::new(root, renderer.dimensions())?)), [INFO] [stdout] 70 | | renderer: Arc::new(RwLock::new(renderer)), [INFO] [stdout] 71 | | input_tx, [INFO] [stdout] ... | [INFO] [stdout] 74 | | done: Arc::new(Mutex::new(false)), [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:413:12 [INFO] [stdout] | [INFO] [stdout] 410 | let mut taffy = Taffy::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 414 | | root, [INFO] [stdout] 415 | | post_office: Arc::new(RwLock::new(PostOffice::new())), [INFO] [stdout] 416 | | focus: focus_key, [INFO] [stdout] ... | [INFO] [stdout] 420 | | _phantom: std::marker::PhantomData, [INFO] [stdout] 421 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `makeup` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ad3394e08aa5fbc1dd6b828a9ef4673cca9b974152dad926f687f163ffacc2a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad3394e08aa5fbc1dd6b828a9ef4673cca9b974152dad926f687f163ffacc2a7", kill_on_drop: false }` [INFO] [stdout] ad3394e08aa5fbc1dd6b828a9ef4673cca9b974152dad926f687f163ffacc2a7