[INFO] fetching crate makepad-hub 0.1.0... [INFO] checking makepad-hub-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate makepad-hub 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate makepad-hub 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate makepad-hub 0.1.0 [INFO] finished tweaking crates.io crate makepad-hub 0.1.0 [INFO] tweaked toml for crates.io crate makepad-hub 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.10.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding byteorder v0.5.3 (latest: v1.5.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding ron v0.5.1 (latest: v0.8.1) [INFO] [stderr] Adding snap v0.1.2 (latest: v1.1.1) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01fa254c4229e89e57705cc9f6521ddc960c6c531dd12d5c327a7cec7507eaf1 [INFO] running `Command { std: "docker" "start" "-a" "01fa254c4229e89e57705cc9f6521ddc960c6c531dd12d5c327a7cec7507eaf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01fa254c4229e89e57705cc9f6521ddc960c6c531dd12d5c327a7cec7507eaf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01fa254c4229e89e57705cc9f6521ddc960c6c531dd12d5c327a7cec7507eaf1", kill_on_drop: false }` [INFO] [stdout] 01fa254c4229e89e57705cc9f6521ddc960c6c531dd12d5c327a7cec7507eaf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66e54564676dd2919389c6d27b958939d1502618a35ce26a6463a3fdfe8d4759 [INFO] running `Command { std: "docker" "start" "-a" "66e54564676dd2919389c6d27b958939d1502618a35ce26a6463a3fdfe8d4759", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking snap v0.1.2 [INFO] [stderr] Checking ron v0.5.1 [INFO] [stderr] Checking makepad-hub v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:393:11 [INFO] [stdout] | [INFO] [stdout] 393 | #[cfg(not(feature = "no_unroll"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:404:7 [INFO] [stdout] | [INFO] [stdout] 404 | #[cfg(feature = "no_unroll")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:411:11 [INFO] [stdout] | [INFO] [stdout] 411 | #[cfg(not(feature = "no_unroll"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:441:7 [INFO] [stdout] | [INFO] [stdout] 441 | #[cfg(feature = "no_unroll")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:393:11 [INFO] [stdout] | [INFO] [stdout] 393 | #[cfg(not(feature = "no_unroll"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:404:7 [INFO] [stdout] | [INFO] [stdout] 404 | #[cfg(feature = "no_unroll")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:411:11 [INFO] [stdout] | [INFO] [stdout] 411 | #[cfg(not(feature = "no_unroll"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_unroll` [INFO] [stdout] --> src/hubclient.rs:441:7 [INFO] [stdout] | [INFO] [stdout] 441 | #[cfg(feature = "no_unroll")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `no_unroll` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `kind`, `crate_types`, `name`, `src_path`, and `edition` are never read [INFO] [stdout] --> src/hubbuilder.rs:1137:5 [INFO] [stdout] | [INFO] [stdout] 1136 | pub struct RustcTarget { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 1137 | kind: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1138 | crate_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 1139 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1140 | src_path: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 1141 | edition: String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcTarget` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `text`, `highlight_start`, and `highlight_end` are never read [INFO] [stdout] --> src/hubbuilder.rs:1146:5 [INFO] [stdout] | [INFO] [stdout] 1145 | pub struct RustcText { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 1146 | text: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1147 | highlight_start: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 1148 | highlight_end: u32 [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcText` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/hubbuilder.rs:1157:5 [INFO] [stdout] | [INFO] [stdout] 1152 | pub struct RustcSpan { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 1157 | line_end: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 1158 | column_start: u32, [INFO] [stdout] 1159 | column_end: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 1160 | is_primary: bool, [INFO] [stdout] 1161 | text: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1162 | label: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 1163 | suggested_replacement: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 1164 | sugggested_applicability: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 1165 | expansion: Option>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 1166 | level: Option [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcSpan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `span`, `macro_decl_name`, and `def_site_span` are never read [INFO] [stdout] --> src/hubbuilder.rs:1171:5 [INFO] [stdout] | [INFO] [stdout] 1170 | pub struct RustcExpansion { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 1171 | span: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1172 | macro_decl_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 1173 | def_site_span: Option [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcExpansion` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/hubbuilder.rs:1178:5 [INFO] [stdout] | [INFO] [stdout] 1177 | pub struct RustcCode { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 1178 | code: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcCode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `opt_level`, `debuginfo`, `debug_assertions`, `overflow_checks`, and `test` are never read [INFO] [stdout] --> src/hubbuilder.rs:1194:5 [INFO] [stdout] | [INFO] [stdout] 1193 | pub struct RustcProfile { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 1194 | opt_level: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 1195 | debuginfo: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 1196 | debug_assertions: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 1197 | overflow_checks: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 1198 | test: bool [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcProfile` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `reason`, `target`, `profile`, and `features` are never read [INFO] [stdout] --> src/hubbuilder.rs:1203:5 [INFO] [stdout] | [INFO] [stdout] 1202 | pub struct RustcCompilerMessage { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 1203 | reason: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 1204 | package_id: String, [INFO] [stdout] 1205 | target: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 1206 | message: Option, [INFO] [stdout] 1207 | profile: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 1208 | features: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcCompilerMessage` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/wasmstrip.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 74 | struct WasmSection{ [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 78 | pub name: String [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubui.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn start_hub_ui_direct(hub_router:&mut HubRouter,event_handler: F)->HubUI [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let (tx_write, rx_write) = mpsc::channel::(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let htc_msgs_arc = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let route_send = hub_router.connect_direct(HubRouteType::UI, tx_write); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | let thread = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let htc_msgs_arc = Arc::clone(&htc_msgs_arc); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let route_send = route_send.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let event_handler = event_handler.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubui.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 61 | let route_send = HubRouteSend::Networked{ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let htc_msgs_arc = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let thread = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let htc_msgs_arc = Arc::clone(&htc_msgs_arc); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let hub_log = hub_log.clone(); [INFO] [stdout] 73 | let event_handler = event_handler.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 34 | let mut child = create_process(cmd, args, current_dir, env) ?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | let (tx_line, rx_line) = mpsc::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let tx_err = tx_line.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut stdout = child.stdout.take().expect("stdout cannot be taken!"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut stderr = child.stderr.take().expect("stderr cannot be taken!"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | let _stdout_thread = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let _stderr_thread = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Process { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | child: Some(child), [INFO] [stdout] 98 | | rx_line: Some(rx_line), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubclient.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 140 | let mut tcp_stream = if let Ok(stream) = TcpStream::connect(local_address) { [INFO] [stdout] | ---------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let (tx_read, rx_read) = mpsc::channel::(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (tx_write, rx_write) = mpsc::channel::(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let tx_read_copy = tx_read.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let tx_write_copy = tx_write.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | let read_thread = { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let mut tcp_stream = tcp_stream.try_clone().expect_msg("connect_to_hub: cannot clone socket") ?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let write_thread = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let digest = digest.clone(); [INFO] [stdout] 189 | let tx_read = tx_read_copy.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(HubClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | uid_alloc: 0, [INFO] [stdout] 218 | | own_addr: own_addr, [INFO] [stdout] 219 | | server_addr: server_hubaddr, [INFO] [stdout] ... | [INFO] [stdout] 224 | | tx_write: tx_write [INFO] [stdout] 225 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubrouter.rs:153:24 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn connect_direct(&mut self, route_type: HubRouteType, tx_write: mpsc::Sender)->HubRouteSend{ [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | let tx_pump = self.tx_pump.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | uid_alloc: Arc::new(Mutex::new(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/httpserver.rs:174:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn start_http_server(config: &HttpServerConfig, workspaces_arc: Arc>>) -> Option { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let listener = if let Ok(listener) = TcpListener::bind(listen_address.clone()) {listener} else {println!("Cannot bind http server... [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let workspaces = Arc::clone(&workspaces_arc); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let shared = Arc::new(Mutex::new(HttpServerShared::default())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | let listen_thread = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let shared = Arc::clone(&shared); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Some(HttpServer { [INFO] [stdout] | ______________^ [INFO] [stdout] 175 | | listen_thread: Some(listen_thread), [INFO] [stdout] 176 | | listen_address: Some(listen_address.clone()), [INFO] [stdout] 177 | | shared: shared, [INFO] [stdout] 178 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `str::::to_lowercase` that must be used [INFO] [stdout] --> src/httpserver.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | url_lc.to_lowercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the lowercase string as a new String, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 77 | let _ = url_lc.to_lowercase(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `makepad-hub` (lib test) due to 7 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `kind`, `crate_types`, `name`, `src_path`, and `edition` are never read [INFO] [stdout] --> src/hubbuilder.rs:1137:5 [INFO] [stdout] | [INFO] [stdout] 1136 | pub struct RustcTarget { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 1137 | kind: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1138 | crate_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 1139 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1140 | src_path: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 1141 | edition: String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcTarget` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `text`, `highlight_start`, and `highlight_end` are never read [INFO] [stdout] --> src/hubbuilder.rs:1146:5 [INFO] [stdout] | [INFO] [stdout] 1145 | pub struct RustcText { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 1146 | text: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1147 | highlight_start: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 1148 | highlight_end: u32 [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcText` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/hubbuilder.rs:1157:5 [INFO] [stdout] | [INFO] [stdout] 1152 | pub struct RustcSpan { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 1157 | line_end: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 1158 | column_start: u32, [INFO] [stdout] 1159 | column_end: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 1160 | is_primary: bool, [INFO] [stdout] 1161 | text: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1162 | label: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 1163 | suggested_replacement: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 1164 | sugggested_applicability: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 1165 | expansion: Option>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 1166 | level: Option [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcSpan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `span`, `macro_decl_name`, and `def_site_span` are never read [INFO] [stdout] --> src/hubbuilder.rs:1171:5 [INFO] [stdout] | [INFO] [stdout] 1170 | pub struct RustcExpansion { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 1171 | span: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 1172 | macro_decl_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 1173 | def_site_span: Option [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcExpansion` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/hubbuilder.rs:1178:5 [INFO] [stdout] | [INFO] [stdout] 1177 | pub struct RustcCode { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 1178 | code: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcCode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `opt_level`, `debuginfo`, `debug_assertions`, `overflow_checks`, and `test` are never read [INFO] [stdout] --> src/hubbuilder.rs:1194:5 [INFO] [stdout] | [INFO] [stdout] 1193 | pub struct RustcProfile { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 1194 | opt_level: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 1195 | debuginfo: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 1196 | debug_assertions: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 1197 | overflow_checks: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 1198 | test: bool [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcProfile` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `reason`, `target`, `profile`, and `features` are never read [INFO] [stdout] --> src/hubbuilder.rs:1203:5 [INFO] [stdout] | [INFO] [stdout] 1202 | pub struct RustcCompilerMessage { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 1203 | reason: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 1204 | package_id: String, [INFO] [stdout] 1205 | target: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 1206 | message: Option, [INFO] [stdout] 1207 | profile: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 1208 | features: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RustcCompilerMessage` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/wasmstrip.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 74 | struct WasmSection{ [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 78 | pub name: String [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubui.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn start_hub_ui_direct(hub_router:&mut HubRouter,event_handler: F)->HubUI [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let (tx_write, rx_write) = mpsc::channel::(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let htc_msgs_arc = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let route_send = hub_router.connect_direct(HubRouteType::UI, tx_write); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | let thread = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let htc_msgs_arc = Arc::clone(&htc_msgs_arc); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let route_send = route_send.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let event_handler = event_handler.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubui.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 61 | let route_send = HubRouteSend::Networked{ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let htc_msgs_arc = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let thread = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let htc_msgs_arc = Arc::clone(&htc_msgs_arc); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let hub_log = hub_log.clone(); [INFO] [stdout] 73 | let event_handler = event_handler.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 34 | let mut child = create_process(cmd, args, current_dir, env) ?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | let (tx_line, rx_line) = mpsc::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let tx_err = tx_line.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut stdout = child.stdout.take().expect("stdout cannot be taken!"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut stderr = child.stderr.take().expect("stderr cannot be taken!"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | let _stdout_thread = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let _stderr_thread = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Process { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | child: Some(child), [INFO] [stdout] 98 | | rx_line: Some(rx_line), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubclient.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 140 | let mut tcp_stream = if let Ok(stream) = TcpStream::connect(local_address) { [INFO] [stdout] | ---------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let (tx_read, rx_read) = mpsc::channel::(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (tx_write, rx_write) = mpsc::channel::(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let tx_read_copy = tx_read.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let tx_write_copy = tx_write.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | let read_thread = { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let mut tcp_stream = tcp_stream.try_clone().expect_msg("connect_to_hub: cannot clone socket") ?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let write_thread = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let digest = digest.clone(); [INFO] [stdout] 189 | let tx_read = tx_read_copy.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(HubClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | uid_alloc: 0, [INFO] [stdout] 218 | | own_addr: own_addr, [INFO] [stdout] 219 | | server_addr: server_hubaddr, [INFO] [stdout] ... | [INFO] [stdout] 224 | | tx_write: tx_write [INFO] [stdout] 225 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hubrouter.rs:153:24 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn connect_direct(&mut self, route_type: HubRouteType, tx_write: mpsc::Sender)->HubRouteSend{ [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | let tx_pump = self.tx_pump.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | uid_alloc: Arc::new(Mutex::new(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/httpserver.rs:174:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn start_http_server(config: &HttpServerConfig, workspaces_arc: Arc>>) -> Option { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let listener = if let Ok(listener) = TcpListener::bind(listen_address.clone()) {listener} else {println!("Cannot bind http server... [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let workspaces = Arc::clone(&workspaces_arc); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let shared = Arc::new(Mutex::new(HttpServerShared::default())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | let listen_thread = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let shared = Arc::clone(&shared); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Some(HttpServer { [INFO] [stdout] | ______________^ [INFO] [stdout] 175 | | listen_thread: Some(listen_thread), [INFO] [stdout] 176 | | listen_address: Some(listen_address.clone()), [INFO] [stdout] 177 | | shared: shared, [INFO] [stdout] 178 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `str::::to_lowercase` that must be used [INFO] [stdout] --> src/httpserver.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | url_lc.to_lowercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the lowercase string as a new String, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 77 | let _ = url_lc.to_lowercase(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `makepad-hub` (lib) due to 7 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "66e54564676dd2919389c6d27b958939d1502618a35ce26a6463a3fdfe8d4759", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66e54564676dd2919389c6d27b958939d1502618a35ce26a6463a3fdfe8d4759", kill_on_drop: false }` [INFO] [stdout] 66e54564676dd2919389c6d27b958939d1502618a35ce26a6463a3fdfe8d4759