[INFO] fetching crate makepad-draw 0.6.0... [INFO] checking makepad-draw-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate makepad-draw 0.6.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate makepad-draw 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate makepad-draw 0.6.0 [INFO] finished tweaking crates.io crate makepad-draw 0.6.0 [INFO] tweaked toml for crates.io crate makepad-draw 0.6.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding rustybuzz v0.8.0 (latest: v0.18.0) [INFO] [stderr] Adding ttf-parser v0.19.2 (latest: v0.24.1) [INFO] [stderr] Adding unicode-bidi-mirroring v0.1.0 (latest: v0.3.0) [INFO] [stderr] Adding unicode-ccc v0.1.2 (latest: v0.3.0) [INFO] [stderr] Adding windows-core v0.51.1 (latest: v0.58.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b508cafc61e5171d4569432ff814f1d5248b0788e2e33201b96e6c0cc81737bc [INFO] running `Command { std: "docker" "start" "-a" "b508cafc61e5171d4569432ff814f1d5248b0788e2e33201b96e6c0cc81737bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b508cafc61e5171d4569432ff814f1d5248b0788e2e33201b96e6c0cc81737bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b508cafc61e5171d4569432ff814f1d5248b0788e2e33201b96e6c0cc81737bc", kill_on_drop: false }` [INFO] [stdout] b508cafc61e5171d4569432ff814f1d5248b0788e2e33201b96e6c0cc81737bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f62f2d4be14b25327e61c44f305c18e3bff395bc4c27048a7ae747af3b5f2f5 [INFO] running `Command { std: "docker" "start" "-a" "0f62f2d4be14b25327e61c44f305c18e3bff395bc4c27048a7ae747af3b5f2f5", kill_on_drop: false }` [INFO] [stderr] Compiling makepad-micro-proc-macro v0.4.0 [INFO] [stderr] Compiling makepad-derive-live v0.4.0 [INFO] [stderr] Compiling makepad-error-log v0.4.0 [INFO] [stderr] Checking makepad-math v0.4.0 [INFO] [stderr] Compiling unicode-general-category v0.6.0 [INFO] [stderr] Checking ttf-parser v0.19.2 [INFO] [stderr] Compiling makepad-platform v0.6.0 [INFO] [stderr] Checking unicode-bidi-mirroring v0.1.0 [INFO] [stderr] Checking unicode-ccc v0.1.2 [INFO] [stderr] Checking makepad-futures v0.4.0 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Compiling makepad-live-id-macros v0.4.0 [INFO] [stderr] Compiling makepad-micro-serde-derive v0.4.0 [INFO] [stderr] Checking makepad-live-id v0.4.0 [INFO] [stderr] Checking makepad-micro-serde v0.4.0 [INFO] [stderr] Checking makepad-live-tokenizer v0.4.0 [INFO] [stderr] Checking makepad-live-compiler v0.5.0 [INFO] [stderr] Checking makepad-vector v0.4.0 [INFO] [stderr] Checking rustybuzz v0.8.0 [INFO] [stderr] Checking makepad-shader-compiler v0.5.0 [INFO] [stderr] Checking makepad-draw v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `live_traits::*` [INFO] [stdout] --> src/shader/std.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | live_traits::*, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `live_traits::*` [INFO] [stdout] --> src/shader/std.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | live_traits::*, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font_atlas.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 238 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | atlas_pass: Pass::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font_atlas.rs:248:30 [INFO] [stdout] | [INFO] [stdout] 238 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | atlas_draw_list: DrawList2d::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font_atlas.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 480 | let owned_font_face = crate::owned_font_face::OwnedFace::parse(bytes, 0)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | let ttf_font = owned_font_face.with_ref(|face| makepad_vector::ttf_parser::from_ttf_parser_face(face)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 483 | | ttf_font, [INFO] [stdout] 484 | | owned_font_face, [INFO] [stdout] 485 | | atlas_pages: Vec::new(), [INFO] [stdout] 486 | | shape_cache: ShapeCache::new(), [INFO] [stdout] 487 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icon_atlas.rs:345:25 [INFO] [stdout] | [INFO] [stdout] 337 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | atlas_pass: Pass::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icon_atlas.rs:346:30 [INFO] [stdout] | [INFO] [stdout] 337 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | atlas_draw_list: DrawList2d::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/owned_font_face.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut pinned_box = Box::pin(FaceWithFontData { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self(pinned_box)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `makepad-draw` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font_atlas.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 238 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | atlas_pass: Pass::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font_atlas.rs:248:30 [INFO] [stdout] | [INFO] [stdout] 238 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | atlas_draw_list: DrawList2d::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/font_atlas.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 480 | let owned_font_face = crate::owned_font_face::OwnedFace::parse(bytes, 0)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | let ttf_font = owned_font_face.with_ref(|face| makepad_vector::ttf_parser::from_ttf_parser_face(face)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 483 | | ttf_font, [INFO] [stdout] 484 | | owned_font_face, [INFO] [stdout] 485 | | atlas_pages: Vec::new(), [INFO] [stdout] 486 | | shape_cache: ShapeCache::new(), [INFO] [stdout] 487 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icon_atlas.rs:345:25 [INFO] [stdout] | [INFO] [stdout] 337 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | atlas_pass: Pass::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icon_atlas.rs:346:30 [INFO] [stdout] | [INFO] [stdout] 337 | let atlas_texture = Texture::new(cx); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let draw_trapezoid = DrawTrapezoidVector::new_local(cx); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | atlas_draw_list: DrawList2d::new(cx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/owned_font_face.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut pinned_box = Box::pin(FaceWithFontData { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self(pinned_box)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `makepad-draw` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0f62f2d4be14b25327e61c44f305c18e3bff395bc4c27048a7ae747af3b5f2f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f62f2d4be14b25327e61c44f305c18e3bff395bc4c27048a7ae747af3b5f2f5", kill_on_drop: false }` [INFO] [stdout] 0f62f2d4be14b25327e61c44f305c18e3bff395bc4c27048a7ae747af3b5f2f5