[INFO] fetching crate magic 0.16.2... [INFO] checking magic-0.16.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate magic 0.16.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate magic 0.16.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate magic 0.16.2 [INFO] finished tweaking crates.io crate magic 0.16.2 [INFO] tweaked toml for crates.io crate magic 0.16.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate magic 0.16.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4329633d95f5fb4620c8f21227cb44403c47b2c9d20d2e8ca9c9d5a5c3d827d3 [INFO] running `Command { std: "docker" "start" "-a" "4329633d95f5fb4620c8f21227cb44403c47b2c9d20d2e8ca9c9d5a5c3d827d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4329633d95f5fb4620c8f21227cb44403c47b2c9d20d2e8ca9c9d5a5c3d827d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4329633d95f5fb4620c8f21227cb44403c47b2c9d20d2e8ca9c9d5a5c3d827d3", kill_on_drop: false }` [INFO] [stdout] 4329633d95f5fb4620c8f21227cb44403c47b2c9d20d2e8ca9c9d5a5c3d827d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18ac19cb781a979b605d934c31b59798d625ba77961c141c83fadd4d667ab655 [INFO] running `Command { std: "docker" "start" "-a" "18ac19cb781a979b605d934c31b59798d625ba77961c141c83fadd4d667ab655", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling magic-sys v0.3.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking magic v0.16.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:577:16 [INFO] [stdout] | [INFO] [stdout] 564 | pub fn new(paths: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 578 | | filenames: match filename.is_empty() { [INFO] [stdout] 579 | | true => None, [INFO] [stdout] 580 | | _ => Some(CString::new(filename).map_err(|_| InvalidDatabasePathError {})?), [INFO] [stdout] 581 | | }, [INFO] [stdout] 582 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:870:19 [INFO] [stdout] | [INFO] [stdout] 868 | pub fn file>(&self, filename: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 869 | let c_string = CString::new(filename.as_ref().to_string_lossy().into_owned()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 870 | match crate::ffi::file(&self.cookie, c_string.as_c_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:963:19 [INFO] [stdout] | [INFO] [stdout] 962 | pub fn load(self, filenames: &DatabasePaths) -> Result, LoadError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 963 | match crate::ffi::load(&self.cookie, filenames.filenames.as_deref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1001:19 [INFO] [stdout] | [INFO] [stdout] 1000 | pub fn load_buffers(self, buffers: &[&[u8]]) -> Result, LoadError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1001 | match crate::ffi::load_buffers(&self.cookie, buffers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `magic` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:577:16 [INFO] [stdout] | [INFO] [stdout] 564 | pub fn new(paths: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 578 | | filenames: match filename.is_empty() { [INFO] [stdout] 579 | | true => None, [INFO] [stdout] 580 | | _ => Some(CString::new(filename).map_err(|_| InvalidDatabasePathError {})?), [INFO] [stdout] 581 | | }, [INFO] [stdout] 582 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:870:19 [INFO] [stdout] | [INFO] [stdout] 868 | pub fn file>(&self, filename: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 869 | let c_string = CString::new(filename.as_ref().to_string_lossy().into_owned()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 870 | match crate::ffi::file(&self.cookie, c_string.as_c_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:963:19 [INFO] [stdout] | [INFO] [stdout] 962 | pub fn load(self, filenames: &DatabasePaths) -> Result, LoadError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 963 | match crate::ffi::load(&self.cookie, filenames.filenames.as_deref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1001:19 [INFO] [stdout] | [INFO] [stdout] 1000 | pub fn load_buffers(self, buffers: &[&[u8]]) -> Result, LoadError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1001 | match crate::ffi::load_buffers(&self.cookie, buffers) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `magic` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "18ac19cb781a979b605d934c31b59798d625ba77961c141c83fadd4d667ab655", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18ac19cb781a979b605d934c31b59798d625ba77961c141c83fadd4d667ab655", kill_on_drop: false }` [INFO] [stdout] 18ac19cb781a979b605d934c31b59798d625ba77961c141c83fadd4d667ab655