[INFO] fetching crate maelstrom-linux 0.11.0... [INFO] checking maelstrom-linux-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate maelstrom-linux 0.11.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate maelstrom-linux 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate maelstrom-linux 0.11.0 [INFO] finished tweaking crates.io crate maelstrom-linux 0.11.0 [INFO] tweaked toml for crates.io crate maelstrom-linux 0.11.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a1213846a5a10faef41cf8c500de1aaf1457407066ed882c45c2686b2402a5e [INFO] running `Command { std: "docker" "start" "-a" "9a1213846a5a10faef41cf8c500de1aaf1457407066ed882c45c2686b2402a5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a1213846a5a10faef41cf8c500de1aaf1457407066ed882c45c2686b2402a5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a1213846a5a10faef41cf8c500de1aaf1457407066ed882c45c2686b2402a5e", kill_on_drop: false }` [INFO] [stdout] 9a1213846a5a10faef41cf8c500de1aaf1457407066ed882c45c2686b2402a5e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35741773ca58abc4c05230a6ec3971e76daaf4709c4689bc0378783bc3de61ca [INFO] running `Command { std: "docker" "start" "-a" "35741773ca58abc4c05230a6ec3971e76daaf4709c4689bc0378783bc3de61ca", kill_on_drop: false }` [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking maelstrom-linux v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:980:8 [INFO] [stdout] | [INFO] [stdout] 977 | let fd = Errno::result(unsafe { libc::accept4(fd.0, addr_ptr, len_ptr, flags.0) }) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 980 | Ok((fd, sockaddr)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1000:8 [INFO] [stdout] | [INFO] [stdout] 987 | let sock = socket( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1000 | Ok((sock, addr)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1316:19 [INFO] [stdout] | [INFO] [stdout] 1316 | .map(|_| (OwnedFd(Fd(fds[0])), OwnedFd(Fd(fds[1])))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1316:40 [INFO] [stdout] | [INFO] [stdout] 1316 | .map(|_| (OwnedFd(Fd(fds[0])), OwnedFd(Fd(fds[1])))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1490:24 [INFO] [stdout] | [INFO] [stdout] 1487 | fn with_msghdr(buffer: &[u8], body: impl FnOnce(&mut libc::msghdr) -> RetT) -> RetT { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1490 | with_iovec(buffer, |io_vec| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 1491 | | let mut message = libc::msghdr { [INFO] [stdout] 1492 | | msg_name: ptr::null_mut(), [INFO] [stdout] 1493 | | msg_namelen: 0, [INFO] [stdout] ... | [INFO] [stdout] 1500 | | body(&mut message) [INFO] [stdout] 1501 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1507:28 [INFO] [stdout] | [INFO] [stdout] 1504 | fn with_msghdr_mut(buffer: &mut [u8], body: impl FnOnce(&mut libc::msghdr) -> RetT) -> RetT { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1507 | with_iovec_mut(buffer, |io_vec| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1508 | | let mut message = libc::msghdr { [INFO] [stdout] 1509 | | msg_name: ptr::null_mut(), [INFO] [stdout] 1510 | | msg_namelen: 0, [INFO] [stdout] ... | [INFO] [stdout] 1517 | | body(&mut message) [INFO] [stdout] 1518 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1584:16 [INFO] [stdout] | [INFO] [stdout] 1575 | let mut fd_out = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1584 | Ok((count, fd_out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:481:9 [INFO] [stdout] | [INFO] [stdout] 480 | fn from(owned_fd: OwnedFd) -> std::os::unix::net::UnixStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | fd::OwnedFd::from(owned_fd).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 495 | fn from(owned_fd: OwnedFd) -> std::os::unix::net::UnixListener { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | fd::OwnedFd::from(owned_fd).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:980:8 [INFO] [stdout] | [INFO] [stdout] 977 | let fd = Errno::result(unsafe { libc::accept4(fd.0, addr_ptr, len_ptr, flags.0) }) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 980 | Ok((fd, sockaddr)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1000:8 [INFO] [stdout] | [INFO] [stdout] 987 | let sock = socket( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1000 | Ok((sock, addr)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1316:19 [INFO] [stdout] | [INFO] [stdout] 1316 | .map(|_| (OwnedFd(Fd(fds[0])), OwnedFd(Fd(fds[1])))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1316:40 [INFO] [stdout] | [INFO] [stdout] 1316 | .map(|_| (OwnedFd(Fd(fds[0])), OwnedFd(Fd(fds[1])))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1490:24 [INFO] [stdout] | [INFO] [stdout] 1487 | fn with_msghdr(buffer: &[u8], body: impl FnOnce(&mut libc::msghdr) -> RetT) -> RetT { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1490 | with_iovec(buffer, |io_vec| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 1491 | | let mut message = libc::msghdr { [INFO] [stdout] 1492 | | msg_name: ptr::null_mut(), [INFO] [stdout] 1493 | | msg_namelen: 0, [INFO] [stdout] ... | [INFO] [stdout] 1500 | | body(&mut message) [INFO] [stdout] 1501 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1507:28 [INFO] [stdout] | [INFO] [stdout] 1504 | fn with_msghdr_mut(buffer: &mut [u8], body: impl FnOnce(&mut libc::msghdr) -> RetT) -> RetT { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1507 | with_iovec_mut(buffer, |io_vec| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1508 | | let mut message = libc::msghdr { [INFO] [stdout] 1509 | | msg_name: ptr::null_mut(), [INFO] [stdout] 1510 | | msg_namelen: 0, [INFO] [stdout] ... | [INFO] [stdout] 1517 | | body(&mut message) [INFO] [stdout] 1518 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1584:16 [INFO] [stdout] | [INFO] [stdout] 1575 | let mut fd_out = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1584 | Ok((count, fd_out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `maelstrom-linux` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `maelstrom-linux` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "35741773ca58abc4c05230a6ec3971e76daaf4709c4689bc0378783bc3de61ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35741773ca58abc4c05230a6ec3971e76daaf4709c4689bc0378783bc3de61ca", kill_on_drop: false }` [INFO] [stdout] 35741773ca58abc4c05230a6ec3971e76daaf4709c4689bc0378783bc3de61ca