[INFO] fetching crate machine_setup 1.3.6... [INFO] checking machine_setup-1.3.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate machine_setup 1.3.6 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate machine_setup 1.3.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate machine_setup 1.3.6 [INFO] finished tweaking crates.io crate machine_setup 1.3.6 [INFO] tweaked toml for crates.io crate machine_setup 1.3.6 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate machine_setup 1.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4add8f919892e0a53b4f5ae100eee2a9e7cb15f111559fba5c2d066fa20c6bc3 [INFO] running `Command { std: "docker" "start" "-a" "4add8f919892e0a53b4f5ae100eee2a9e7cb15f111559fba5c2d066fa20c6bc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4add8f919892e0a53b4f5ae100eee2a9e7cb15f111559fba5c2d066fa20c6bc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4add8f919892e0a53b4f5ae100eee2a9e7cb15f111559fba5c2d066fa20c6bc3", kill_on_drop: false }` [INFO] [stdout] 4add8f919892e0a53b4f5ae100eee2a9e7cb15f111559fba5c2d066fa20c6bc3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed6e8e294394648015f9cdbd68f92135e33334911798fd1e1c7c559f61e2e633 [INFO] running `Command { std: "docker" "start" "-a" "ed6e8e294394648015f9cdbd68f92135e33334911798fd1e1c7c559f61e2e633", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling anstyle v1.0.4 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling anstyle-query v1.0.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling clap_lex v0.6.0 [INFO] [stderr] Compiling anstyle-parse v0.2.2 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling anstream v0.6.4 [INFO] [stderr] Compiling pin-project-lite v0.2.13 [INFO] [stderr] Compiling portable-atomic v1.5.1 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking std_prelude v0.2.12 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking symlink v0.1.0 [INFO] [stderr] Compiling terminal_size v0.3.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling clap_builder v4.4.9 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking xattr v1.0.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking shellexpand v1.1.1 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking git_commands v0.2.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking stfu8 v0.2.6 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Compiling clap v4.4.10 [INFO] [stderr] Compiling clap_complete v4.4.4 [INFO] [stderr] Compiling machine_setup v1.3.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking path_abs v0.4.1 [INFO] [stderr] Checking ergo_fs v0.2.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/directory.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 79 | let src_rules: Vec> = vec![Box::new(Required {})]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let target_rules: Vec> = vec![Box::new(Required {})]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let ignore: HashSet = args [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Dirs { [INFO] [stdout] | ________^ [INFO] [stdout] 125 | | src: relative_src_dir, [INFO] [stdout] 126 | | target: relative_target_dir, [INFO] [stdout] 127 | | ignore, [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/temp_storage.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 28 | let file = match File::create(&file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Err(error) => return Err(error.to_string()), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(FileInfo { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | path: PathBuf::from(&file_path), [INFO] [stdout] 35 | | file, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 43 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `machine_setup` (bin "machine_setup") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/directory.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 79 | let src_rules: Vec> = vec![Box::new(Required {})]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let target_rules: Vec> = vec![Box::new(Required {})]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let ignore: HashSet = args [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Dirs { [INFO] [stdout] | ________^ [INFO] [stdout] 125 | | src: relative_src_dir, [INFO] [stdout] 126 | | target: relative_target_dir, [INFO] [stdout] 127 | | ignore, [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/temp_storage.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 28 | let file = match File::create(&file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Err(error) => return Err(error.to_string()), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(FileInfo { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | path: PathBuf::from(&file_path), [INFO] [stdout] 35 | | file, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/threads.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 43 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `machine_setup` (bin "machine_setup" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ed6e8e294394648015f9cdbd68f92135e33334911798fd1e1c7c559f61e2e633", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed6e8e294394648015f9cdbd68f92135e33334911798fd1e1c7c559f61e2e633", kill_on_drop: false }` [INFO] [stdout] ed6e8e294394648015f9cdbd68f92135e33334911798fd1e1c7c559f61e2e633