[INFO] fetching crate lz_diet 0.1.6... [INFO] checking lz_diet-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lz_diet 0.1.6 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate lz_diet 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lz_diet 0.1.6 [INFO] finished tweaking crates.io crate lz_diet 0.1.6 [INFO] tweaked toml for crates.io crate lz_diet 0.1.6 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate lz_diet 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa766f6d407e25f8bc2d5d260297fdc6c6b66fd8e18596b3add527032c46a154 [INFO] running `Command { std: "docker" "start" "-a" "aa766f6d407e25f8bc2d5d260297fdc6c6b66fd8e18596b3add527032c46a154", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa766f6d407e25f8bc2d5d260297fdc6c6b66fd8e18596b3add527032c46a154", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa766f6d407e25f8bc2d5d260297fdc6c6b66fd8e18596b3add527032c46a154", kill_on_drop: false }` [INFO] [stdout] aa766f6d407e25f8bc2d5d260297fdc6c6b66fd8e18596b3add527032c46a154 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e00c23c49f13bcdd7afd1dcacbf56ba019061d3e4c02c0099373371f4e7c0df [INFO] running `Command { std: "docker" "start" "-a" "8e00c23c49f13bcdd7afd1dcacbf56ba019061d3e4c02c0099373371f4e7c0df", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling regex v1.1.7 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking regex-syntax v0.6.7 [INFO] [stderr] Checking binary-tree v0.2.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking lz_diet v0.1.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stdout] warning: methods `insert_after`, `insert_max`, and `insert_min` are never used [INFO] [stdout] --> src/node_mut_ext.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) trait NodeMutExt: NodeMut { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 10 | fn insert_after(&mut self, new_node: ::NodePtr, mut step_out: F) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | fn insert_max(&mut self, new_node: ::NodePtr, mut step_out: F) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 50 | fn insert_min(&mut self, new_node: ::NodePtr, mut step_out: F) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:282:23 [INFO] [stdout] | [INFO] [stdout] 281 | fn into_iter(mut self) -> Self::IntoIter { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | IntoIter::new(self.root.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_mut_ext.rs:84:39 [INFO] [stdout] | [INFO] [stdout] 84 | |node| step_in(node, &mut *state.borrow_mut()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_mut_ext.rs:85:36 [INFO] [stdout] | [INFO] [stdout] 73 | stop: FS, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | |node| stop(node, &mut *state.borrow_mut()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_mut_ext.rs:86:56 [INFO] [stdout] | [INFO] [stdout] 86 | |node, action| step_out(node, action, &mut *state.borrow_mut()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diet_node.rs:470:23 [INFO] [stdout] | [INFO] [stdout] 469 | let value = value_option.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | match node.insert_or_walk(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diet_node.rs:569:15 [INFO] [stdout] | [INFO] [stdout] 511 | pub(crate) fn split(self, value: Cow) -> SplitResult> [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | let mut merged_left = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 519 | let mut merged_right = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | [INFO] [stdout] 521 | let mut current = Some(self); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | match (merged_left, merged_right) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diet_node.rs:607:23 [INFO] [stdout] | [INFO] [stdout] 603 | let value = to_remove [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | match node.remove_or_walk(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterators.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(root: Option>>) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | IntoIter { [INFO] [stdout] 35 | inner: GenIntoIter::new(root), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lz_diet` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8e00c23c49f13bcdd7afd1dcacbf56ba019061d3e4c02c0099373371f4e7c0df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e00c23c49f13bcdd7afd1dcacbf56ba019061d3e4c02c0099373371f4e7c0df", kill_on_drop: false }` [INFO] [stdout] 8e00c23c49f13bcdd7afd1dcacbf56ba019061d3e4c02c0099373371f4e7c0df