[INFO] fetching crate lyricer 1.0.3... [INFO] checking lyricer-1.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lyricer 1.0.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate lyricer 1.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lyricer 1.0.3 [INFO] finished tweaking crates.io crate lyricer 1.0.3 [INFO] tweaked toml for crates.io crate lyricer 1.0.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate lyricer 1.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c442178f29a48902bc21778b34c42f625d358d61df1fa5cd3a71ad9d72945b7 [INFO] running `Command { std: "docker" "start" "-a" "0c442178f29a48902bc21778b34c42f625d358d61df1fa5cd3a71ad9d72945b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c442178f29a48902bc21778b34c42f625d358d61df1fa5cd3a71ad9d72945b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c442178f29a48902bc21778b34c42f625d358d61df1fa5cd3a71ad9d72945b7", kill_on_drop: false }` [INFO] [stdout] 0c442178f29a48902bc21778b34c42f625d358d61df1fa5cd3a71ad9d72945b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fbfa009dc148d6c46862ed7e1149ffad59eed9686c6b4c2a6c45f3857a34ccfa [INFO] running `Command { std: "docker" "start" "-a" "fbfa009dc148d6c46862ed7e1149ffad59eed9686c6b4c2a6c45f3857a34ccfa", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling proc-macro2 v0.3.8 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling proc-macro2 v0.2.3 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling error-chain v0.10.0 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking urlencoding v1.1.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling quote v0.4.2 [INFO] [stderr] Compiling libdbus-sys v0.2.1 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Compiling syn v0.12.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking dbus v0.6.5 [INFO] [stderr] Compiling derive_is_enum_variant v0.1.1 [INFO] [stderr] Checking addr2line v0.14.0 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Compiling enum-kinds v0.4.1 [INFO] [stderr] Checking backtrace v0.3.54 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling darling_core v0.4.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling darling_macro v0.4.0 [INFO] [stderr] Compiling darling v0.4.0 [INFO] [stderr] Compiling from_variants_impl v0.3.0 [INFO] [stderr] Checking from_variants v0.3.0 [INFO] [stderr] Checking mpris v1.1.2 [INFO] [stderr] Checking lyricer v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `metadata` is never read [INFO] [stdout] --> src/lyric.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Lyric { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 3 | pub metadata: std::collections::HashMap, Box>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Lyric` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lyric.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 9 | let mut metadata = std::collections::HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let mut content = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | metadata, [INFO] [stdout] 54 | | content: content.into_boxed_slice(), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lyric.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 94 | let mut parsed_string = Vec::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(Self::Enhanced(duration, parsed_string.into_boxed_slice())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lyric.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 115 | let mut parsed = Self::parse_standard(line)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(Self::parse_enhanced(&mut parsed).unwrap_or(parsed)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lyricer` (bin "lyricer") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `metadata` is never read [INFO] [stdout] --> src/lyric.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Lyric { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 3 | pub metadata: std::collections::HashMap, Box>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Lyric` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lyric.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 9 | let mut metadata = std::collections::HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let mut content = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | metadata, [INFO] [stdout] 54 | | content: content.into_boxed_slice(), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lyric.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 94 | let mut parsed_string = Vec::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(Self::Enhanced(duration, parsed_string.into_boxed_slice())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lyric.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 115 | let mut parsed = Self::parse_standard(line)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(Self::parse_enhanced(&mut parsed).unwrap_or(parsed)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lyricer` (bin "lyricer" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "fbfa009dc148d6c46862ed7e1149ffad59eed9686c6b4c2a6c45f3857a34ccfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbfa009dc148d6c46862ed7e1149ffad59eed9686c6b4c2a6c45f3857a34ccfa", kill_on_drop: false }` [INFO] [stdout] fbfa009dc148d6c46862ed7e1149ffad59eed9686c6b4c2a6c45f3857a34ccfa