[INFO] fetching crate lxtrace 0.1.0... [INFO] checking lxtrace-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lxtrace 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate lxtrace 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lxtrace 0.1.0 [INFO] finished tweaking crates.io crate lxtrace 0.1.0 [INFO] tweaked toml for crates.io crate lxtrace 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate lxtrace 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc3a3296caba48bd3ca1c15ff9d9d3ff7ebc356f0f3267a9cb690465e4f77303 [INFO] running `Command { std: "docker" "start" "-a" "fc3a3296caba48bd3ca1c15ff9d9d3ff7ebc356f0f3267a9cb690465e4f77303", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc3a3296caba48bd3ca1c15ff9d9d3ff7ebc356f0f3267a9cb690465e4f77303", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc3a3296caba48bd3ca1c15ff9d9d3ff7ebc356f0f3267a9cb690465e4f77303", kill_on_drop: false }` [INFO] [stdout] fc3a3296caba48bd3ca1c15ff9d9d3ff7ebc356f0f3267a9cb690465e4f77303 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8364c8c11cbd61fddd4cc82a59a0211c7c2d72d9313634054564f4b58bf1dc1a [INFO] running `Command { std: "docker" "start" "-a" "8364c8c11cbd61fddd4cc82a59a0211c7c2d72d9313634054564f4b58bf1dc1a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.7 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling cc v1.0.46 [INFO] [stderr] Compiling pkg-config v0.3.16 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling error-chain v0.12.1 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling unwind v0.3.0 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Compiling pest v2.1.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking foreign-types-shared v0.3.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling anyhow v1.0.18 [INFO] [stderr] Compiling nix v0.16.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Compiling cpp_demangle v0.2.13 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Compiling unwind-sys v0.1.1 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam v0.7.2 [INFO] [stderr] Compiling pest_meta v2.1.2 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling pest_generator v2.1.1 [INFO] [stderr] Compiling foreign-types-macros v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling structopt-derive v0.3.3 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking rstack v0.3.1 [INFO] [stderr] Checking structopt v0.3.3 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking tiny-nix-ipc v0.1.1 [INFO] [stderr] Checking lxtrace v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/child.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | if let Err(e) = nix::unistd::execvpe(spawn_opts.exe, spawn_opts.argv, spawn_opts.env) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/child.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | if let Err(e) = nix::unistd::execvpe(spawn_opts.exe, spawn_opts.argv, spawn_opts.env) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall_decode.rs:210:14 [INFO] [stdout] | [INFO] [stdout] 200 | let ret_val = self.do_decode_ret(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let evaluated = std::mem::replace(&mut self.evaluated, Vec::new()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | //dbg!(&evaluated); [INFO] [stdout] 205 | let args: Option> = evaluated.into_iter().collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let mut args = args?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let ret = args [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Some(Syscall { [INFO] [stdout] | ______________^ [INFO] [stdout] 211 | | name: syscall_spec.name.clone(), [INFO] [stdout] 212 | | args, [INFO] [stdout] 213 | | ret: Some(ret), [INFO] [stdout] 214 | | backtrace: None, [INFO] [stdout] 215 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall_decode.rs:210:14 [INFO] [stdout] | [INFO] [stdout] 200 | let ret_val = self.do_decode_ret(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let evaluated = std::mem::replace(&mut self.evaluated, Vec::new()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | //dbg!(&evaluated); [INFO] [stdout] 205 | let args: Option> = evaluated.into_iter().collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let mut args = args?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let ret = args [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Some(Syscall { [INFO] [stdout] | ______________^ [INFO] [stdout] 211 | | name: syscall_spec.name.clone(), [INFO] [stdout] 212 | | args, [INFO] [stdout] 213 | | ret: Some(ret), [INFO] [stdout] 214 | | backtrace: None, [INFO] [stdout] 215 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lxtrace` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `lxtrace` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8364c8c11cbd61fddd4cc82a59a0211c7c2d72d9313634054564f4b58bf1dc1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8364c8c11cbd61fddd4cc82a59a0211c7c2d72d9313634054564f4b58bf1dc1a", kill_on_drop: false }` [INFO] [stdout] 8364c8c11cbd61fddd4cc82a59a0211c7c2d72d9313634054564f4b58bf1dc1a