[INFO] fetching crate luwen-ref 0.3.1... [INFO] checking luwen-ref-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate luwen-ref 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate luwen-ref 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate luwen-ref 0.3.1 [INFO] finished tweaking crates.io crate luwen-ref 0.3.1 [INFO] tweaked toml for crates.io crate luwen-ref 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding bitfield-struct v0.4.4 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding memmap2 v0.7.1 (latest: v0.9.4) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e10597af9d877a7253c7df5f6a183985729da8e38af97306497244b3033ad078 [INFO] running `Command { std: "docker" "start" "-a" "e10597af9d877a7253c7df5f6a183985729da8e38af97306497244b3033ad078", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e10597af9d877a7253c7df5f6a183985729da8e38af97306497244b3033ad078", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e10597af9d877a7253c7df5f6a183985729da8e38af97306497244b3033ad078", kill_on_drop: false }` [INFO] [stdout] e10597af9d877a7253c7df5f6a183985729da8e38af97306497244b3033ad078 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce233f0ea0403f8210a55035c9dc145739a5c6d8f44f2dcec239557559861ecd [INFO] running `Command { std: "docker" "start" "-a" "ce233f0ea0403f8210a55035c9dc145739a5c6d8f44f2dcec239557559861ecd", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling bitfield-struct v0.4.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking luwen-core v0.1.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rust-embed-utils v8.5.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling rust-embed-impl v8.5.0 [INFO] [stderr] Checking rust-embed v8.5.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking luwen-if v0.4.4 [INFO] [stderr] Checking ttkmd-if v0.1.0 [INFO] [stderr] Checking luwen-ref v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/detect.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | Err(InitError::CallbackError(err)) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/detect.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | Err(InitError::CallbackError(err)) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 161 | let device = PciDevice::open(pci_interface)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(ExtendedPciDeviceWrapper { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | inner: Arc::new(RwLock::new(ExtendedPciDevice { [INFO] [stdout] 171 | | device, [INFO] [stdout] 172 | | harvested_rows: 0, [INFO] [stdout] ... | [INFO] [stdout] 183 | | })), [INFO] [stdout] 184 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:612:8 [INFO] [stdout] | [INFO] [stdout] 608 | let ud = ExtendedPciDevice::open(interface_id)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | Ok(luwen_if::chip::Chip::open( [INFO] [stdout] | ________^ [INFO] [stdout] 613 | | arch, [INFO] [stdout] 614 | | luwen_if::CallbackStorage::new(comms_callback, ud.clone()), [INFO] [stdout] 615 | | )?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:25:35 [INFO] [stdout] | [INFO] [stdout] 24 | fn from(value: ArcMsgError) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | LuwenError::PlatformError(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luwen-ref` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 161 | let device = PciDevice::open(pci_interface)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(ExtendedPciDeviceWrapper { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | inner: Arc::new(RwLock::new(ExtendedPciDevice { [INFO] [stdout] 171 | | device, [INFO] [stdout] 172 | | harvested_rows: 0, [INFO] [stdout] ... | [INFO] [stdout] 183 | | })), [INFO] [stdout] 184 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:612:8 [INFO] [stdout] | [INFO] [stdout] 608 | let ud = ExtendedPciDevice::open(interface_id)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | Ok(luwen_if::chip::Chip::open( [INFO] [stdout] | ________^ [INFO] [stdout] 613 | | arch, [INFO] [stdout] 614 | | luwen_if::CallbackStorage::new(comms_callback, ud.clone()), [INFO] [stdout] 615 | | )?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:25:35 [INFO] [stdout] | [INFO] [stdout] 24 | fn from(value: ArcMsgError) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | LuwenError::PlatformError(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luwen-ref` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ce233f0ea0403f8210a55035c9dc145739a5c6d8f44f2dcec239557559861ecd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce233f0ea0403f8210a55035c9dc145739a5c6d8f44f2dcec239557559861ecd", kill_on_drop: false }` [INFO] [stdout] ce233f0ea0403f8210a55035c9dc145739a5c6d8f44f2dcec239557559861ecd