[INFO] fetching crate luwen-if 0.4.4... [INFO] checking luwen-if-0.4.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate luwen-if 0.4.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate luwen-if 0.4.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate luwen-if 0.4.4 [INFO] finished tweaking crates.io crate luwen-if 0.4.4 [INFO] tweaked toml for crates.io crate luwen-if 0.4.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26d1212fbfcb4282ff59e2cb3165839be9c89eedc68911cb4ef97bdf5e6f3a3a [INFO] running `Command { std: "docker" "start" "-a" "26d1212fbfcb4282ff59e2cb3165839be9c89eedc68911cb4ef97bdf5e6f3a3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26d1212fbfcb4282ff59e2cb3165839be9c89eedc68911cb4ef97bdf5e6f3a3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26d1212fbfcb4282ff59e2cb3165839be9c89eedc68911cb4ef97bdf5e6f3a3a", kill_on_drop: false }` [INFO] [stdout] 26d1212fbfcb4282ff59e2cb3165839be9c89eedc68911cb4ef97bdf5e6f3a3a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4a2366a3666242ee25c2be80aa355a2ee20ef7a9ee9ab9a36daa9f9c4831e54 [INFO] running `Command { std: "docker" "start" "-a" "a4a2366a3666242ee25c2be80aa355a2ee20ef7a9ee9ab9a36daa9f9c4831e54", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling cpufeatures v0.2.13 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking luwen-core v0.1.0 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rust-embed-utils v8.5.0 [INFO] [stderr] Compiling rust-embed-impl v8.5.0 [INFO] [stderr] Checking rust-embed v8.5.0 [INFO] [stderr] Checking luwen-if v0.4.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `DramInitError` [INFO] [stdout] --> src/chip/grayskull.rs:16:55 [INFO] [stdout] | [INFO] [stdout] 16 | init::status::{ArcInitError, ComponentStatusInfo, DramInitError, InitOptions, WaitStatus}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DramInitError` [INFO] [stdout] --> src/chip/grayskull.rs:16:55 [INFO] [stdout] | [INFO] [stdout] 16 | init::status::{ArcInitError, ComponentStatusInfo, DramInitError, InitOptions, WaitStatus}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `backtrace` [INFO] [stdout] --> src/chip/grayskull.rs:388:77 [INFO] [stdout] | [INFO] [stdout] 388 | ... crate::ArcMsgError::ProtocolError { source, backtrace } => match source { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `backtrace: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `source` [INFO] [stdout] --> src/chip/grayskull.rs:403:37 [INFO] [stdout] | [INFO] [stdout] 403 | ... source => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_source` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/chip/init/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | InitError::CallbackError(_) => unreachable!(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/detect_chips.rs:408:13 [INFO] [stdout] | [INFO] [stdout] 408 | InitError::CallbackError(_) => unreachable!(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chip/creation.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | backend: CallbackStorage, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | ) -> Result { [INFO] [stdout] 77 | Ok(Chip { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | inner: match arch { [INFO] [stdout] 79 | | Arch::Grayskull => Box::new(Self::gs_open(arch, backend)?), [INFO] [stdout] 80 | | Arch::Wormhole => Box::new(Self::wh_open(arch, backend)?), [INFO] [stdout] 81 | | _ => panic!("Unsupported chip"), [INFO] [stdout] 82 | | }, [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chip/grayskull.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 33 | chip_if: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | arc_if: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | telemetry_addr: Arc::new(once_cell::sync::OnceCell::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chip/wormhole.rs:207:40 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn open_remote(&self, addr: impl IntoChip) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Self::init(true, true, arc_if, self.chip_if.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/detect_chips.rs:405:5 [INFO] [stdout] | [INFO] [stdout] 402 | root_chips: Vec, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | detect_initialized_chips::(root_chips, &mut |_| Ok(()), options) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 90 | fn from(e: Box) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self::GenericError(e, BtWrapper::capture()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luwen-if` (lib) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `backtrace` [INFO] [stdout] --> src/chip/grayskull.rs:388:77 [INFO] [stdout] | [INFO] [stdout] 388 | ... crate::ArcMsgError::ProtocolError { source, backtrace } => match source { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `backtrace: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `source` [INFO] [stdout] --> src/chip/grayskull.rs:403:37 [INFO] [stdout] | [INFO] [stdout] 403 | ... source => { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_source` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/chip/init/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | InitError::CallbackError(_) => unreachable!(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/detect_chips.rs:408:13 [INFO] [stdout] | [INFO] [stdout] 408 | InitError::CallbackError(_) => unreachable!(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chip/creation.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 75 | backend: CallbackStorage, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | ) -> Result { [INFO] [stdout] 77 | Ok(Chip { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | inner: match arch { [INFO] [stdout] 79 | | Arch::Grayskull => Box::new(Self::gs_open(arch, backend)?), [INFO] [stdout] 80 | | Arch::Wormhole => Box::new(Self::wh_open(arch, backend)?), [INFO] [stdout] 81 | | _ => panic!("Unsupported chip"), [INFO] [stdout] 82 | | }, [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chip/grayskull.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 33 | chip_if: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | arc_if: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | telemetry_addr: Arc::new(once_cell::sync::OnceCell::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chip/wormhole.rs:207:40 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn open_remote(&self, addr: impl IntoChip) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Self::init(true, true, arc_if, self.chip_if.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/detect_chips.rs:405:5 [INFO] [stdout] | [INFO] [stdout] 402 | root_chips: Vec, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | detect_initialized_chips::(root_chips, &mut |_| Ok(()), options) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 90 | fn from(e: Box) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self::GenericError(e, BtWrapper::capture()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luwen-if` (lib test) due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a4a2366a3666242ee25c2be80aa355a2ee20ef7a9ee9ab9a36daa9f9c4831e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4a2366a3666242ee25c2be80aa355a2ee20ef7a9ee9ab9a36daa9f9c4831e54", kill_on_drop: false }` [INFO] [stdout] a4a2366a3666242ee25c2be80aa355a2ee20ef7a9ee9ab9a36daa9f9c4831e54